From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 4A8D93DD519
	for <linux-kernel@vger.kernel.org>; Wed, 13 May 2026 08:15:55 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1778660160; cv=none; b=Q6PazrGxM4FxdD1XMWDfkW1ELwhonvxlnkeUtcCHmLmAZN8Y8QLWW/8gBJJhocWWbHJylxL3JDk+x59rMOIL317ow9M4waj0wsGyx/0thwkkMCQZ7zrpgfJSg8uj/DCaz1C4Ov7jzk6PEueIqkiXqVRozv4gInDV+r1m0C6Dpog=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1778660160; c=relaxed/simple;
	bh=FleCqJXLGbjsm3lXawHNhEeyQjwtpuikYn1w59j6nF8=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=hi6cPU77UwWhds2zW/I0hV59QckRecBV+Ir2JfbCDX5mAVDbVKET7cuEbfAG0LOScu9wh8KuV9MiSUpZZHltHcTtsjdzO2goWFuOZiIcXoiu+m7lAySH3EXR4b9FvPlLiFXzzBFOBnYyiV9M+EK8eJlAv6zmpepClT9k4ESFwZs=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b=n+Yh0WiY; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.b="n+Yh0WiY"
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09E99165C;
	Wed, 13 May 2026 01:15:49 -0700 (PDT)
Received: from localhost (e132581.arm.com [10.1.196.87])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC1623F7B4;
	Wed, 13 May 2026 01:15:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss;
	t=1778660154; bh=FleCqJXLGbjsm3lXawHNhEeyQjwtpuikYn1w59j6nF8=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
	b=n+Yh0WiY5X5IzfXkNMxiXyoqs8ZFN7YpnDA7OnGnbx6Iz7vfzyolPzQoGYMi2564b
	 GlHo6HwGGlHfsNECvi/vI8YlmVcM9H5pbhyjRjsSxOjRwHRFK5q0RvNNpbtQ3h3+5/
	 BoSQovl+Val3gsm+lzNqHxJBlzLT/kVbIfNXFz68=
Date: Wed, 13 May 2026 09:15:51 +0100
From: Leo Yan <leo.yan@arm.com>
To: James Clark <james.clark@linaro.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Mike Leach <mike.leach@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coresight: trbe: Hide enable_sink sysfs file
Message-ID: <20260513081551.GC34802@e132581.arm.com>
References: <20260507-james-cs-hide-trbe-enable-v1-1-b4e40439f44c@linaro.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20260507-james-cs-hide-trbe-enable-v1-1-b4e40439f44c@linaro.org>

On Thu, May 07, 2026 at 11:53:45AM +0100, James Clark wrote:

[...]

> +static umode_t coresight_attr_is_visible(struct kobject *kobj,
> +					 struct attribute *attr, int n)
>  {
>  	struct device *dev = kobj_to_dev(kobj);
> +	struct coresight_device *csdev = to_coresight_device(dev);
>  
>  	if (attr == &dev_attr_label.attr) {
>  		if (fwnode_property_present(dev_fwnode(dev), "label"))
>  			return attr->mode;
>  		else
>  			return 0;
> +	} else if (attr == &dev_attr_enable_sink.attr ||
> +		   attr == &dev_attr_enable_source.attr) {
> +		if (csdev->no_sysfs_mode)
> +			return 0;
> +		else
> +			return attr->mode;

I'd prefer no_sysfs_mode to work as a general flag rather than being
limited to sink/source devices only. Otherwise, LGTM.

Thanks,
Leo