From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A151E3C4547 for ; Wed, 13 May 2026 09:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778663439; cv=none; b=ZxZ4t5oeYEqf8Q/BrIasg64Sty2+Cxa0ik4PNd8OCqQkMj4o7EAo1JWnePNz2xgBtW96Q/llNs2u2utWoaa5suzJCwjdKnpgib0Cruuj+EIpS5SVrilCFgwyMyIdV3Njj7srom4+nt+faBZCrGQQ9beJzICBqEz8Aav0uYw1QhE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778663439; c=relaxed/simple; bh=rC7nG2+GpOdgcnUjLzX1d00FpSLVoi1YuxHiT2V+/I0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=D14ltZPCZuyz/+ns9OtDUPY2tAaHP9qFwN7b0X7xzPfvU3ub5kfyNKRQ3X4EfWfh0FQOpzCzBC3UOq5xacXJ1TbJ+pxGrKKxmUA+nR1iQs+Zr7jc5sukZYPUy1GQM5ntewMpNwqgyYAr3TiWqzmXQGwvg0Ckr2/1P36w2a/FPJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LyexIRYR; arc=none smtp.client-ip=209.85.214.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LyexIRYR" Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-2ba856db1c0so44298095ad.3 for ; Wed, 13 May 2026 02:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778663437; x=1779268237; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DDkyCdkfOQyq4nl3ME+VrFeCYaGPzyVj4zyQTMVwELs=; b=LyexIRYRLdUQev7TBo5Z+ts7VTbJytCBJCtWS8RnDNXxU25YCh/eNBRueblnLLaVE7 iAl5A9Y9AjaN723Y5ieLf7bZjjA+mUe4BUETfqoTxmrrBMHNSTLTSa+gNpiDudkYZtNW c1L/E7+m6BnmZyYXgHlHTTIfP4cpvPgVEnjveSlt2YrUUT/3F0FT+73bxS7nehXsZBPv xS2CLWfSLV98lSKhIGUdmzCAZR/xiUQ9g62+y6/EJjboeShBvipRJwNHkvVuFoOcmTt+ Qxlaykwf5cljBd64t8etPhHdE0Ayd2RtaqPgV7hsYL+ABd2a6TnUI2ieTHvlR35zaWSU +V+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778663437; x=1779268237; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DDkyCdkfOQyq4nl3ME+VrFeCYaGPzyVj4zyQTMVwELs=; b=miG73UGMEF15+yTbwGYALbsHHRAThn5F1BMQ2DfDpffQAQbcYiMTOCDsZB2FDp0DVE qQkRaZIJ0D7vAy/oRnvBzczY5e24juIsKseVwxUWpPs9TzBnfhQLV6Wyp65yOEmMexJQ tZDGmvWxJAeqSh9BwUWbI3mZd1YJgWuB1nEuqsDte3kGcls1w75pyOKIRbNcHdFRMnna mo2Bp9XJPJLt2pHKJfHx6bwDO8twvd9xmZkJpODxa7wiU/jDFC2meIHwfOLZZhCjpq9+ Iueoj7ezZnum7J9eEqGEyT+SVsE97zffi/V4MsB3MF9DQ7f4RWV4OR7J/i29dLXaU28v 9aLQ== X-Forwarded-Encrypted: i=1; AFNElJ+4m0xPxre4IPPI+6BbK6kHlHMBz5YytPnjDoRZU+1x7YjQQJra+WYHxmK8dejzrF1OIpCiD8hpg9945wU=@vger.kernel.org X-Gm-Message-State: AOJu0Yy63J4bKM5GFpmrs9fZXEC28Z+C1sS+SSjgy/lnV8LupPhkgz6y sJuSRpc2ZC24x55xk14xApgYyWxt2hY4uFrq4ltmc3QV3E9IEeNoPNBl X-Gm-Gg: Acq92OE1WhcTu3a7aCAY0ETxoTkl5q2AdBNG78UwZjrXXKzHdPnLZIlzEuBroU6z4Wl 8E09PeYp13+2GUqOvoO0p8661EUjQnFykotW/oGpsYFnoJ4eOlbbdkNbjzH+vpNgez1xnjb0miF XAv8WmwPpD1doAXeRrYapDRKte5C42IjduuM2OeesK2ayt/cXU9qbWZZRm9/1HLoUoawCYVFis1 n+R0PNii0Qj5RxUgrowhRxj589xGyqV0Ju9TeuvYgss0seLveG4MQwxOwqiFKYfc0ZdgPkRosJW qy4APB+U8hE2eU0PpZBn299V26h1p/s8MdRPoKr0eFtrQ2TCFB90VIaJH3wJGFtmO3A9fM3fl3O HB1K1BU0yfq2te8o+bVyVWb3PTlM9iEBa5WXjqChO88z1S/5dfYnr79dbgiQNc1rfcFbWfTg1Wt D+4B7UgbHohVt/MfxbubtaqLGKO5ErMfWDs4WxJw== X-Received: by 2002:a17:903:3e25:b0:2b0:6a22:5165 with SMTP id d9443c01a7336-2bd2718bf33mr20560465ad.7.1778663436624; Wed, 13 May 2026 02:10:36 -0700 (PDT) Received: from soyboi ([2402:8780:1073:dc10:22f6:2ac0:a51b:5d77]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e66970sm160480945ad.56.2026.05.13.02.10.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 02:10:36 -0700 (PDT) From: Robertus Diawan Chris To: amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, sumit.garg@kernel.org Cc: linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, skhan@linuxfoundation.org, me@brighamcampbell.com Subject: [PATCH] tee: qcomtee: add missing va_end in early return qcomtee_object_user_init() Date: Wed, 13 May 2026 16:10:31 +0700 Message-ID: <20260513091031.145826-1-robertusdchris@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit qcomtee_object_user_init() is a variadic function and when the function return because there's no dispatch callback in QCOMTEE_OBJECT_TYPE_CB case, there's no va_end to cleanup "ap" object initialized by va_start and that can cause undefined behavior. So make sure to use va_end before returning the error code when there's no dispatch callback. This is reported by Coverity Scan as "Missing varargs init or cleanup". Fixes: d6e290837e50 ("tee: add Qualcomm TEE driver") Signed-off-by: Robertus Diawan Chris --- I don't have the device, so I am not sure how to test this change. Thank you. drivers/tee/qcomtee/core.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/tee/qcomtee/core.c b/drivers/tee/qcomtee/core.c index b1cb50e434f0..901a31e8201f 100644 --- a/drivers/tee/qcomtee/core.c +++ b/drivers/tee/qcomtee/core.c @@ -306,8 +306,10 @@ int qcomtee_object_user_init(struct qcomtee_object *object, break; case QCOMTEE_OBJECT_TYPE_CB: object->ops = ops; - if (!object->ops->dispatch) - return -EINVAL; + if (!object->ops->dispatch) { + ret = -EINVAL; + goto out; + } /* If failed, "no-name". */ object->name = kvasprintf_const(GFP_KERNEL, fmt, ap); @@ -320,6 +322,8 @@ int qcomtee_object_user_init(struct qcomtee_object *object, default: ret = -EINVAL; } + +out: va_end(ap); return ret; base-commit: 5d6919055dec134de3c40167a490f33c74c12581 -- 2.54.0