From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09FC93F4106 for ; Wed, 13 May 2026 13:40:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.156.1 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778679615; cv=none; b=Qq9i3AvDeOekR2tnG4mNZVhSDZZcTwxAzv2qXSmgG0WrQvluCiDGP95nE8IQcGqy7L529/9A166sQsJM9/M/Qe4JsUoBi+uEkddAZbFzqHoRC3uzeKB8nORr2TRAPmn/DHHpoBGE1Jq0ezc/zo8QJ3BdUjvBPYlj71latOpiGxA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778679615; c=relaxed/simple; bh=fJ+zWreaxFLEyBTqRpIpLrpCseubHXYIIi5bLZhxSoQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=HVl5YoBO2AG88fhS1MdcRQTAYB2oYn5bWbvTdyRCWxZKVHtTOMI+wiWQzchkF4ubLQCzUIxmIEo2oTFm4laJ3i3dAD4vGO8QmfRSgVL6mdIeJqhvVDY5a1EF+GqS7bQkmVK4E/eePGkeyiOU+mVDQg10CIE8PQfWZ1YV3BRXCTE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=qlZrd/To; arc=none smtp.client-ip=148.163.156.1 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="qlZrd/To" Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64D2hZ2w2611844; Wed, 13 May 2026 13:39:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=R0U+oW+vBdDKPuQynVkuyPnqnHPqTMO1Dc16ibqpA YY=; b=qlZrd/ToA4DTR2DJoaYiSKYmxO6cEKgwZx3khKgY8Re35WQzs9pF53jDm txzRtTmTbvY8kmmA1XDHSg41Mq6l6umqnQUkEFt5BLUSAzjE0NH5VnqG66cuVw2s GHobZ/6Q6G8VLQr9gUf2H3LWVG/FsKTDXIIVVZOz+pJg2IaMwWYe1q6hnEMJcdfw rpqPddDsIHivsKaFqqxB29+cdWUkd72WuB978vLrSP4VuVTMg/VRkEJyT6QEHvL3 GbNQOR1+Qh0kmQFbOS5JenRNjaKmzYHYll6vtu4C1ym+6msLKvIzbok+DOhrHDvB rkEOdTcRga60NZbIssJdltzMgxDeA== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e3nvdyxt0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 May 2026 13:39:45 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64DDdTGZ018149; Wed, 13 May 2026 13:39:44 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4e3nfgqymt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 May 2026 13:39:44 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64DDdgaY51839360 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 May 2026 13:39:42 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9903D20043; Wed, 13 May 2026 13:39:42 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 098AA20040; Wed, 13 May 2026 13:39:39 +0000 (GMT) Received: from li-7bb28a4c-2dab-11b2-a85c-887b5c60d769.ibm.com.com (unknown [9.39.28.2]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 13 May 2026 13:39:38 +0000 (GMT) From: Shrikanth Hegde To: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org Cc: sshegde@linux.ibm.com, kprateek.nayak@amd.com, juri.lelli@redhat.com, vschneid@redhat.com, dietmar.eggemann@arm.com, tj@kernel.org, rostedt@goodmis.org, mgorman@suse.de, bsegall@google.com, arighi@nvidia.com, pauld@redhat.com Subject: [PATCH v3 0/4] sched: Simplify CONFIG_SCHED_SMT ifdef usage Date: Wed, 13 May 2026 19:09:30 +0530 Message-ID: <20260513133934.380347-1-sshegde@linux.ibm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Authority-Analysis: v=2.4 cv=Y/XIdBeN c=1 sm=1 tr=0 ts=6a047f22 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=U7nrCbtTmkRpXpFmAIza:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Wwc3nvnJSY7snL3-UNIA:9 X-Proofpoint-GUID: Y43AOcHNHBJSFt1o0bZb28QWBsepqAoM X-Proofpoint-ORIG-GUID: QBBxNnCfxB32I3U1guD85ygqRCvZ3XSC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE0MCBTYWx0ZWRfX6hM1Spvyq7TS WAdMFlC9HpqVWpBDmdFPhZHy/p3pNHWTVqHHoXZg9fW9G5uInu0yy6kb3NfTd8vPvrq+ApxCs7t G0qCTFOqULaKMgATg4pnFD0GAJcaKoVb8y661GFSbq3fyey7L9x/1ZSnYNnhkayISX7vvOdt0T1 OZJi3hRUaHp16rxzPP1reBrt0iT8gKzMwZbQ4KpWdUqF/TRBhKI2tBAGk4nVM1tcSElhdjaOz3o R6RbeWB6sA2RhL/koshee2lmIRFXeHlrPpHA1f1FO32uU5L2S4lKWdV57Aihx9lQAC9R2ElD50Y 3/2wwiT/0HKFmK+rAF7VBNLgDjPqZOz3ihxTcimI1xJoTjcYszqfoEnL37TXMa6/Xc810XlofB8 wb0dpdvWInqEXQszbw17IlBpRnpqFH4Gx33SHSKQMXfz7v8JIORNjLyIypCrOt2hAFV7Odp7b0J 924LFJyMEmCIBj7aSFQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 phishscore=0 malwarescore=0 suspectscore=0 bulkscore=0 spamscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130140 Semantics ========= - For CONFIG_SCHED_SMT=y: No functional change. - For CONFIG_SCHED_SMT=n: - cpu_smt_mask(cpu) becomes cpumask_of(cpu), effectively making it per CPU with no siblings. - sched_smt_present remains defined, but never becomes active Since cpumask_weight(cpumask_of(cpu)) == 1 Performance impact ================== - CONFIG_SCHED_SMT=y: No change in generated code. - CONFIG_SCHED_SMT=n: - Small increase in text size (~0.01%) due to removal of compile-time stubs. Most paths remain effectively dead due to static keys. - Fast paths are protected using IS_ENABLED(CONFIG_SCHED_SMT). With that, cpu_smt_mask() can be used unconditionally and reduces CONFIG_SCHED_SMT ifdef usage, improving readability and maintainability. This leaves the remaining use of CONFIG_SCHED_SMT mainly for topology handling bits. Also, remove the explicit use of sched_smt_present. Make use of sched_smt_active. It differs slightly for update_idle_core, which used with unlikely flag earlier. Now it will be likely. Should be ok, since most systems have SMT active today. Since v2[1]: - Changed patch 3 significantly to use sched_smt_active check for fastpath. (K Prateek Nayak) - Collected the tags. Thanks to Phil Auld, Valentin Schneider, Tejun Heo, K Prateek Nayak. - Since patch 3 has changed by quite a bit, i have not applied the tags. Please review it again. Sorry for the inconvenience. - Added patch 4 to unify checking on SMT active using sched_smt_active(). Since v1[2]: - Dropped changes for stop_core_cpuslocked. intel_ifs is the only user and it gets compiled with SCHED_SMT always. Added comments around it why ifdefs are still being kept. - Decided not to add sched_smt_active checks for sched_core_cpu_deactivate and sched_core_cpu_starting, they bail out if weight(smt_mask) == 1. Hence core_lock won't be held for long. It is not fastpath either. - Thanks to Valentin Schneider and Tejun Heo for checking out the series and the feedback. [1]: https://lore.kernel.org/all/20260512152125.308280-1-sshegde@linux.ibm.com/ [2]: https://lore.kernel.org/all/20260506110052.9974-1-sshegde@linux.ibm.com/ Shrikanth Hegde (4): topology: Introduce cpu_smt_mask for CONFIG_SCHED_SMT=n sched: Simplify ifdeffery around cpu_smt_mask sched/fair: Add sched_smt_active check for fastpaths sched: Unify SMT active check via sched_smt_active() include/linux/sched/smt.h | 4 ---- include/linux/topology.h | 15 ++++++++++++- kernel/sched/core.c | 6 ------ kernel/sched/core_sched.c | 2 +- kernel/sched/ext_idle.c | 6 ------ kernel/sched/fair.c | 45 ++++----------------------------------- kernel/sched/sched.h | 8 +------ kernel/sched/topology.c | 2 -- kernel/stop_machine.c | 5 +++++ kernel/workqueue.c | 4 ---- 10 files changed, 25 insertions(+), 72 deletions(-) -- 2.47.3