From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3B0F3019D9 for ; Wed, 13 May 2026 13:40:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778679627; cv=none; b=BOtq5FztYkqcSpD3VxfE8u5TBaB4miromseShC5fHMubdHHJinArBl1oi50GOH8HGs6rFdxaYf5KvD2ek67BKV8yW7Utp69gJEXMItXItG877LA+Eheh4uXZUMvC5X5Y0lhrGtW34LHj5zbi2Ho6wvylccqqDCiIzFR2/YM1NTA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778679627; c=relaxed/simple; bh=a6euAzk2wOdPTLK5q4EK6Xk4VqkwhJF/aXTR7LgHVlw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=p7XOopjnD7H3JPIe+Wg34D2pqWgwnJa8OEU6qBZnJYCIsSPPjfy5kK6lwk/B8z+C7IdJDWh4YA+3Bw6QBe5EAspGqvTskrn9CzIm4i4H0Pp52mu+QQtmRDnh2F5S7NyT40aB7bpi/dsR3Ix7FzKhdjNWzvu/0i1n0RmVui4E1Y8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=DWVqTxQW; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="DWVqTxQW" Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64D317rG2760546; Wed, 13 May 2026 13:40:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=pp1; bh=p1tKrLp3s4YP/A93h xpuf/oSSN4ggm8px/xnD1g7EVs=; b=DWVqTxQWhsIOU5ZoN+ZBOZz4gF1eBzoSN yaC56WSM110KGXaJlUshRdSYCjfOyFJiZWVQDfLYcysclVhtWY0QzKUvWRnBN2Q0 mMQ1SqwSdhtBDZZ9O1OZ39tZwXNXueSY+MrmUTDEaEVLoylyqVBiBlmhugTUrl/A YDOF3SFwtyLZwjYixlOOfFuxI8y9UFCjJEPKF0z+Ws+aqMe9nNo4r+nK2sGjKFzV c6l8j/PecGbIWI2OOts9kC9MpwjMe7oM4FcI4mZC6sSV4RYBkcvY5iRtIkRjXKwf SsQ/EWbtKkPqd05vTwkCIMJ1fRo38kCLcP1P6uXPOGFlX6UhBWvwg== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4e3nv6qkpv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 May 2026 13:40:01 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 64DDdWdY006953; Wed, 13 May 2026 13:40:00 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4e3nfgqyt4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 13 May 2026 13:40:00 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (smtpav04.fra02v.mail.ibm.com [10.20.54.103]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 64DDdwre48824656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 May 2026 13:39:58 GMT Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9373B20043; Wed, 13 May 2026 13:39:58 +0000 (GMT) Received: from smtpav04.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F184820040; Wed, 13 May 2026 13:39:54 +0000 (GMT) Received: from li-7bb28a4c-2dab-11b2-a85c-887b5c60d769.ibm.com.com (unknown [9.39.28.2]) by smtpav04.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 13 May 2026 13:39:54 +0000 (GMT) From: Shrikanth Hegde To: mingo@kernel.org, peterz@infradead.org, vincent.guittot@linaro.org, linux-kernel@vger.kernel.org Cc: sshegde@linux.ibm.com, kprateek.nayak@amd.com, juri.lelli@redhat.com, vschneid@redhat.com, dietmar.eggemann@arm.com, tj@kernel.org, rostedt@goodmis.org, mgorman@suse.de, bsegall@google.com, arighi@nvidia.com, pauld@redhat.com Subject: [PATCH v3 4/4] sched: Unify SMT active check via sched_smt_active() Date: Wed, 13 May 2026 19:09:34 +0530 Message-ID: <20260513133934.380347-5-sshegde@linux.ibm.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260513133934.380347-1-sshegde@linux.ibm.com> References: <20260513133934.380347-1-sshegde@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: T3v0DzPNRS2QLsHmSWdeNcYtI1iJrYV_ X-Proofpoint-GUID: vKd8w53cLGYsF4D4w96H7uwaQ6khPBMK X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE0MCBTYWx0ZWRfX00xPjTWp9IXb 1cilHs/WTZutKWlM60RIoufhggyzWrY29BhPAfaVt74aX2c6DM8PKHlF7LdM4V7MQWOyCnS0j2s PyK9+mdwlJ0GGuRBjgZLxV0sAriZg9Ahy46VmVEnJnEWc3HrqoPnZya5W7CNVXkcBg/zIj0ANid k1oSuaNPvI0Dd3p3yqoB6pJbAB/TE6CuvSvyI9ux8O3sD/IVd0rDgkkpDEvn1cqyiHZ6toghAD/ Nrp8jfkNhSQiOVL8lD5/QjQWmATfUWXbWMedTdoyT4X0+QqiqxfxIYcThMipNcryub++XOQB5yr kza17bt/vkp3XEm376WOn9mVua+EKQsH9Nbd/pkfy4FdSfksYnd3iwLwrhKmIyIvxZ8eBOwfNwT I2LT4QTIRNgGhhTAqCS0Js9ZIizGaRfhJEMoFUn49uSyRXQyzhnxYlOWKR31yl+atr2tPmDA924 pHtQN/pqsMzGiQblW5A== X-Authority-Analysis: v=2.4 cv=P8UKQCAu c=1 sm=1 tr=0 ts=6a047f31 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=NGcC8JguVDcA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=-Ed73FR7LBI_DYr6sKsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_01,2026-05-08_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130140 There is a use of sched_smt_active() and explicit use of sched_smt_present. Remove the explicit usage for better code maintenance and readability. Note that this differs slightly for update_idle_core. It used to call static_branch_unlikely earlier and now it will call static_branch_likely. Signed-off-by: Shrikanth Hegde --- kernel/sched/core_sched.c | 2 +- kernel/sched/fair.c | 2 +- kernel/sched/sched.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/sched/core_sched.c b/kernel/sched/core_sched.c index 73b6b2426911..43e0bde3038e 100644 --- a/kernel/sched/core_sched.c +++ b/kernel/sched/core_sched.c @@ -136,7 +136,7 @@ int sched_core_share_pid(unsigned int cmd, pid_t pid, enum pid_type type, struct pid *grp; int err = 0; - if (!static_branch_likely(&sched_smt_present)) + if (!sched_smt_active()) return -ENODEV; BUILD_BUG_ON(PR_SCHED_CORE_SCOPE_THREAD != PIDTYPE_PID); diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 964014a74cf9..29fbb5287cfc 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -2276,7 +2276,7 @@ numa_type numa_classify(unsigned int imbalance_pct, static inline bool test_idle_cores(int cpu); static inline int numa_idle_core(int idle_core, int cpu) { - if (!static_branch_likely(&sched_smt_present) || + if (!sched_smt_active() || idle_core >= 0 || !test_idle_cores(cpu)) return idle_core; diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index e476623a0c2a..ffe77b2b6296 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -1671,7 +1671,7 @@ extern void __update_idle_core(struct rq *rq); static inline void update_idle_core(struct rq *rq) { - if (static_branch_unlikely(&sched_smt_present)) + if (sched_smt_active()) __update_idle_core(rq); } -- 2.47.3