From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f73.google.com (mail-wr1-f73.google.com [209.85.221.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E10935F16E for ; Wed, 13 May 2026 21:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778709177; cv=none; b=Zgu6XNlquAJrycDjmnFRoI04vJWUNWBKF1751PnzBZuOjnGLwke5ieMHGTCoo5I0weSkw9htKdT/ghhP23WjA3tI5gBmhGuDdtAKtrFkDnjK6k93xVJjIGf2fOESQd5zysjxaWnz5RVI38GTV96Ko7NoC5zfE4McYPmldXoVfIg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778709177; c=relaxed/simple; bh=+OczJGrSk8p/b3s2p7AbRUIvZaBMC0oHxGZgBms07fs=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=S7C4soz/pswrply2+imVjEsY89kh7bAWXa245pMmGEniCqHV1UJL0YpLysUUpnYiRk/3IbtriNgSET9Xu3IU9rkfPtFiE0RJheBV3S/KfzJdirfVUGudQA3w5nfslkAeqpRIIp/d74lX9rSGc7/KGGxlDEshf9rJV6Tt8ZiOYbc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=lvzN8Qfl; arc=none smtp.client-ip=209.85.221.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--smostafa.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="lvzN8Qfl" Received: by mail-wr1-f73.google.com with SMTP id ffacd0b85a97d-449dcfe8005so7001301f8f.3 for ; Wed, 13 May 2026 14:52:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778709175; x=1779313975; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=B4gZFEOmN4BitsxINTjrbRsNtg0gv58NYoTuWrSbwJg=; b=lvzN8Qflf9wn1kYshwNkbvMWICs+XXSMqTQz7IIi4EPaYMXkGrzSRILmCbws7R9Yj8 Li44q2D6BkQpSVJ5NnhA/vVHo8bmSHp1y53W9cJRwB/RNvqdapKOs92IFGWF4ah+c/rD RtM8dLf3zRCqjwrBg5nwfCsbAWYPMWESNT2KNtlYkbTq55/+TkQSiMGVMMA+JJGE1dUB 8mHflkbmS1tuwZiURqqzb5z+1H61fEHxu8HjuDQ5fg06R/aUuQGi65wSLAcplfXUZzQ1 WSMyF/9Cq6DvKSxehiwgimWiBO2v4yijEZCbVEnR4s/p7WHTKorKrXjeI1rAy0MClSdM UezQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778709175; x=1779313975; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=B4gZFEOmN4BitsxINTjrbRsNtg0gv58NYoTuWrSbwJg=; b=Xrjb3zcqBICuzl7p2azPncKm/U3cPKTq29AnjmpY1Vo1RA1TweG8eOJEbwnRqxJ6xi GLfdvDAeITTYPPGPWhwQKwgKH5uFs9KdfSGP4F/dTAh7mDY8uJM6OwJVOpOP75jyFnIv JBKFhBXU6P+FEXwOJ2P7nZCBlQ21IcgOpzxVrFbtCnkH6HlbLqah3TO2aSRsNRfQTXVx Yo0kBLr/VFlfDNVrp0/Qfno45pCLhFK25TuhFm88JkaEil/IiEW2c8YDacgLmLXIoRWR tAxLSbVdxEb8kE7Hr8Hckyd2XX7SQjPcuiV8bIPW/z4Mwj1q7ss31raB94VPEcEmCpae mHLA== X-Forwarded-Encrypted: i=1; AFNElJ+Y9mcm48RBne4kPlz6zFPZiVlbaW1dPS577t3K2U8qaljKctKQNIHBI2FBm7oP8cYx8FzHR8LZAG6HJQ8=@vger.kernel.org X-Gm-Message-State: AOJu0YwrQinGCjJ9MpPMju5Y93TzZV8Ia37yKD/am6vTOsiBhBKvRPiI PzU64KGqneuk7LpvR2KX4mXXMq5YdyiAB47Zs4D2KuRxl++6URpOknBimPunvHyQV8XtJNi8kg+ kUpBZCITEvWw6zg== X-Received: from wroe2.prod.google.com ([2002:adf:ef02:0:b0:43d:6fc6:5521]) (user=smostafa job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6000:2486:b0:44b:e349:e6bc with SMTP id ffacd0b85a97d-45c77b7bacdmr7661958f8f.3.1778709174704; Wed, 13 May 2026 14:52:54 -0700 (PDT) Date: Wed, 13 May 2026 21:52:03 +0000 In-Reply-To: <20260513215203.3852661-1-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260513215203.3852661-1-smostafa@google.com> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260513215203.3852661-4-smostafa@google.com> Subject: [PATCH 3/3] iommu/io-pgtable-arm: Use address conversion consistently From: Mostafa Saleh To: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: robin.murphy@arm.com, will@kernel.org, joro@8bytes.org, jgg@ziepe.ca, Mostafa Saleh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Use consistent address conversions in the driver: - virt_to_phys(): For all virtual to physical address conversion, convert __pa users as we don=E2=80=99t need to rely on it type casting. - phys_to_virt(): For all physical to virtual address conversion, similarly, convert __va users. That changes nothing at all. However, it will be useful when compiling this file for the KVM hypervisor as it can cleanly replace virt_to_phys/phys_to_virt Signed-off-by: Mostafa Saleh --- drivers/iommu/io-pgtable-arm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/io-pgtable-arm.c b/drivers/iommu/io-pgtable-arm.= c index 86b23aa04324..476c0e25631a 100644 --- a/drivers/iommu/io-pgtable-arm.c +++ b/drivers/iommu/io-pgtable-arm.c @@ -143,7 +143,7 @@ #define ARM_MALI_LPAE_MEMATTR_WRITE_ALLOC 0x8DULL =20 /* IOPTE accessors */ -#define iopte_deref(pte,d) __va(iopte_to_paddr(pte, d)) +#define iopte_deref(pte, d) phys_to_virt(iopte_to_paddr(pte, d)) =20 #define iopte_type(pte) \ (((pte) >> ARM_LPAE_PTE_TYPE_SHIFT) & ARM_LPAE_PTE_TYPE_MASK) @@ -429,7 +429,7 @@ static arm_lpae_iopte arm_lpae_install_table(arm_lpae_i= opte *table, arm_lpae_iopte old, new; struct io_pgtable_cfg *cfg =3D &data->iop.cfg; =20 - new =3D paddr_to_iopte(__pa(table), data) | ARM_LPAE_PTE_TYPE_TABLE; + new =3D paddr_to_iopte(virt_to_phys(table), data) | ARM_LPAE_PTE_TYPE_TAB= LE; if (cfg->quirks & IO_PGTABLE_QUIRK_ARM_NS) new |=3D ARM_LPAE_PTE_NSTABLE; =20 --=20 2.54.0.563.g4f69b47b94-goog