From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A120725B09B for ; Wed, 13 May 2026 23:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778715106; cv=none; b=Jg8Ld0TKzB1h2+Jdx/PjdYglo7/V/05zHgR+vLN/A0DOqJrzR6fYv2FA8lwhmqC9dq7zPFTh4Mqa9aedFUcojs0B0rOWwpilJ4ZWshBLKL8m7x8qAmsPLQfVK4iWSCKqFiINu8Z5gX0jh8Nj/UcFi4/QznwwBw8osRRtsVffAsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778715106; c=relaxed/simple; bh=YCLZTZb/JR6JOP0d28fCkv+PqEqRoVYVppH+edza+D0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Sjj85a4U2lMox9fwirJCXEaBqGQcpbs0GrwtaFVVjNe8+TjbLmN4FpK0mbXeADm70VDl3yK2MrHkf0QmzC4zCxAfirMtwHQEZxjOg8u+qe3xEXGdHT+R+9soFpXB7uIdOYyDNF57gxXq5lfIosZHC0p9JgmurfsCzVasuGC/9AE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=leZmF0zg; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="leZmF0zg" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-50e5c7eb565so71276241cf.3 for ; Wed, 13 May 2026 16:31:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778715105; x=1779319905; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iGLCDZv1hdB2MgIaz/XQKoXR1JnQneRt9RRBxPzdNNA=; b=leZmF0zgtmznvDK6rRXw/8jqIJDIrbzB0QH02coDG38Id4FqMNsCFWENJsyYbH8ql5 ucyQGsoPhBdsNiiwZ7Yp1mN9OQH3lOXE2lBKAbCOZUa37qN5r9efOTYhoAscW0Au6lyH xTd3RfFSabKDZvJkkC8x+4L2Q4BX4p91lrC7w8O2+lkOXVGNP1JVtqE3X3DEl9AqGn6u lf7ZQ3PyooS75dehOUI2d+2VoEtlzv0fOaecCmRcXkNxMqGF46OYIDqemXev5xUJxfG0 SnsTHmLgHG8GdsxnmNwo1OHnuUpgeJbSg3y0M30ecZykiDiN7uITvfXvBRlTrvPXsWAB w9Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778715105; x=1779319905; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=iGLCDZv1hdB2MgIaz/XQKoXR1JnQneRt9RRBxPzdNNA=; b=L24kjprrWuVNomTEHJn4IkwdiTB/gkpYAr/K5RV//SJGgilBZPPdJzbaRY5hdgI3Hl ZlD67LZEPUZNSjs3kxlUzutPZHThtTn3N6fccaMTLQRJiegEthxPzzaX+HVz5sbsUr8r rn2JTlgu3xs7v583VOKjx3WigekOGx1rJKNGhM9UGwmmfuMFvrNAJe/joUuk5cYb2qjG xUhX56aH5mxIQKmBIDKNmdKVbWQsmor09AgfWKwUFI4Su5kCfAEzciGhmZwWeJ38svD9 eeRzDNmp+mTulwv9JBtC98oNLrgFGGszxFj4nKfIEUEmiIgTJG+tSEg2uaryMCJ07fAo FrUg== X-Gm-Message-State: AOJu0Yx906oTZJYYfYn4gdvT4s1W5I5pMjqQIC5IA6kGDKOvnfA439Eg 5X9jeFN/lH65NORPpWS+30bAi9uXy3AzoTNakxxaKo0IutccPliE5Nrt X-Gm-Gg: Acq92OFt9ZZTqRMPRNNEHuQtS8D3/1OghBwl4KK12YR02FWWZvzvKlxnOCoDU0obR2D 8ULGAz6WOtX68O88VIviDG5+/JprFWLj+0/wgXPmIbJQqsp9A8p8ZcIh3mniXIbZHwa9KHRNlsz OCu+sQviR/XZ2zFsT/vKaeA+yudo0e5xIDf/5mDjBCn3edEikPwK/e0G2lfSxEsE1ludom/g4Ab suMiG5cdlzOzTSKkwm15E3oRqMc3sRupM9OaP0kbxsLXnGPpwC07PmWkeE+1F7CcLHGKYY6ZNDy X1kYANHJl/JzYJCfegNmMjDzXmj/P9t4UutjXW1pHKQOMlEkexQJ1FIXY9JPTTooS/Pk3WvV0PN 1xJPBT/W2cUijbZezL5E2irFldmGFiqJhGsoor4bjwLyy5uKhCxHfnoQYyaSaTWBMXWvw7Mi43g xsN3zM2/uDOGl8s7HOI8M3T++b6u2WtSjH/Mu8pHXD X-Received: by 2002:a05:622a:1648:b0:50e:6183:beea with SMTP id d75a77b69052e-5162f4c3999mr78168821cf.23.1778715104578; Wed, 13 May 2026 16:31:44 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bd620fbcsm94689185a.42.2026.05.13.16.31.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 16:31:44 -0700 (PDT) From: Yuho Choi To: Thomas Gleixner , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Yuho Choi Subject: [PATCH v1] irqchip/atmel-aic5: Free SMR cache on init failure Date: Wed, 13 May 2026 19:31:39 -0400 Message-ID: <20260513233139.659956-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit sama5d2_aic5_of_init() allocates the SMR cache before calling aic5_of_init(). If that fails, the cache is left allocated even though no IRQ domain was installed and the cache will not be used. Free the cache on the failure path and clear the global pointer. Fixes: a50ac562ef48 ("irqchip/atmel-aic5: Handle suspend to RAM") Signed-off-by: Yuho Choi --- drivers/irqchip/irq-atmel-aic5.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-atmel-aic5.c b/drivers/irqchip/irq-atmel-aic5.c index 1f14b401f71d..58650eb16880 100644 --- a/drivers/irqchip/irq-atmel-aic5.c +++ b/drivers/irqchip/irq-atmel-aic5.c @@ -358,13 +358,22 @@ static int __init sama5d2_aic5_of_init(struct device_node *node, struct device_node *parent) { #ifdef CONFIG_PM + int rc = 0; smr_cache = kcalloc(DIV_ROUND_UP(NR_SAMA5D2_IRQS, 32) * 32, sizeof(*smr_cache), GFP_KERNEL); if (!smr_cache) return -ENOMEM; -#endif + rc = aic5_of_init(node, parent, NR_SAMA5D2_IRQS); + if (rc) { + kfree(smr_cache); + smr_cache = NULL; + } + + return rc; +#else return aic5_of_init(node, parent, NR_SAMA5D2_IRQS); +#endif } IRQCHIP_DECLARE(sama5d2_aic5, "atmel,sama5d2-aic", sama5d2_aic5_of_init); -- 2.43.0