From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2B363CDBC4 for ; Wed, 13 May 2026 23:46:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778716019; cv=none; b=P9KlZFJgvUAqU1nOv6fz+9cF6EBa70omqx9WA7A6nCknkHPo6HWZpmu0mMTgyjGJbAvqHb/pu1h5dZPGiuwHnP7T2PmBc7P4hWwhruwJm5/UIz/w5+eeT99jEWPoGcJdw6okEXDPxNmubre6TN1aqxXd/pvtp9Ri/PVFXS2TZaU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778716019; c=relaxed/simple; bh=nABnyTVpdpjK5O3wtbrmycZjbC6IhActFaxQTKL0PH4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Gy/WeZNwk+j/ifBXr5upa8lxwVwOpjaNq2bNrr+zmiN7lL+lFrjsoyQVj8zNubksbhLVQU+JwTBD8K6PAUXJzbSTQPD/VC3bebCIPac28H21fkd4oc6XjgliL6rLvnHeBYyc7RWNAQwKalI1AW6vFpjBps9SMK8IqKz0V1Jd1BE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=cVjn7pyJ; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="cVjn7pyJ" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-8d65f4073bfso992574085a.3 for ; Wed, 13 May 2026 16:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1778716017; x=1779320817; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fkTU6tjGG+nOcVlZzdhoBVAzDEp9yyRsCuO17s66584=; b=cVjn7pyJuevwdWBS6gPt8TLoDkrW9VAXpoE7Cl1n1yF5qQYP+tjhho9mp/KOcejhUb GVy8+HRmlr3ubV07o+9Tkw5Hs3+GFPmLBsbT4Zm0axwX3xT45WeEE5TxBMXgcJpCfapD 0glamCEwT0CwmffxtXTk3rmHxpq1axM6p48A6HjJm/zYaPAFJUr8nQH5gLEiJHKAy+Ee 5JB7EPB/JvHsbuV7J525JCN7ck5YKEwfiAW4XSHzvoTg1jcA5sNyoqlSx3Y/AjYKp0qC psyTvIntQ7LAIqChx2CNg5D0Q0nGLYxml5PTkqSSxpzgrpXiZ3Aro/3Jhz/fw09x8IM0 NmOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778716017; x=1779320817; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fkTU6tjGG+nOcVlZzdhoBVAzDEp9yyRsCuO17s66584=; b=GuOf0tYh1O/1k9RcVTHzucFhdepPMLBtRKY+6pqC4KHmwSNezSRmei4DyPcCbH4WfG j5uspRaZsGQeXdxyIN7BpzdVmD+cX8w52Fvd7gJJnFCtxjfswn3Nm1m/bFpYUgOeC582 zXXuId16EjmFk8UCEHYef0UW6aqnBquvM6AZSiLcGqcSA9Yojmv2m6wSvKBir9vJngjc AZCt+zmTkJW1QhOHgxB/CUbIpq/B7Ll50EVqeXOgeY01jTNtJrJsDJ8rZJmJmtOWqSC9 h2watVZYCBXUDs8r02JnoDoStkoLw7qGCkaNQgiiZF6/AVfp7E9/vIZNLdz5iG2LGhFh EaWw== X-Forwarded-Encrypted: i=1; AFNElJ92tiFgBrnSrA/0jpTwNoAMDVsN/ZE+22TcMASX3JhJOw33zxwaLOJ6RsgwgbBEnlBPj+1KgMVpYmhqAiQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyBOuRbGZph6H9eio8n0DVwDNgeuteoF9uAZM89AVhn9WFyIJCm f5nULWrhK1kW+QWQx61NzV4X/PvdFVMmQ2CEqOmxsV2ghfw2QqpkwmhZma4c2p0RcF0= X-Gm-Gg: Acq92OEMgaq9WZvJ78i7EyH6SuzhMcVoViBcaC9QMww3k0yYpkiZSbMs3wJSoFwfz8o BKyEF9MdFudgMYqkl1rpREig3OHbUXvMeWAAjAy8dkMcno83+PqzeA1aRpbM0rAlMEtyNbbu8oZ Ok0lWjoVOA2uWmK3x3LtqbR3Tb9iNcMrfksntNcFR8aUYE2naD2OnN/GenJfOyaZtHJYri235TC gzYiwZ7i56wr+me0RHz0xcaxYuGhlQy8NtvRSH28NVUvhyYEk4JhS+ARwsHbPBEM4nwtCvIGkKV hHIkorXYHInOCzOpyHAKModVzK/9gWERvTgFg3CnaqFClL83oUH0G0MNlpuW+jUj5Y4e32/prMS oGpx2drNr8qu/f5mTdg25r9vIRS2+DDPRheeJBLh6kO60R++Uv8fzltOUWDvX96R2Pul9si4MZy 503hveKXePrf6uOc6QQErNEDbS7FaeVRKMIWa39BYTUQn3N1d5Jt/SmaE0P28yoLB6Me3YDNid/ C7FMQ== X-Received: by 2002:a05:620a:4409:b0:910:3078:5cf6 with SMTP id af79cd13be357-910307868dcmr532307185a.44.1778716016939; Wed, 13 May 2026 16:46:56 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id af79cd13be357-910bae27359sm107053985a.17.2026.05.13.16.46.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 16:46:56 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wNJHz-000000048gW-3syt; Wed, 13 May 2026 20:46:55 -0300 Date: Wed, 13 May 2026 20:46:55 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: syzbot+d8f76778263ab65c2b21@syzkaller.appspotmail.com, Edward Adam Davis , akpm@linux-foundation.org, arjan@linux.intel.com, davem@davemloft.net, dsahern@kernel.org, edumazet@google.com, hdanton@sina.com, horms@kernel.org, kuba@kernel.org, kuniyu@google.com, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, pabeni@redhat.com, syzkaller-bugs@googlegroups.com, yanjun.zhu@linux.dev, zyjzyj2000@gmail.com Subject: Re: [PATCH] RDMA/nldev: add mutual exclusion in nldev_dellink() Message-ID: <20260513234655.GW7702@ziepe.ca> References: <177869624862.2335447.16979087766093395765.b4-ty@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <177869624862.2335447.16979087766093395765.b4-ty@kernel.org> On Wed, May 13, 2026 at 02:17:28PM -0400, Leon Romanovsky wrote: > > On Thu, 07 May 2026 20:50:10 +0800, Edward Adam Davis wrote: > > We must serialize calls to nldev_dellink() or risk a crash as syzbot > > reported: > > > > Call Trace: > > udp_tunnel_sock_release+0x6d/0x80 net/ipv4/udp_tunnel_core.c:197 > > rxe_release_udp_tunnel drivers/infiniband/sw/rxe/rxe_net.c:294 [inline] > > rxe_sock_put drivers/infiniband/sw/rxe/rxe_net.c:639 [inline] > > rxe_net_del+0xfb/0x290 drivers/infiniband/sw/rxe/rxe_net.c:660 > > rxe_dellink+0x15/0x20 drivers/infiniband/sw/rxe/rxe.c:254 > > > > [...] > > Applied, thanks! > > [1/1] RDMA/nldev: add mutual exclusion in nldev_dellink() > https://git.kernel.org/rdma/rdma/c/0b28000b64f40d This seems like a rxe bug, I would have expected the lock to be inside rxe to protect its racy implementation of rxe_net_del(), which looks like it is possibly also triggered by NETDEV_UNREGISTER... ie it should not change nldev_dellink(). Jason