From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3EE422D0C7E; Wed, 13 May 2026 16:42:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778690578; cv=none; b=irShsHXRD0Pp/1hNgFsbTeCQZ14gLmFFV3j/Sdu0GtOewVIh/lJFQYdHln7MZE09cX7CxUZ2349X4vhlOFc4wR5WiMMVPS3+KdocXhPjsKz0IPc8nplMeAoSWqx3hOxSzBEOkj89NYVPmwPyeFPUVqjFO/z8cHbfKRumosznWGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778690578; c=relaxed/simple; bh=RPHz7xjwhoH/yCygCjSkiz9BuYlvVnzQ5uMXOuMStIg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=dCj6VQcOuAZvCBtyoZmD3RgNXaOpQTEwkl7tIE28TvTTVtE4LAhZhGHNhscpmFmSGyu11xrbcq0eZfn9ekJ1qneKKk5Oa5iazwWpYTpG3n0oTYepxcuVYxnt3pKD5Xb8UAUFouYu+PTJNYHTPBNX4EH80FeOJ+RoVYOO8M1qnto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=JB46mnzX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="JB46mnzX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8AD1FC19425; Wed, 13 May 2026 16:42:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1778690577; bh=RPHz7xjwhoH/yCygCjSkiz9BuYlvVnzQ5uMXOuMStIg=; h=From:To:Cc:Subject:Date:From; b=JB46mnzXTN2Juzu/+nF7oWgZLon/Z7dPWMwkDD1Q6c+BvbUQXo/Dem8ZK9T9X68Ps 8ZDkTG5IPyAPK3nIkY1FYrBr+PMgjrqZZEyb5Uq8UoDqtMo0eM3B91GLm/0kM52Ddn +5hYeS4lCgCFHF8FIMilaJiyfOxjb0LSIOuyIuu0= From: Greg Kroah-Hartman To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Sam Daly , Sunil Goutham , Linu Cherian , Geetha sowjanya , hariprasad , Subbaraya Sundeep , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , stable , Greg Kroah-Hartman Subject: [PATCH net] octeontx2-af: CGX: add bounds check to cgx_speed_mbps index Date: Wed, 13 May 2026 18:42:53 +0200 Message-ID: <2026051352-refined-demise-e88d@gregkh> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Developer-Signature: v=1; a=openpgp-sha256; l=2174; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=vx3qb3eQCPM1LLdy+zLmm/Im6y1WcGvGbCSoxXuoOt0=; b=owGbwMvMwCRo6H6F97bub03G02pJDFksq3j+1Bi98fmy97hvmdHK29uLrhdyObiyT0w+nnJqX 4a//VObjlgWBkEmBlkxRZYv23iO7q84pOhlaHsaZg4rE8gQBi5OAZhIpzfDgvVzGHfmh+yTFz0W 7Pnq2sSuDM2t8xnmF7I+fpl+4omuglHy+30Vopn7l2+UAwA= X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit From: Sam Daly cgx_speed_mbps has 13 elements but RESP_LINKSTAT_SPEED can yield values 0-15. If it returns a value >= 13, this causes an out-of-bounds array access. Add a bounds check and default to speed 0 if the index is out of range. Fixes: 61071a871ea6 ("octeontx2-af: Forward CGX link notifications to PFs") Cc: Sunil Goutham Cc: Linu Cherian Cc: Geetha sowjanya Cc: hariprasad Cc: Subbaraya Sundeep Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Assisted-by: gkh_clanker_2000 Cc: stable Signed-off-by: Sam Daly Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/marvell/octeontx2/af/cgx.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c index 4f33a816bc7a..2e94d5105016 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/cgx.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/cgx.c @@ -1294,13 +1294,18 @@ static inline void link_status_user_format(u64 lstat, struct cgx_link_user_info *linfo, struct cgx *cgx, u8 lmac_id) { + unsigned int speed; + linfo->link_up = FIELD_GET(RESP_LINKSTAT_UP, lstat); linfo->full_duplex = FIELD_GET(RESP_LINKSTAT_FDUPLEX, lstat); - linfo->speed = cgx_speed_mbps[FIELD_GET(RESP_LINKSTAT_SPEED, lstat)]; linfo->an = FIELD_GET(RESP_LINKSTAT_AN, lstat); linfo->fec = FIELD_GET(RESP_LINKSTAT_FEC, lstat); linfo->lmac_type_id = FIELD_GET(RESP_LINKSTAT_LMAC_TYPE, lstat); + speed = FIELD_GET(RESP_LINKSTAT_SPEED, lstat); + linfo->speed = speed < ARRAY_SIZE(cgx_speed_mbps) ? + cgx_speed_mbps[speed] : 0; + if (linfo->lmac_type_id >= LMAC_MODE_MAX) { dev_err(&cgx->pdev->dev, "Unknown lmac_type_id %d reported by firmware on cgx port%d:%d", linfo->lmac_type_id, cgx->cgx_id, lmac_id); -- 2.54.0