From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BE96285068 for ; Thu, 14 May 2026 00:53:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778720028; cv=none; b=YUyFLm4JvH/E15HdMntRt8Kwfct7j//nlSuYpwCIuGbgfOmdm80oxjTzHcRh43Vk6LgOJVk3SvPaQczOiLU8v51cdif52RsJ3PyabvDf9Y+x+qXQyzdgVKAUbbMDomhyexm83iLsfwtRTpUyHx9KMrLFI2fBBGdhEycPao2su8U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778720028; c=relaxed/simple; bh=hyUigFXPu7+lHZADwOe0zFHa/0gaPvaEjifMk3qklnw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jwm9InFjheVosZINj4XTJkB6Mp1JZnpit1kGT3ol1JWRHN0tb7UrWKU35WeinfOgdeTL7XcdbyQAqbtG+CZbeRb6Np4Fmq1euTgC6wgwUv9iJYJKCNSYN0nHlN+CJTIvZEjJCdOHH+Hc6gVCbROdkPWvSla8KKlsB8WLNFyP7ys= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=btvdIwZi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="btvdIwZi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8F3DC19425; Thu, 14 May 2026 00:53:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778720028; bh=hyUigFXPu7+lHZADwOe0zFHa/0gaPvaEjifMk3qklnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=btvdIwZiCdzIe6xjpNjJdzX4keWA+Lks75nNT1GqLzF+8K5R/vQanOVK+tZQiEiV+ f1xAMfZCBEN4jXgatP9+AGPUe7Otlcxk8qSap9MVFUUsR+vS1D+v5zfNDJuUnjgte5 l0U4Mr9mjhCj8VX13fPtoitz69U3ViqQchxBnk4adK+FutkSLQTyaOJOYvinWwPxLN pp9b27OqkOGWA7kmxDPWPfQoFcgUGG+jZRcjlgbLViMBCwhTx6N2Y/fBI02kLa0d5B kE40P9ltV9bHxySEIM3iNbi6vzYIveG4VbgYMwScQNGPX1hRaUywPPhJ34zDhrLLZZ oTj4k6evAJeYA== From: SeongJae Park To: Ye Liu Cc: SeongJae Park , Andrew Morton , Ye Liu , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] tools/mm/page-types: Fix ternary operator precedence in sigbus handler Date: Wed, 13 May 2026 17:53:14 -0700 Message-ID: <20260514005314.148447-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260513022120.58033-3-ye.liu@linux.dev> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 13 May 2026 10:21:17 +0800 Ye Liu wrote: > From: Ye Liu > > The ternary operator (?:) has lower precedence than addition (+), so > the expression `off + sigbus_addr ? sigbus_addr - ptr : 0` was parsed > as `(off + sigbus_addr) ? (sigbus_addr - ptr) : 0` rather than the > intended `off + (sigbus_addr ? sigbus_addr - ptr : 0)`. Add explicit > parentheses to ensure the correct evaluation order. > > Signed-off-by: Ye Liu Acked-by: SeongJae Park Thanks, SJ [...]