From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f195.google.com (mail-dy1-f195.google.com [74.125.82.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A8D43C0604 for ; Thu, 14 May 2026 06:03:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738633; cv=none; b=mCY2O8irLW8afxtTkSxZxszTIy+u3PZMK1LMFOQx10qO48MuRIm4eSgOFKZqRAJdwgRS4KGwzm1aFQuUyNqFoJeUufj0o6Vz6yLEtvLxreTn0clMG08f8YnrfMziZM/RnTelwhMkhu+ZJB5CRujaD2TOQ0cZLWHs2kPIqoR2Bk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738633; c=relaxed/simple; bh=Axmd5IPh2I0ePfoBcxce130e2QCyMyW6fCwo7DYmTgQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=l99YQqqzLmlfAZjCPBo1E1sB4LAZpQ3s15oDDKKxUMyY9iA1lJwDYf7RR6ydjFAJjM9BqlUYvr2fyOYpplZ3uhUoTmLIFIMJYoahcXb8QkCq1fM0y4jC2/7aEyU/yI9BviS/FCcgJFCJ0BeS+fbEQZlFeMdEoVsuZmHBw6ZknJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pIaiW/sp; arc=none smtp.client-ip=74.125.82.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pIaiW/sp" Received: by mail-dy1-f195.google.com with SMTP id 5a478bee46e88-30246cfd41aso2519993eec.1 for ; Wed, 13 May 2026 23:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738631; x=1779343431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=pIaiW/spPVNRtGwiHIRCsIIfj4vz9BsEg+Rl1Y7g/7sKTQSwGs7XJu3SRHhsnD2tv5 SYKjWpm+sX1sIixcPuBtusG5V8CtNFhTs+kx0QrNgM30VrNu/0ZViVLvGcxgqTGaeu2w vO0CoF7L2t72OifNrRgITEq9DHs0r8QDxFIJi3HMUP/pOrSjkvrxSeBJh/TdWFwpQ0t1 YZiWQxcspGYbjsdAq4fNlcPRJDlVCjKg0SzuNS8Uo7t2qKNwJd9sVnJfNNVmNzHbp0I2 c6V9cvD4yE38q/RhW7ZEHpa1k3wX3Z/oaHlyS+EJUVECHJtqsTj+R7+61uUaYCpRnMfe FOXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738631; x=1779343431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=HPcQNwSHW/C0fNW5K3c0R76usr3b/YE3GeT+Fa6koxYURQTPebIXgdngOrIWnBflyH GvlD3iztlYZBjqERNfBv1ZTdWglkBnlHzP5LCnx5x1AlBBfX2nOyJ/HWEJnwRJgoYbMf GY1ioq2+yRf5IeOnWsVSF9/EhhlC5bXdFoY+1UEWzkXuumYrW1Vr670UC5Zl7abt+MZg sfbPYe0LXEvBUc21pMmMNpoN2ZuKpVtqlqL/D/6bkWSJPuRcLhcd7igaSFwrmCaqohs+ 4RoZU9u6nbp2xGIVFT0mFN38WyX94h9ibJRKTcVKcRm90Gl6e/HHgAhPg72XJ4TiUbjT FDow== X-Forwarded-Encrypted: i=1; AFNElJ+kzsboeMbBi8Tf35tBzxl441tQngoL5GBSoOqofvioXMP554oQ2nGrAxof0nwPnRljVDOacL+Pb0pU6js=@vger.kernel.org X-Gm-Message-State: AOJu0YygE/ssJStBTBlYKsZE2eZQg+5PoTq2jPWJu05Br6NP/DDoNkYm BOPnPEKG/k2NYbDCQ5oRxl2sjD0xNKkTG/FsZzhKWkQGWjBpPdM1VJPj X-Gm-Gg: Acq92OHuXR0l095DoMU1Yhnj5PqIT+CuU6YUpIol+RD7tLGl4E7xcG3kCcPW4RQ0Cp2 8JCqwkbmLsALdvKBi9x2KmKD5mboe6kw3QMJ65xHm1MZaFX/1sVzHwJIdydVlUp4xyK6F7XZv3g fu+S58X4Ajn+H1n5SN7H/IeXeHAOP9gk3QJsJVCP/YaYTqt3QJUabg4Q2FluGwGrgoEBlaYpOKx la2gsfXcS4uVb6to5nC456FIYYTFhrwyQcEfRbNiha7jzNsav5WKl4qxNygGkJn6EdPXrbYnI+l hm3X44i2uyQZbgEsnfK68aCu0Gl7v8a0C4ZfqikYCLlx5CCkcon2p1+A0kdH3X3WURAWwunKIyx 5TRjXMOdAlk4/9G+K2I915Xpkwxi6xxRliCVUbgo4N5+Jz5fK5bw4AJo6oxR7EYWkTFMSHflE86 xQ8hSN3TFVvfXHA4RSG6otHESUmAR1Og8FPTtcAzlMDQlaZZ1NggQ/vtQ= X-Received: by 2002:a05:7300:5709:b0:2ce:f3d7:221 with SMTP id 5a478bee46e88-3015593e4e3mr3965161eec.17.1778738631263; Wed, 13 May 2026 23:03:51 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:49 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 1/5] staging: rtl8723bs: simplify rtw_xmit_classifier control flow Date: Thu, 14 May 2026 06:03:19 +0000 Message-Id: <20260514060323.24895-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify rtw_xmit_classifier() by removing the exit label and using direct returns for error handling. No functional change. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 458e471535ad..72e5dddfee5d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1874,16 +1874,13 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) struct tx_servq *ptxservq; struct pkt_attrib *pattrib = &pxmitframe->attrib; struct hw_xmit *phwxmits = padapter->xmitpriv.hwxmits; - signed int res = _SUCCESS; psta = rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta != psta) return _FAIL; - if (!psta) { - res = _FAIL; - goto exit; - } + if (!psta) + return _FAIL; if (!(psta->state & _FW_LINKED)) return _FAIL; @@ -1897,9 +1894,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) ptxservq->qcnt++; phwxmits[ac_index].accnt++; -exit: - - return res; + return _SUCCESS; } void rtw_free_hwxmits(struct adapter *padapter) -- 2.34.1