From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 363773C4B71 for ; Thu, 14 May 2026 06:03:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738639; cv=none; b=OCO1SUyQPm/XJXWsLyRKYcWA0jjXCzjpAmZYl2qDCIWQ7HHl4q6XgMbygtDKvYNo7SYupO0h+rwISesCpQ/qdJ8Zlg+VA6WU8LlkP3icxHnVc10QwhrfpVAOTf5Wf8Mze1R17xfv/bgYtwpwuWo3AVlQGdDQjD5udW85QqFNmX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778738639; c=relaxed/simple; bh=11dcICdL6yAMWZIt05foSVoZ8djH8Ghv+x8fPZ+bFrQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EWk4jYmDnzXLmuOebnRW/0bGNbv7V66TtbMKRPX6J/N2EmvXU36Btw9IMlrhx/N6ng3Xa/3jdgmclvqSwqW7/139+8vY8+LDzRXQflulptK6Em1XmfsJ26SgchfTpu5smwT7QbFjF5wPNxSuAkaIybln639k5CLG4xhPLu7XxC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eMjDrTR4; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eMjDrTR4" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-13317450f83so858712c88.0 for ; Wed, 13 May 2026 23:03:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778738637; x=1779343437; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Wt6IobLS9ikgtJxLPxmko8DdVcDAzzBqW2zVT+4q8FI=; b=eMjDrTR46QGfbuEqzTCLv+76GgKMqgg8jiyfiL46kIraCLBRnVMXvfVyWXsMtwztcj vpX1jWvyREpHWhKgGX23RjZtHTsMy8VfUMdr64tl1an/zjgwJYvIQFPzfxhv+KoKMzZW Ht4hPpOycmFT/YL0zd1L1BLvX+KgPQqK7XhlHStX8Do4x65o7Oykf3nOQN0DDqUVPvP+ szBQd07VjppwoCM5FOsU7+gNoKJPQ5Y/71flQ8rZX+YEK35JDBiCqQ40R3DMICnVM0+w wHnrJxRTb8Q0jYQfeYFQwTyi44tFRkAr3T7HMjjcP0UbiMFvT4+VqW3TQZfvRxWykBXE 7h1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778738637; x=1779343437; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Wt6IobLS9ikgtJxLPxmko8DdVcDAzzBqW2zVT+4q8FI=; b=GsM31XkExuN/84c/Zb2OuGgTqH1sl7g23+ARFeU/eXxdyoaY4oVZ5i3NkQCTLHp1Fl IGirOMICp9SY1iavEJIG3yTp4Z9kaSu6LhWeQF1t0Sh1xYrVGV8yVUZEMOZeVberMILJ cpdXop371f7rJgPbyeTTPWJz5v4TeHcgsqt8XHzRpnv/R/1wEpcpdGp99QWwE52LGagt U3aA0FpAFuDLWFu92onC1yX1/2rDkUl8un2S+8q6MNOmv7PVAFMZMhFXd64BUdBXpzzO MnnvoYM9lfpO0AXIEiTgcEJ6JDey2QsWOjPU42ptAFW3HyYtpXB+OOprN2uZ4IjfoIfx RkPA== X-Forwarded-Encrypted: i=1; AFNElJ9SpkEQb6wqutelZhkf6Q+0tyGhPTlFBSrF8nALi8B3+Ze1zcgyMDPqoEF8xxnuhCehRQFaMM2ASG27gvc=@vger.kernel.org X-Gm-Message-State: AOJu0YyHBNA61yZLQXQDBwY1oYIOfmDwIRu4QhekOGhtndQ01TFU2TxR wfY6+2KkP2aE6T7cTZpyZ1pfH+aXUCQc6facRDFn8MPLXZHeFy6CyRJ6 X-Gm-Gg: Acq92OHBZUyUOy1s4DxQwlcp+THWhsfEm8V+tq7YwTIfa0P9K/merEasz79JEzFqOn9 V9ierAZxHetYfOYkzt/rrxEmxwxQBrjGnpoM32rujZrq4+dWC2S0gxEc6eSnXo5vl6oRczrVTze yNeTsu3da9ZT8beqZo1N+vRRMTa+2lKBoxWQspDqWc06i3tOPoLOJrIfnGVq1DUSO/LqvuEFWCC GvPJ2S7N0uX7pm5YfbjGlkqFNmOYumnGgf7vvOB48YG2lo5xuAlfmWmhUzai3y6WHTClyvuHGWj TkWytnMayO8Hl1B8fv9C4oRsZBSWCUj4N7n+IfeIhcb6HtHwQ+b/ZFLs7oRf4lGVKNNB1JnXO2U XtpWE3dyyfmUPaZ+FhxqhJYPX7wnI0NUjTFRT5Acq2H/aDVGlJQCOS6oT+U3ok5/JxFbn+5yLo5 jHnK6diZChdsy2tp07+jkRerFhYRKJpeU27ndP8SZHBlqqrW6zOC0G2516DgHSDUN7TA== X-Received: by 2002:a05:7300:a986:b0:2c1:6676:5ebd with SMTP id 5a478bee46e88-3011758698cmr3924036eec.10.1778738637099; Wed, 13 May 2026 23:03:57 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30296dcb6adsm2034772eec.15.2026.05.13.23.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 May 2026 23:03:56 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH 5/5] staging: rtl8723bs: propagate errno through hal xmit path Date: Thu, 14 May 2026 06:03:23 +0000 Message-Id: <20260514060323.24895-6-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514060323.24895-1-dennylin0707@gmail.com> References: <20260514060323.24895-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Propagate errno values from rtl8723bs_hal_xmitframe_enqueue() through rtw_hal_xmitframe_enqueue() by returning the error code directly. Also update rtw_hal_xmit() to explicitly map the boolean return value of rtl8723bs_hal_xmit() to _SUCCESS/_FAIL, clarifying the return semantics at the HAL boundary. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/hal/hal_intf.c | 7 +++++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- drivers/staging/rtl8723bs/include/hal_intf.h | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c index 03f23b75d532..77fa6e67530a 100644 --- a/drivers/staging/rtl8723bs/hal/hal_intf.c +++ b/drivers/staging/rtl8723bs/hal/hal_intf.c @@ -99,14 +99,17 @@ u8 rtw_hal_check_ips_status(struct adapter *padapter) return CheckIPSStatus(padapter); } -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) +int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) { return rtl8723bs_hal_xmitframe_enqueue(padapter, pxmitframe); } s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe) { - return rtl8723bs_hal_xmit(padapter, pxmitframe); + if (rtl8723bs_hal_xmit(padapter, pxmitframe)) + return _FAIL; + + return _SUCCESS; } /* diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index ff82b6efefc7..ea7c9f4ac0f4 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c @@ -519,7 +519,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( complete(&pxmitpriv->SdioXmitStart); } - return err ? _FAIL : _SUCCESS; + return err; } diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h index 9b000681ff80..ee8ad26325b5 100644 --- a/drivers/staging/rtl8723bs/include/hal_intf.h +++ b/drivers/staging/rtl8723bs/include/hal_intf.h @@ -195,7 +195,7 @@ void rtw_hal_set_odm_var(struct adapter *padapter, enum hal_odm_variable eVariab u8 rtw_hal_check_ips_status(struct adapter *padapter); -s32 rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe); +int rtw_hal_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtw_hal_xmit(struct adapter *padapter, struct xmit_frame *pxmitframe); s32 rtw_hal_mgnt_xmit(struct adapter *padapter, struct xmit_frame *pmgntframe); -- 2.34.1