From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E507338C2B0 for ; Thu, 14 May 2026 10:07:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753246; cv=none; b=iu1hy0WSq/fZqYJn8Dkp72CfGO3V5IoCZxrQ029vYWNudHhihovxqGd8BD0p61jzb+YZfpI3hpM5sOWGVUibgj4IO4GJiCMYO3OiYNhrB3ImndL/RPtM82B38ktR+Vnk1YfIfC/ljZPH/ViQj7gSQuOYg3yvYhLZdppDiSXxMK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753246; c=relaxed/simple; bh=Axmd5IPh2I0ePfoBcxce130e2QCyMyW6fCwo7DYmTgQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=D6lfWbFaKW309Sc0mGCzErkrbfBv1nJ8r90BL9Fg6AcB5PI/WejWSUCLgBLeaN/xSbcNYyYvbn0vmHYYSDfnyuqu5i8FzGrg0Lu0Qqi0JE5jrg2MrRzwXkHvSxhoeiU9eEoOqVqVbLqGmU9DaMkPtNdgEdnO/wDpCeKLLS9wE4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AH+kc1Br; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AH+kc1Br" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-12c1a170a50so10862484c88.0 for ; Thu, 14 May 2026 03:07:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753244; x=1779358044; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=AH+kc1Br6LiJqJSsaq044ZInB748n0z2G1afzEWvYIhXG2iCBJq9GU84wjC/wLHMKr FzeoE8tSJ9zeZsfQh497GKfR4YJcJvigH1XxxhOuw4vyskcXigkL7wgG2UfO+uViGbz7 QDiSf6WvGyVyYKnjWhmDS/fMZpq5q/oWTjdwwfm2LGY5Jfhk8xZPlyUJhQ1SF6AoBCFy wrTDE98kuQHEuF5k3KOHKmzXXn9ne1HpHc5LkDOVvxW9yHiaTNnWXevScrC5y+5MzpWS Kyo1D4GtXxS9hthRmkYSiheuheTm0YuphYJCLj0OqXOiTuJe8ZDdSk9QTsGhMYBvL2/6 CoXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753244; x=1779358044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lCk5lbI7sH2Lz326mmiKMLpYmZaGzeWhG5OnFEOU7xw=; b=fzCYeMiYnZ5uziDYNwv55fHMfyT0tQvu5yem9S95ZYQkgQWuXtyT/X4/k+b7TH10V2 9Evgu1xx7aTg+0+/UDp11MDx3QkPNm8DMDBtDEr7Cmd6v24estYdHlSKyusZmsnqBReL 4A+ioQA0kiLWp6I5lUmTTJms8gzquwNS3gG2tMyMiiL2wj33fpC9A9z7Yph8aJGgDuah cQ7QOdgHOt14a8z3AIp/8qf83/wbJkeiJwRBTcp8emvXX8jo8E5HmL/U06kpV34651BC gXVvacTO5aQHC3JrfFkzy7I8TY2ywBe7tkrUHDAalV8weefOMeQAAuaxUk6OfbvAm+SF 6MNw== X-Forwarded-Encrypted: i=1; AFNElJ80q4Bf0FY7qRjU04aT7RXGzSd8K7/A6kasUALu8n9+lyYocGZnjQQGo4oZ5TBDrcjoubYzIQOaO745rPU=@vger.kernel.org X-Gm-Message-State: AOJu0YyNQVnAKZVJY5N90yIDS4ddQgM6jeiWqMCiwQQTHtOUKTWhjuh2 50nGmyqLQyrRcIuBJeI6H1tZjppi+xLtFADYHHpaKybXlNrSUUGwP/GdZZxAbsAg22g= X-Gm-Gg: Acq92OGU9c8/df/BNHm8ZoF6RnBM3xv/WOBG4kXSQZQ9X+iXpPviUpmuQECws45oZLf YseWV0BjMQDUMuvyBTxk47OmCPkfbCW0aBlwhIVYFQVuxW2CuDYX0aINxNgaV9HCNWylGkMV3tS QiXVM6rTquSbDFG49AM+y0Vy04YsICukHmaSkc6JM6HcgoBAQK0xJOiK/plvz+zU77vh6H7Ud82 C2ZaxPQV2/c1VNlLRzWGPyoXdP5bwE6BC150CZu+pPUfQ4o4txZ2cnXqW167ULndx1WQrNhLiih 57VUP9ICgYuvQ/O++19ITn79c3rSX673KDozycSdR7rgK16+9qAEtB/hjZeakcGbdC3EMtaucn0 qOYy9UY8Drjk19vcMC1biym/HdLxzoPdG57N8GQg91MOtTE/dj7q9clEUK6oscMtqjivHnWtKSX M1GOBvwiTlsYxC3JvM5K8GxNZYSlW2Nbvs7PvgenxPEosrAKItiSPBWkA= X-Received: by 2002:a05:7022:2399:b0:134:83c2:26b3 with SMTP id a92af1059eb24-1349a14eed9mr4253148c88.0.1778753243876; Thu, 14 May 2026 03:07:23 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:23 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 1/5] staging: rtl8723bs: simplify rtw_xmit_classifier control flow Date: Thu, 14 May 2026 10:07:04 +0000 Message-Id: <20260514100708.25031-2-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Simplify rtw_xmit_classifier() by removing the exit label and using direct returns for error handling. No functional change. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 458e471535ad..72e5dddfee5d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1874,16 +1874,13 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) struct tx_servq *ptxservq; struct pkt_attrib *pattrib = &pxmitframe->attrib; struct hw_xmit *phwxmits = padapter->xmitpriv.hwxmits; - signed int res = _SUCCESS; psta = rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta != psta) return _FAIL; - if (!psta) { - res = _FAIL; - goto exit; - } + if (!psta) + return _FAIL; if (!(psta->state & _FW_LINKED)) return _FAIL; @@ -1897,9 +1894,7 @@ s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) ptxservq->qcnt++; phwxmits[ac_index].accnt++; -exit: - - return res; + return _SUCCESS; } void rtw_free_hwxmits(struct adapter *padapter) -- 2.34.1