From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B71A838D686 for ; Thu, 14 May 2026 10:07:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753251; cv=none; b=gHebG/a8RF2T+Up0SkgMlrJbD4PjOFmMtHE1JZhas3axVqoY9Jjuml+NNuZ9h2f7VLN4pE8sVH43qpz3whv1YBIn/wRcgK+Pu2hiz4gXEKp3hta6E6YPBUzHosRbkLdspIySOTNF7C4K4cZ60JajKqqjtXCUOl4stgqvHjOBMr0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753251; c=relaxed/simple; bh=nrczOfGVC80s+tKVDd3e9ohV6aT19hUDJHpFQ9xSAjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Mj0R51578ya+kZjEqn1xwWC70wDCSm24ALy+gfqncSANO+aMZNT953wlbR7w8XE/wjQe6DzQkPdsjEmn3WK6agqNaCsEzYuZ3NtblpVfg0z/mqFaTnOrn3Oddyy/cX3wX7xR0n5gd57J0qN495UdXiHvjWsN+9xDD+idLUnUj3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ihtr31Cc; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ihtr31Cc" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-13317450f83so533123c88.0 for ; Thu, 14 May 2026 03:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753245; x=1779358045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YEDmPs3IEzkMNu9wS4D7y4et1HievtNnY5UColUpsPw=; b=Ihtr31CcRLFTIccWza68sTVblwevcAEHNeJDzCasbCnfeXy8vbC0m98LV1xNWO0HDZ 7aUR0FmteI5m/a3fyN0LYxO/kOyLJ8XsIoJEJTam/ZU5TDCRpsHiubPVHcBJlxJZzddY Jyowp9MHqKpDHChUuVX6vB9YnJ8H+eWTmRZlxnxgSNLarhvWK7nD1J/+da4euVkYwvPZ aGmrUlbFGFquSGhPFRFY9d9ruHfIowlOi1uL3sSDJrZUFHU54/MeI0oWJxCNI5exW3Ff 4XXdOI7m52I3Ixs0S0K3eQmhCGHm61TkIGJJKjy3fqQWZaAnIC5dC7yXBCpYpczOmJzI FgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753245; x=1779358045; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YEDmPs3IEzkMNu9wS4D7y4et1HievtNnY5UColUpsPw=; b=rjTydJuzk1RkR26deBfOS++eL0Qcy9YDuG4n+k2FcdIas+U3fhxSRDMZYGwkaWGIiJ iF7o5zBfxcGGhfHeDZl9qNm+FyFm/eJFCdJC6Z1b+kzmSPMRSia1Az62I4ttQ7jCnhJp Ts8PCyGLXLQGjCDNy1MEXuq+ZighnIj9YzDKlO/d5WL55al9nNA5Wo3uvBy0YXf6F32e Mm0Jsp87goiappBjvIZnFxF/XqVB3z3vFJMiQLAMAsr0lWFDyS1MneASxY3ILJX1pmHF NscnCrXlhYJ5vssisL4yY353oc6UVI2GZuDgZLKUX8cTrg/eVAOo4vn7Iw2w4gdmf1R3 c6+w== X-Forwarded-Encrypted: i=1; AFNElJ/XP0MNaLxdo++mNKd5Vz791fzYxs3NBCvKBdt+hHsM1z9n9kAFQIV1OoS5CY5gWdG1882X/70mMfhOrdw=@vger.kernel.org X-Gm-Message-State: AOJu0YxSseKYsGI7ARBp8LRkqWmZwZmNuyBZytYAgPlSZ41ZgZhfY5jG OH0V6bEx3HLdrGHSo8ijEqkwos7cq/byTqJqNG38M6M2igpeL34yMTts X-Gm-Gg: Acq92OEFUqIzofPY9BTkfjyHoSluXLG6XzJgvcQe3hp287p3iiZO8r1AZaHLQx3tssx IbdAUhgNq+XCsED7O2/r1CREvGum0qVvUxizlSxLvcuDfx+XhyOxvYdKBe8z8brUhdxqgUfnXAH OT7jG1YDr1W3wHUWpWh+dH0HxLTHgURvEYNFIgxKrvRDEUZsspkNNhwUG0HQshyBtfYNDQfOoBn yZPvu+Su33sEq6bRFWuD8XmXh7jXnuGgeYVQfIZD57bn2qJZRVjkPus+3rPUJUe9j/fyXOuPgcj kKaDIbslHYOtXKbj4O8QUqgZJGJUEo514Kr5nKbJ5G0t/JN3AQZconiKJEep53T9i3RZ/DxZ04t FDTVo3pAub9scECJU63jTAaHcw/Cg0zt0qjYc44t8lT3+YZxx+iYng3YUQNC3OYCE+xMxLIVInZ MOs8DKODudmZHR+Yl0Fle1Hebdx2/kJi35FDE+SStPUNPxtKBraxu/uBCIJXBlXJyYTA== X-Received: by 2002:a05:7022:10b:b0:12b:f881:d8fb with SMTP id a92af1059eb24-1342ee3a2aemr4711893c88.3.1778753244970; Thu, 14 May 2026 03:07:24 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:24 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 2/5] staging: rtl8723bs: make rtw_xmit_classifier static Date: Thu, 14 May 2026 10:07:05 +0000 Message-Id: <20260514100708.25031-3-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The rtw_xmit_classifier() function is only used within rtw_xmit.c. Move it above its caller and make it static to limit its scope. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 68 ++++++++++---------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 - 2 files changed, 34 insertions(+), 35 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 72e5dddfee5d..b3953bdedb04 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1821,6 +1821,40 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram spin_unlock_bh(&pframequeue->lock); } +/* + * Will enqueue pxmitframe to the proper queue, + * and indicate it to xx_pending list..... + */ +static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) +{ + u8 ac_index; + struct sta_info *psta; + struct tx_servq *ptxservq; + struct pkt_attrib *pattrib = &pxmitframe->attrib; + struct hw_xmit *phwxmits = padapter->xmitpriv.hwxmits; + + psta = rtw_get_stainfo(&padapter->stapriv, pattrib->ra); + if (pattrib->psta != psta) + return _FAIL; + + if (!psta) + return _FAIL; + + if (!(psta->state & _FW_LINKED)) + return _FAIL; + + ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *)(&ac_index)); + + if (list_empty(&ptxservq->tx_pending)) + list_add_tail(&ptxservq->tx_pending, get_list_head(phwxmits[ac_index].sta_queue)); + + list_add_tail(&pxmitframe->list, get_list_head(&ptxservq->sta_pending)); + ptxservq->qcnt++; + phwxmits[ac_index].accnt++; + + return _SUCCESS; +} + s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) { if (rtw_xmit_classifier(padapter, pxmitframe) == _FAIL) @@ -1863,40 +1897,6 @@ struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_info * return ptxservq; } -/* - * Will enqueue pxmitframe to the proper queue, - * and indicate it to xx_pending list..... - */ -s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) -{ - u8 ac_index; - struct sta_info *psta; - struct tx_servq *ptxservq; - struct pkt_attrib *pattrib = &pxmitframe->attrib; - struct hw_xmit *phwxmits = padapter->xmitpriv.hwxmits; - - psta = rtw_get_stainfo(&padapter->stapriv, pattrib->ra); - if (pattrib->psta != psta) - return _FAIL; - - if (!psta) - return _FAIL; - - if (!(psta->state & _FW_LINKED)) - return _FAIL; - - ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *)(&ac_index)); - - if (list_empty(&ptxservq->tx_pending)) - list_add_tail(&ptxservq->tx_pending, get_list_head(phwxmits[ac_index].sta_queue)); - - list_add_tail(&pxmitframe->list, get_list_head(&ptxservq->sta_pending)); - ptxservq->qcnt++; - phwxmits[ac_index].accnt++; - - return _SUCCESS; -} - void rtw_free_hwxmits(struct adapter *padapter) { struct xmit_priv *pxmitpriv = &padapter->xmitpriv; diff --git a/drivers/staging/rtl8723bs/include/rtw_xmit.h b/drivers/staging/rtl8723bs/include/rtw_xmit.h index b0189a703d28..a2ff62182b97 100644 --- a/drivers/staging/rtl8723bs/include/rtw_xmit.h +++ b/drivers/staging/rtl8723bs/include/rtw_xmit.h @@ -440,7 +440,6 @@ extern void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue struct tx_servq *rtw_get_sta_pending(struct adapter *padapter, struct sta_info *psta, signed int up, u8 *ac); extern s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe); -extern s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe); extern u32 rtw_calculate_wlan_pkt_size_by_attribue(struct pkt_attrib *pattrib); #define rtw_wlan_pkt_size(f) rtw_calculate_wlan_pkt_size_by_attribue(&f->attrib) extern s32 rtw_xmitframe_coalesce(struct adapter *padapter, struct sk_buff *pkt, struct xmit_frame *pxmitframe); -- 2.34.1