From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79BE738E8A6 for ; Thu, 14 May 2026 10:07:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753248; cv=none; b=HrGTP21oYh5eufcpz5A3usbW1jQcwPwf5rcxGS/I/akSx6zvQfSl71PXaEjI5r411S0RSD2H12oOVigoRN10Xdm/wBudRfNg1jSh6tdc/z0oSFXa4IGSIronGR651bGIPgYW4V3sdWc6Q2D33U7pj2hEjmtHt2lsjc8vS4JcAE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778753248; c=relaxed/simple; bh=OwRd3NUTkaAoh8Y+r/wsJsf4AWa/FLJ5AAP/ykOV6ps=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=JDDVIjQiPjRqeOxTTNl3SmYUTusKRFCcXQkyNu4JC3picWZf82E+ID/S/klY/uWoIidDr/d5Hvpm8krSnKjcxtQmr1RchOtsK7wYBOJWariQcPlxP+wgsHHgwVEixCTRvAeAk1ML6Ohc3ELHLUZTznV7b2uYh98PQqwYlAHSuJQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LJ43nzKz; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LJ43nzKz" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-1309f4ee97fso9799876c88.1 for ; Thu, 14 May 2026 03:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778753246; x=1779358046; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KhH4QN2V6pideai/krprs3/7h/AE1I4RG4vdBuW1XJg=; b=LJ43nzKzpb4y4OPTKfKPaDTDBADgEAhjt7CcGW1QGhyNH8EJQSUeTeiCESi7owVDnc A1Ql1G0iLRafVc/KkEQnsmzg2vWAb1xa5mf8paXPoRNrbWa/j3OnmyAlEdL3K1ePidkw VU3KnExjhoCj+hQaqgWQekeRmcZoEmSYA9VlIZWOlh6y9keIhsSsmdDvKXH/Ho5Fixjd sOkFquyRTE84N+SAh+wUb0SWQ482CSPEzWwx43MzOzhP/4xAXWEXI5DpMECZ00h3q9qm eTpx3t6RfiGtvAE+V2rSWAf/5jsRrX4mLXMKiLCHL53LzllfO0CkNSUdRi2YjNdPtMvR 6zSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778753246; x=1779358046; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=KhH4QN2V6pideai/krprs3/7h/AE1I4RG4vdBuW1XJg=; b=N/sQvGAnqEPdFg+N+uuxM+2VLI1W+8k+LsKELB28nbPBiQ6MW4O7jKXsBMiuVrm3zR iLXrb1hNLSfWlhoV2eaLfOCU0jnBBrTVBdEG7OGXSRuLmApnirkQTUx86Scoi1+j+6zI Zwkf6hWQrfQIyxTzKej0VAKfs9iH6amZU1hp9LMViY5okFax9jT5MaDBgEnfzBE8nAH2 9tvxRD2knwwyd3yk5aP3pqdxrYfRTpNzfgm6hhnt11HK6K427ar4QYRDL0xr3yHRF5Wj XAGb4sKhbvkFaGHlCMMIZCFIHqJ+we6tmUKfDi9K3QAbCtq1qFixXmlq818GWegIVU1g sPtA== X-Forwarded-Encrypted: i=1; AFNElJ+7j7CNrescIYRnw22bdXpJq1hBbLYwnWY7Dw4DvmWdCz7jLw89pM2uSH/5/LXJNT2eS9vPgcOzH0z71CE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw65lmzvLuBxYIxQfWrkE4M4p72h00XTqF+v0uH4on7anY1rjfg 8g7VykqXQQyD8ZpYb2wZlPk4deWiiu0B+OuAzwWNa2gEmXNqcDXV3kxt X-Gm-Gg: Acq92OHgOGaCfqgld9m1Pr9EIhJtuHM/FNRFviVU9WU7h0Jy2A8XW1WlKFFEUhCXnVd 7A/UvFym6KEeXpg35qTbPFtZ30r+5IhyHVvPxDsSNKv27EsomJchbBld/KP58u6sgMQClWhhc/X e1m3OtC1SAc8qievIjfgsdFhMjdHaZxtETbj7Wb+b0Ag5s3NOX5MuR/VErFcoCuHuiLXIVdIX5l vAfGol0ZkZTwhKyMczFyG83SryEY4BFBRe9RseZwwN+WOrWkUd47d7wc3Z8pTaQ9Grz/FIVQfY1 2+o6kRcwzk9WerXKe8llxV/4tcFs5J71H8I90z4IKdXOfTp/gCh2v4Ibbb28SfEjkliRHooJ+V6 NJQB4sFCOlJxcGayQBq+zPAR0oOUn+M80/FNhe5qKMDVs2kqymmDg9+AOnQ6duLuqy/DsdVkTuw CdU46Nu7Q8x6WsdhOKxH0XpmoVpHMYZu8AeUGEX0KCSgnE+0JbsL57D10= X-Received: by 2002:a05:7022:459a:b0:132:1e01:2d7d with SMTP id a92af1059eb24-1349a6f91cfmr3919417c88.5.1778753246265; Thu, 14 May 2026 03:07:26 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-134cbcb93f3sm3757921c88.3.2026.05.14.03.07.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:07:25 -0700 (PDT) From: Hungyu Lin To: Greg Kroah-Hartman Cc: Dan Carpenter , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v2 3/5] staging: rtl8723bs: convert rtw_xmit_classifier to return errno Date: Thu, 14 May 2026 10:07:06 +0000 Message-Id: <20260514100708.25031-4-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260514100708.25031-1-dennylin0707@gmail.com> References: <20260514100708.25031-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert rtw_xmit_classifier() to return 0 on success and negative error codes on failure. Update the caller to check for non-zero return values and preserve the existing _FAIL/_SUCCESS semantics. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index b3953bdedb04..80f3dfaf793d 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -1825,7 +1825,7 @@ void rtw_free_xmitframe_queue(struct xmit_priv *pxmitpriv, struct __queue *pfram * Will enqueue pxmitframe to the proper queue, * and indicate it to xx_pending list..... */ -static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) +static int rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmitframe) { u8 ac_index; struct sta_info *psta; @@ -1835,13 +1835,13 @@ static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmi psta = rtw_get_stainfo(&padapter->stapriv, pattrib->ra); if (pattrib->psta != psta) - return _FAIL; + return -ENODEV; if (!psta) - return _FAIL; + return -EINVAL; if (!(psta->state & _FW_LINKED)) - return _FAIL; + return -ENETDOWN; ptxservq = rtw_get_sta_pending(padapter, psta, pattrib->priority, (u8 *)(&ac_index)); @@ -1852,12 +1852,15 @@ static s32 rtw_xmit_classifier(struct adapter *padapter, struct xmit_frame *pxmi ptxservq->qcnt++; phwxmits[ac_index].accnt++; - return _SUCCESS; + return 0; } s32 rtw_xmitframe_enqueue(struct adapter *padapter, struct xmit_frame *pxmitframe) { - if (rtw_xmit_classifier(padapter, pxmitframe) == _FAIL) + int res; + + res = rtw_xmit_classifier(padapter, pxmitframe); + if (res) return _FAIL; return _SUCCESS; -- 2.34.1