From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 14CD61F2380 for ; Thu, 14 May 2026 10:30:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778754653; cv=none; b=A2aql9xRiZyHBGQ+tzFFe9VdzEZthFM3PWecrbc8YpfAoocDqnnSCTlltW0Jd/tF5ocx3lb4FKIJKNeqNwFUKpk21mA6pToyklk5TZPkore9sGSB7CmTJxtmiw/QcNFC/Cct6QLVJ7h5kKKElHaa+rFL+U4jSqosGxETDmH3JzE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778754653; c=relaxed/simple; bh=7DRUcn1z1lAVxDX2oROhlzkd/x33hcrvonRVFJgizJc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Xbcq+KSwJ75WuzfIu9pIk33i47c/Vsi0XYwZTH7Tht31TJEO5BFItrOJJo0pCg3We3KvT9FbLJ04TbcMbb95PCbjAfQTjarBetiAZkDWsrwrb5XtOjcqaBFfVQazfcKoyea4bUUEBrrRjChZYcgigChyCodpO5zT/WDbx9Fb5Eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P+Ih7++X; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P+Ih7++X" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba1e9d3687so51460425ad.3 for ; Thu, 14 May 2026 03:30:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778754651; x=1779359451; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=fdFlkFOWt/jZ2tS4R334p9A28Ma1mptG39Xac/iq1co=; b=P+Ih7++XM5CwC3JagG+Ev4+HipXxK3NB6nc6IOQ+sYnio7qCOFxtpsYMmPwul2EOdC dg7Dpys1rp3d+Vbus5fH+Q35y4YgvoX1T/cGYzjHfCqef6TA8rySU+rJZxIb4Zuwg9oa Y9SjmdgqSo9+arpSv6r2IGcLXYesvTy0EOWxz2ZTWJsGVZOg7Cl+hPDD9KMNae0KADcJ pJ6R0uzX97Md71NJ7bG7GFSJIB4Gsl9/CQOSsEe45K3ejQ/6q6kJBrbuA+HX9Pul/Yp4 x5DyIUOdfyvnj0o8E+Cs9iL+g5Ci5Kht3ulWE4kKugKc+Fzsd0CfbBzhNAKyTlbwTuy8 oZNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778754651; x=1779359451; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fdFlkFOWt/jZ2tS4R334p9A28Ma1mptG39Xac/iq1co=; b=ohGg/EVz4FKJHlJG5M3+i7htko7OT24kMT0ONlZ8Wkn8dshssx482rCJ1N5gAXVixl 6Bwt+0L4xh2iv+cmwFeN7dBEVybBR36JbRajhXDTzImoYVV/WeWWV3hVxLH+wjDQreGf ucN91sGjwZ1f6x3o2LijmowRI4RfIHgru+ueTSr9FGcHkHaw0cPBF4slyLTzNhhkMIKy EaYFf476K+oH+zkhSO0OFdkhNYV4BQ877Ov/0n5ExrQnN76oMRAunISvY020JmiyDPJ8 gMujVrPsVtP/ewAjahbqYVAobGQlC0DBiAhSjdtkCThy5RtHyDFK/rttOz/n9cKpPD2/ flVQ== X-Forwarded-Encrypted: i=1; AFNElJ/41g61i20Mphoh9yF2/KlvWulEDUwotfNe34bnB+ZZxgipKDmMMHEsnZACtj6DgdRYVaRNy5c8TR4sqSM=@vger.kernel.org X-Gm-Message-State: AOJu0YxLllFGA0noc4WvppKIdNFKiRO3//ms6YHTbCXDuj98JMT0RGWW XSVBx42uP/nM6M1J16mko52E4rVhhQzCbl5wYFjdU4HJ1GaFEGFgmCUb X-Gm-Gg: Acq92OGLDaVlM30Blh2J7PvT7oyO8iyj954y1qc/BLc+l1YznGzW3NXh6EvKvTKq352 OYajyToZClWtDO2ceKQ7eJMbeKraP3x5aTZpwQcY1ZN/3SS34grU2gLm6dser3gt0jYLO5dT6gd mzUculep1B3Qj43WovgwBY5mfWaUh7gQXDSn3NXXCQdNw5uSnq3uEPEAMS4EtZM4nqKgqlsMPcL mMhw/B9NxGAlZGffbcqqclaGXhRuS0eWdNuFy6V7jt0dhdS4HMmjKbKiWjiRCf64pygWyVrH3SD GZg2oRpIQ9RciyUfH9VScs1mEHpx2GLD2PypbsZS8rTbTaaqoinVehLbOWtgHo8rfiXBYygRcRl 1VYPwb0kfwY50HqT+ptrlUSXc5MF2Qp/ZWB3QEI0kCPmd0y+iCBqlA434LsYFSuTd/C09ddNfOL EODvM5Mzq+qMiYBpLM7c1rHvu9FnkDRFbxrtLnAl+5Jug1GyOoCGlKxFyRVVU+ X-Received: by 2002:a17:903:46c4:b0:2bd:2de3:51ad with SMTP id d9443c01a7336-2bd3043ca95mr74387675ad.34.1778754651014; Thu, 14 May 2026 03:30:51 -0700 (PDT) Received: from localhost ([2404:7c00:52:8f0e:aae2:91ff:fe57:5e15]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5c05f5d2sm20493615ad.23.2026.05.14.03.30.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 03:30:50 -0700 (PDT) From: Chhabilal Dangal To: Greg Kroah-Hartman , Sudip Mukherjee Cc: linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Chhabilal Dangal Subject: [PATCH] staging: sm750fb: Add suspend checks to copyarea and imageblit Date: Thu, 14 May 2026 16:15:42 +0545 Message-ID: <20260514103042.55313-1-yogeshdangal66@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit lynxfb_ops_fillrect() already checks info->state before accessing the hardware 2D engine, but lynxfb_ops_copyarea() and lynxfb_ops_imageblit() do not. The suspend path calls fb_set_suspend(), which sets the framebuffer state to FBINFO_STATE_SUSPENDED. Add matching state checks in the remaining accelerated callbacks for consistency with fillrect(). This patch was developed with AI assistance and is compile-tested only. --- drivers/staging/sm750fb/sm750.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 9f3e3d37e..025ac8fe3 100644 --- a/drivers/staging/sm750fb/sm750.c +++ b/drivers/staging/sm750fb/sm750.c @@ -204,6 +204,9 @@ static void lynxfb_ops_copyarea(struct fb_info *info, struct sm750_dev *sm750_dev; unsigned int base, pitch, bpp; + if (info->state != FBINFO_STATE_RUNNING) + return; + par = info->par; sm750_dev = par->dev; @@ -239,6 +242,9 @@ static void lynxfb_ops_imageblit(struct fb_info *info, struct lynxfb_par *par; struct sm750_dev *sm750_dev; + if (info->state != FBINFO_STATE_RUNNING) + return; + par = info->par; sm750_dev = par->dev; /* -- 2.54.0