From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2BAD1A6824 for ; Thu, 14 May 2026 15:47:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773651; cv=none; b=sWspNLq7mEg2rwTs2f4NI7Z5klBGGSwU52IKVUJyDv+Ja/hICSw+2/+bZ/BvHWAFML2jKfHEO1EsFhlD+a1rJDKhtjxrackjjW1GHX+QKYWzbeB8m6/h5ANQ0kfQLdfe/iV1SJqbxSluyulBQBxVXV73RSACjV+DQ0QDVkNHztY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778773651; c=relaxed/simple; bh=sBS9FZZLijles2p8ZJzPyEoJGKrDkc+L9rT8SXjdOlc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tnAsWxvK5utuzLYj5Wg0Xl/AQjHB/d6pDptZcjrP8+S/gw94WHVX440Cm4rJxQW3i9b1EprwJEgBy8NLvt4d/oMbyGYs4TbFlEGn3V6lqIlwgVUvIJ714fZnh52JVHnV+VyO/3YKid0SA1xA2zWlmQfUj0qxiAoExVR2/h08wK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Hgzh3q1B; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bf82/Hls; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Hgzh3q1B"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bf82/Hls" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778773648; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bqdtv1pQkNj5ZtCXeAHZim6ZUYoMn7Cztcf2yOjIZPA=; b=Hgzh3q1B6on+SeLUhaXlg2qaY3n+0tm+2iP++AHO4wQ3wELAaBXmBh1j7Nno2t4yQMho6I dFSlfMezX/n915YPSX+o42HKn/H9f1aVPfcpwqTN24jp+OBSyp2nF/i6T7hPR7qJeE5DjE wAIzN985Bz7SRHWiHG1sP6nICEpS3nc= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-9LQ6KGBDMUmxG8pgOVTjMA-1; Thu, 14 May 2026 11:47:27 -0400 X-MC-Unique: 9LQ6KGBDMUmxG8pgOVTjMA-1 X-Mimecast-MFC-AGG-ID: 9LQ6KGBDMUmxG8pgOVTjMA_1778773646 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44f1b4d0fb0so5305611f8f.1 for ; Thu, 14 May 2026 08:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778773646; x=1779378446; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bqdtv1pQkNj5ZtCXeAHZim6ZUYoMn7Cztcf2yOjIZPA=; b=bf82/HlsfCC2pvP8Ejgw3m5ZFww2ItvD50kQbeGfE5qMkTFzsIvYkx982UGZ379Int FTocAEo7RdRrAI41DgaohoICUb0uEa+spvP2Z2oXEs67ZrGDYhoPMJG3IWUX8nVw27XO aee87KkOALKwVTwpcNoxLXmxAwCQkR+FjJnPDwx6DeAfeLpwCbw5E2pInUmnQY10s3sh 183Ux6uXB+D0PQljVnhCm/5+KVhUSs12zhDuWyHqyhKY209PRxG5CXh/zZfWPOpg/FHY qcXzM/TdvtU+GQ9Zi18RB1TVEwWajpAg0x2S8q91LC0bD4EuyEeWuvktopbC2gb9lVEE j/pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778773646; x=1779378446; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bqdtv1pQkNj5ZtCXeAHZim6ZUYoMn7Cztcf2yOjIZPA=; b=psc1LZSsmvz2h9AP8E64o5Aa0WrzOru23+3WBVPW+JscA7hpoolTKJO03tAPRvBSxW QS8hiKuvu+OWmtxyg/YC+eHRjIhC/pMrrKe5XqqN0+eK2ef9Zzh7hI2xU965+O8YNj9q L6vGvvixAKl4t3MfUTr960ARUGq7p5MAl+ga3tAVL8kyKZdyjP9XVmUy5ucBHqe/4DRQ isx4zlcX8954USnjA5dJVF3DIPX2Xj5Zft/DgufloBMa07+sv004m4tzofyH0qVzlus3 4pAMurFqvy1jMKLhtMqq+kk761RHbWv+S4cqsYk/CulbJUCEQ3pGhq6mxC6ViVGVyrfA c56g== X-Gm-Message-State: AOJu0YxJFIpjyyiURL48iPdnlMw2yx6u4/IjyK0PHKknd0MoodmvUAXo 9KY72NyM/JCAfoMCcLBv1oZHbytfbD1ZLqNxax6aszh9PKOHl0ZDDbbz1XVmP38aDGunz9tHGfR TQL4pBEf6nIJyG1YAzQ5EbjnVbH+8DtMlSo26F5HCI78EStsTCyxRoRlRVUi3/vxHeQ== X-Gm-Gg: Acq92OHOFKDzeYYVTZimPEOF/EyAut2jrbHB+2d5LOClIsXBgiHeGS1EcxndVV9caC0 N+Oh7eE2L+HBa2o8vteK5q5Fb/iDB8Lz2sEuTiVFPEJ/D9b/ZxacRL0GIKK4ukCxxlUBSvWKG/f A9sKoyXj/PBfg4V8KyVNsBjS4YEqHt7WT088VqP2NxY1Fp+CtIUbnPAiP83kGbCDeM8d1c8s2IM vJg38srRmlllrPJFz2JVJSMVnqOae6LJK6bW6itsobu//FHGu7UUIeB/Z0Xa/iirZRcqNZee+d5 fXxh7rH8ZSLujQuKDnFLRHnwZmOhUckuTvLM4KYBq6KEj8+M3AyccPiMXrslJEMFA6Q+Q1pfxRq rzc7bAJW6S8+6+whb/Ffs5Ujy9zt9xIg7OTtMzvwc X-Received: by 2002:a5d:5f45:0:b0:449:a07a:967f with SMTP id ffacd0b85a97d-45c5a1a8e93mr14113710f8f.28.1778773645826; Thu, 14 May 2026 08:47:25 -0700 (PDT) X-Received: by 2002:a5d:5f45:0:b0:449:a07a:967f with SMTP id ffacd0b85a97d-45c5a1a8e93mr14113648f8f.28.1778773645241; Thu, 14 May 2026 08:47:25 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45d9ed2f738sm7555351f8f.16.2026.05.14.08.47.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 08:47:24 -0700 (PDT) Date: Thu, 14 May 2026 11:47:19 -0400 From: "Michael S. Tsirkin" To: Gregory Price Cc: linux-kernel@vger.kernel.org, "David Hildenbrand (Arm)" , Jason Wang , Xuan Zhuo , Eugenio =?iso-8859-1?Q?P=E9rez?= , Muchun Song , Oscar Salvador , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Johannes Weiner , Zi Yan , Baolin Wang , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , Hugh Dickins , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Ying Huang , Alistair Popple , Christoph Lameter , David Rientjes , Roman Gushchin , Harry Yoo , Axel Rasmussen , Yuanchu Xie , Wei Xu , Chris Li , Kairui Song , Kemeng Shi , Nhat Pham , Baoquan He , virtualization@lists.linux.dev, linux-mm@kvack.org, Andrea Arcangeli Subject: Re: [PATCH v7 02/31] mm: page_alloc: propagate PageReported flag across buddy splits Message-ID: <20260514114637-mutt-send-email-mst@kernel.org> References: <20260514104735-mutt-send-email-mst@kernel.org> <20260514113337-mutt-send-email-mst@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, May 14, 2026 at 11:41:45AM -0400, Gregory Price wrote: > On Thu, May 14, 2026 at 11:34:14AM -0400, Michael S. Tsirkin wrote: > > On Thu, May 14, 2026 at 11:32:26AM -0400, Gregory Price wrote: > > > > > > > > > > Maybe mildly out of scope but worth asking: Are there other flags that > > > > > should be retained/propogated on a split? If so, rather than pass > > > > > was_reported, should we just take a temporary copy of the page flags and > > > > > pass them all in? > > > > > > > > > > ~Gregory > > > > > > > > > > > > Not that I can see, no. > > > > > > > > > > You do this exact thing again later :] > > > > > > https://lore.kernel.org/linux-mm/9a22e0f9bbe1278913754db6df76e291a006181a.1778616612.git.mst@redhat.com/ > > > > > > ~Gregory > > > > I mean yes, reported and zeroed) Just zeroed does not exist at this > > stage in the series. > > > > More of a forward looking question: if we already know we're adding > was_reported and was_zeroed, maybe we should just pass the page flags > through entirely and let expand() check them instead of passing it > through individually. > > We end up doing something similar with post_alloc_hook later as well, so > I'm wondering if there's a general improvement that can be made here. > > ~Gregory sure, will do. do you want a bitwise thing for type safety? or just a long?