The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	damon@lists.linux.dev, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: [RFC PATCH v2.1 24/28] mm/damon/sysfs: add filters/<F>/path file
Date: Thu, 14 May 2026 07:08:57 -0700	[thread overview]
Message-ID: <20260514140904.119781-25-sj@kernel.org> (raw)
In-Reply-To: <20260514140904.119781-1-sj@kernel.org>

Introduce a new DAMON sysfs file for letting users setup the target
memory cgroup of the belonging memory cgroup attribute monitoring.  The
file is named 'filter', located under the probe filter directory.  Users
can set the target memory cgroup by writing the path to the memory
cgroup from the cgroup mount point to the file.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 mm/damon/sysfs.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index e4dbf85feadc2..2b68e1a7de451 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -756,6 +756,7 @@ struct damon_sysfs_filter {
 	enum damon_filter_type type;
 	bool matching;
 	bool allow;
+	char *path;
 };
 
 static struct damon_sysfs_filter *damon_sysfs_filter_alloc(void)
@@ -774,6 +775,10 @@ damon_sysfs_filter_type_names[] = {
 		.type = DAMON_FILTER_TYPE_ANON,
 		.name = "anon",
 	},
+	{
+		.type = DAMON_FILTER_TYPE_MEMCG,
+		.name = "memcg",
+	},
 };
 
 static ssize_t type_show(struct kobject *kobj,
@@ -862,11 +867,46 @@ static ssize_t allow_store(struct kobject *kobj,
 	return count;
 }
 
+static ssize_t path_show(struct kobject *kobj,
+		struct kobj_attribute *attr, char *buf)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	int len;
+
+	if (!mutex_trylock(&damon_sysfs_lock))
+		return -EBUSY;
+	len = sysfs_emit(buf, "%s\n", filter->path ? filter->path : "");
+	mutex_unlock(&damon_sysfs_lock);
+	return len;
+}
+
+static ssize_t path_store(struct kobject *kobj,
+		struct kobj_attribute *attr, const char *buf, size_t count)
+{
+	struct damon_sysfs_filter *filter = container_of(kobj,
+			struct damon_sysfs_filter, kobj);
+	char *path = kmalloc_objs(*path, size_add(count, 1));
+
+	if (!path)
+		return -ENOMEM;
+	strscpy(path, buf, size_add(count, 1));
+	if (!mutex_trylock(&damon_sysfs_lock)) {
+		kfree(path);
+		return -EBUSY;
+	}
+	kfree(filter->path);
+	filter->path = path;
+	mutex_unlock(&damon_sysfs_lock);
+	return count;
+}
+
 static void damon_sysfs_filter_release(struct kobject *kobj)
 {
 	struct damon_sysfs_filter *filter = container_of(kobj,
 			struct damon_sysfs_filter, kobj);
 
+	kfree(filter->path);
 	kfree(filter);
 }
 
@@ -879,10 +919,14 @@ static struct kobj_attribute damon_sysfs_filter_matching_attr =
 static struct kobj_attribute damon_sysfs_filter_allow_attr =
 		__ATTR_RW_MODE(allow, 0600);
 
+static struct kobj_attribute damon_sysfs_filter_path_attr =
+		__ATTR_RW_MODE(path, 0600);
+
 static struct attribute *damon_sysfs_filter_attrs[] = {
 	&damon_sysfs_filter_type_attr.attr,
 	&damon_sysfs_filter_matching_attr.attr,
 	&damon_sysfs_filter_allow_attr.attr,
+	&damon_sysfs_filter_path_attr.attr,
 	NULL,
 };
 ATTRIBUTE_GROUPS(damon_sysfs_filter);
-- 
2.47.3

  parent reply	other threads:[~2026-05-14 14:09 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14 14:08 [RFC PATCH v2.1 00/28] mm/damon: introduce data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 01/28] mm/damon/core: introduce struct damon_probe SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 02/28] mm/damon/core: embed damon_probe objects in damon_ctx SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 03/28] mm/damon/core: introduce damon_filter SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 04/28] mm/damon/core: commit probes SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 05/28] mm/damon/core: introduce damon_region->probe_hits SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 06/28] mm/damon/core: introduce damon_ops->apply_probes SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 07/28] mm/damon/core: do data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 08/28] mm/damon/paddr: support " SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 09/28] mm/damon/sysfs: implement probes dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 10/28] mm/damon/sysfs: implement probe dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 11/28] mm/damon/sysfs: implement filters directory SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 12/28] mm/damon/sysfs: implement filter dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 13/28] mm/damon/sysfs: implement filter dir files SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 14/28] mm/damon/sysfs: setup probes on DAMON core API parameters SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 15/28] mm/damon/sysfs-schemes: implement tried_regions/<r>/probes/ SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 16/28] mm/damon/sysfs-schemes: implement probe dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 17/28] mm/damon/sysfs-schemes: implement probe/hits file SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 18/28] mm/damon: trace probe_hits SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 19/28] selftests/damon/sysfs.sh: test probes dir SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 20/28] Docs/mm/damon/design: document data attributes monitoring SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 21/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 22/28] mm/damon/core: introduce DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 23/28] mm/damon/paddr: support DAMON_FILTER_TYPE_MEMCG SeongJae Park
2026-05-14 14:08 ` SeongJae Park [this message]
2026-05-14 14:08 ` [RFC PATCH v2.1 25/28] mm/damon/sysfs-schemes: move memcg_path_to_id() to sysfs-common SeongJae Park
2026-05-14 14:08 ` [RFC PATCH v2.1 26/28] mm/damon/sysfs: setup damon_filter->memcg_id from path SeongJae Park
2026-05-14 14:09 ` [RFC PATCH v2.1 27/28] Docs/mm/damon/design: update for memcg damon filter SeongJae Park
2026-05-14 14:09 ` [RFC PATCH v2.1 28/28] Docs/admin-guide/mm/damon/usage: " SeongJae Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514140904.119781-25-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=damon@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox