From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E960C28AAEB for ; Thu, 14 May 2026 14:23:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778768600; cv=none; b=HKgsjuc8hHs8MVy0Pw4qB5lur+CPNedzFS15CrFn12tdM/I0t5lVnlof4JNKq4uQpFHUFqhmF8rPdLtnXheWwEXNhMHBPpSNIBaYmagIfBh1RXs4zvD9iAnn8MTpHKYDUpGGVewHtghgsGSa8Z4ZHCcjN58I+OnPIErvxE92S4k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778768600; c=relaxed/simple; bh=s8/oSNdDzyaW9JgdNEshO1W6QttcoYdTTxOogreW8qY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Kqln1Kc1nKoQOX7Bd/ZngVq4kY2EHEgVrrgBDVd2jlknGLPzgVZNCywImNmRRlYiAGxj/4YZ6gaQ82iLvEovZkOMe2m9idAFqmKfRKY3+sR6CcZXwU3a/kKF22SvA6G6z1dmaDVB4cHZWSDRSsJszb7FiK4itHyYqIw411Ap2Sk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BPmI/LVz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BPmI/LVz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46C03C2BCB3; Thu, 14 May 2026 14:23:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778768599; bh=s8/oSNdDzyaW9JgdNEshO1W6QttcoYdTTxOogreW8qY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BPmI/LVzSIvqPiHRUQXsvZ/EkZwCRxVJZxDPZ2b4C6TUPcD2w7mmiUDN4B57ZBNTN G44ymWA5fZ3RU+DLdAiXX4kLyOGpjYjNjLHVafdcuEF9odj4KV1e0z/vGujscJl4P9 l0wQ3t+Up2NebtoZQHR9rvHqHpy0hN8wSATdSaTSbNsxcNSzWINqZ0coHP/cm7mfu1 tgFG/5uT42LO1dMbt0xWGm/tfg6hzEdwqChan+3Udy7nQcxZJMPKOyBCerx+3tan4W cW/yttmr5oRlrcfRfgsvUUWErVhKIKUnqDXNbQr66o6YmbhKSak/hxrHQLiTzJi0E2 1HPRgBIJxOEfg== From: SeongJae Park To: Steven Rostedt Cc: SeongJae Park , "Liam R. Howlett" , LKML , linux-mm@kvack.org, Alice Ryhl , Andrew Ballance , maple-tree@lists.infradead.org, Andrew Morton , Matthew Wilcox Subject: Re: [PATCH v2] maple_tree: document that "last" in mtree_insert_range() is inclusive Date: Thu, 14 May 2026 07:23:11 -0700 Message-ID: <20260514142311.119947-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260514100723.4af0d7ba@gandalf.local.home> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, 14 May 2026 10:07:23 -0400 Steven Rostedt wrote: > On Wed, 13 May 2026 18:42:04 -0700 > SeongJae Park wrote: > > > > /** > > > - * mtree_insert_range() - Insert an entry at a given range if there is no value. > > > + * mtree_insert_range() - Insert an entry from [first, last] at a given range > > > + * if there is no value. > > > > It feels "at a given range" bit repetitive to me. s/at a given range// ? > > > > I just added what Liam suggested. Liam's suggestion was very sligtly different. : Something like this: : : mtree_insert_range() - Insert an entry from [first, last] if there isn't : an entry within that range. So I assumed you intentionally reworded it, but might forgot erasing 'at a given range'. English is never my mother tongue language, but Geminit also told me dropping 'at a given range' makes it bit easier to read. Hence I just wanted to check if this is intentional. > Should I send a v3? The current wording works for me. English is never my mother tongue langauage, so I cannot judge. I just wanted to make sure this is the intended change. So I will leave the decision to you and others. If we decide to rewording, I think Andrew could help without asking you to resned v3 for such a minor change. Thanks, SJ [...]