From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61A27358368 for ; Thu, 14 May 2026 18:30:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778783426; cv=none; b=IqpSH6UK782m3mgLM64Qxmrd4Tpa9/9D7iF972OkEi0CmOSW4IpdxjEj70GzQAI/9AOjnFZZKFm2Xc0GG1u4PcRgNPWre5qDZzXHU8r8/wrsfchJRnhg9rv4wBQGSYnvNL82DFR4Yw+XcBN5BAlSSH/CeKROgjz/14TVR7jKmrc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778783426; c=relaxed/simple; bh=Geh2ltdSeCVx2RDd9OVcFGSMPDFuS/R9rLGG9L0n78w=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aNkgox79habwkcQeP6Jl+fb0KI7Q0gK2vn05zH3v32JitxKclSnMAfXA3WBGRj/7O61dDukPRbYJkEtnKNfATYOkEcFcNnBsIlJtcHQRonnRWbizE5o110Q3tBHdwYpwBDhlQK5t7nYwVM0grKcNINHbvgf97vXnNz2IT1osOAw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EDRWyMGM; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EDRWyMGM" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4891c0620bcso57489415e9.1 for ; Thu, 14 May 2026 11:30:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778783423; x=1779388223; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=QDvdudeeJAHgJGuZXL6tml+bzI7syuTzDcLB+eMLOx0=; b=EDRWyMGMjir7OpKYn0HyzUeZIzVBWxj31SB8FtQr49EyffcWq+6Xj2MscHdzqwhYNe qrzkEWhuxR4rdKZFvWaoWzeqSTmgCjxZm+BOuQ/ZShdhk1cXPLel70PEzZlx/7wxU938 /3cBVSN/twyjYPfZUeugziudPcDBg4OrKm3P23dLVVm50kpIq/9u90WFFeTgSEGJLn44 TOf+eXa0v9v363ViOyeUGoq72nK6U9nBu1Ngdj/lhkNfg0Ma5ugk/uhofJAkFommqTgr u+pV8I8nV0JVO+XaAMxR7NusL9dF77VblO+h70UIlYa102sCgBJXp84iLUWZHrV9XBYc +i8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778783423; x=1779388223; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QDvdudeeJAHgJGuZXL6tml+bzI7syuTzDcLB+eMLOx0=; b=HzfTKvlf/g0iKeVsMAWX4PxzEfa8ZyjZFGjr+Cvkaeq05ATUK8rxmZGfZa/Ym01FHe TIwn+pDj0iXRuNTfmMg4+FcRkqQQLU1uumn75l+anERttO91+AlfcPLY08cQrr5SKCZZ bPw5aKNcdWAQUxuNS9VtZ3I1bzhxBd+iP6LSNUvVs57wUt+7fPiFaOTBk5Wqb+WgbMXj EvbQd2rqb+FRoS3i40hqNybK2B35S6jqyBypa/aBWa6L1Vd6RxxtN7g/XNxa1BoUu6Rd PaPB5W+JumPZYjRsEzb2GOldHWvkUT4cerlZWEtuYU3bMzL+0R3CPi1RPQc7BZezUcnI fQVA== X-Forwarded-Encrypted: i=1; AFNElJ88gmoXWLu+vjOTxJ5jfZLDLdSKXUFlrWMyqI3wMe8QCz9aLfqu/6Uhi2hFEviI58FlRgJ8jmA451LS3/0=@vger.kernel.org X-Gm-Message-State: AOJu0Yxl626FUuZlErjSI5rD8k6zxxXVEN8cA7yiNl4xhYcewZPGRrr1 AJwuW+He/lcb60P5Iu5GyDX7/NfcHHeYyj2vsPXlnB7SQcWT20eWr7WF X-Gm-Gg: Acq92OG0fJk025YmRLjGMjqUzGu/tV1lrdHF+NgXjGYQ6PQTvzIow2TlBuZiDPN3EHF Z19kuajwoeGqaXM0bUfcWfLayYujMXTsnikc8ZUzD7w3cs9B3rZU30npyaMh0NLB29MJeYYSt9Y lg97xcZhiS8kio+QesOr/1GBDKKYg7eUjhHEQI8MXcO4qgjkxRUxZoQ8cM4j9azMG8KYqJE3Inw ScGCOYNn5GjOzuR/8jmonnTwr/CVjQI9Yj2G0stbGH4tUDiCncgztNW7Iwc+I3RGgi3rQlQHiXk EFgTdbhSIfmdHGerbvQOYY6gIg2xzxsU5mJ/aF1IvE3VQe9Y/FZzgZ2DmqyCiUzMoop1OmwRUhm of1tk/gUKloT3l/nFbO99bFLT8rjF31EoQEEsE2TIXUUekfkYNEIPu1gWO1OPsi14QZQ2VUJpBp b/yNkEJIyUq59CmIHHFw/zKdRmUuXtEqvnrzUzpifKHfffn4aNajEMU2v4oRzfu8AHai1qBDXqQ EQuyCP8Dwg= X-Received: by 2002:a05:600d:8447:b0:48f:e230:80a1 with SMTP id 5b1f17b1804b1-48fe6328b5fmr5516255e9.31.1778783423173; Thu, 14 May 2026 11:30:23 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fd76801f2sm31320475e9.7.2026.05.14.11.30.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 11:30:22 -0700 (PDT) From: David Carlier To: anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Carlier Subject: [PATCH net v2] idpf: handle NULL adev in idpf_idc_vdev_mtu_event Date: Thu, 14 May 2026 19:30:19 +0100 Message-ID: <20260514183019.49527-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit idpf_idc_vport_dev_ctrl(adapter, false) clears vport->vdev_info->adev to NULL but keeps vport->vdev_info itself. An MTU change after that calls idpf_idc_vdev_mtu_event(), which dereferences vdev_info->adev for device_lock() before reaching the (!adev || ...) check. Cache vdev_info->adev once with READ_ONCE() and bail out if NULL before locking. Use the cached pointer on both the lock and unlock paths so the unlock matches the device actually acquired and cannot re-fetch a NULL slot. Fixes: ed6e1c8796a4 ("idpf: implement IDC vport aux driver MTU change handler") Cc: stable@vger.kernel.org Signed-off-by: David Carlier --- v2: cache vdev_info->adev with READ_ONCE() to avoid double-fetch and use the cached pointer on the unlock path (Alok Tiwari) --- drivers/net/ethernet/intel/idpf/idpf_idc.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/idpf/idpf_idc.c b/drivers/net/ethernet/intel/idpf/idpf_idc.c index b7d6b08fc89e..9f764135507c 100644 --- a/drivers/net/ethernet/intel/idpf/idpf_idc.c +++ b/drivers/net/ethernet/intel/idpf/idpf_idc.c @@ -162,9 +162,12 @@ void idpf_idc_vdev_mtu_event(struct iidc_rdma_vport_dev_info *vdev_info, set_bit(event_type, event.type); - device_lock(&vdev_info->adev->dev); - adev = vdev_info->adev; - if (!adev || !adev->dev.driver) + adev = READ_ONCE(vdev_info->adev); + if (!adev) + return; + + device_lock(&adev->dev); + if (!adev->dev.driver) goto unlock; iadrv = container_of(adev->dev.driver, struct iidc_rdma_vport_auxiliary_drv, @@ -172,7 +175,7 @@ void idpf_idc_vdev_mtu_event(struct iidc_rdma_vport_dev_info *vdev_info, if (iadrv->event_handler) iadrv->event_handler(vdev_info, &event); unlock: - device_unlock(&vdev_info->adev->dev); + device_unlock(&adev->dev); } /** -- 2.53.0