From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A42C91E832A for ; Thu, 14 May 2026 22:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778798789; cv=none; b=Llrz9AS30To/j3FGIAeLEJo/OCGQDeN/kfNRcne/N3g9WSp9/vZC+K0Y9cWFrX4tmwPfP28TPGwSqpYtUO1bp8XrWW1oDoiJ3U1/Tz6MyH8+ckeK2KjUWTYhPDXGfCDTy+25WrYsntSt1Gn+hIez0LPZUet3r9Bm+mRv5NDPDZI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778798789; c=relaxed/simple; bh=/qpTndcQcsSMTbBh2g/Dq1Edd2Lq9Y46ZytiK3Q6898=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=npkej7tv2pOu/b42L9Lk7bfvpHLZmrEXMzQstIDiUq5+52vy56wYrEQHWxiDgr6o0PAEvWvMeW04UsbUR0yP1F57hAmVbnhWzATNaAb9ZAS1aINwVAFHiqJAVwOdRCUCVGRX4QzesvFZOsQMPCKdFfH4ENXtlQkaJSQUvW2VeaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hTfbbZl/; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hTfbbZl/" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48374014a77so73680405e9.3 for ; Thu, 14 May 2026 15:46:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778798785; x=1779403585; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=3eYrTvT8XGfhOtNqMi4pNf6wVMIheUqf8s/MFC+uDco=; b=hTfbbZl/xpINJixLnDgVBieT9NCANNUIPRkfP4m9b0n7w47OwZ+N0oQ5FGE79//P5a DuI/om6xC3vl4hs+WONYqjgN+/RUUQwnA1kZPzq/LOgITuh5A6CjcHGDhJPUJI76roda C2hePwIsOyAAjqmws9nlf7J/a4BRiAYxUBmMeOPtaBQpOLORe07dYvcTTKykOZC0uA9t x9J0aUXCRUOWGdf8lkRFJqhDh399z02UcZOI5eAgNPJwsaQZ0mGKzouvSU/YNoQ5pSfm /idiwPDOdOAxu4K1AjZo3Vq83DfOT3BpEXWky2cahA8Vr37SRtoQqgoopOrM1UejJnQj 93WQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778798785; x=1779403585; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3eYrTvT8XGfhOtNqMi4pNf6wVMIheUqf8s/MFC+uDco=; b=bP5mpt7ZWgyEs7FAuLCNuyTuVrA4vfpRyGYCgZfFyb42GWzpJ3Ld1gkx1kd2Xgwi1o S8IiMEAsC6VJOBbtH0u2ii93Ida3fi21obW8LjyX77T80b1bun6jewbB0CRdhT1j4/NM Xa2A0O9q+j/Fw8nuaGWyJUSAaCqbEjf1itIsm11NXCHrLoa2W39dMDu4wUqgRFV7fubC Qh8eYxV/UQFzVTw/Fv4v5vepuPulKr0znAI67+z51JHYLnrDyTsIgBcj4SjbD/+qAOoL 80sq0fwRnRGlC8fTCzOsX1I0bF+4QYMxjbnAIPoNMIYKs/FFNVKKmruJH9QQPPtuxvoF In2Q== X-Forwarded-Encrypted: i=1; AFNElJ8SfjnRBUPkC52yAGReKePr0y60YxlwVBNaIDKWkwO2r35lsNOK8AJKmzI8ycFuAEogLLVPNsCDk3+KHEM=@vger.kernel.org X-Gm-Message-State: AOJu0YzixqVZv0RLbrmJ40VeAqefxApDrBjtbaIJ6PbFHPd84B6yL/XO KC9NJAakTuDjFgl77lNtda1PsEtZkyM2wEUnNCWyMzi4+EHalomI6gO0 X-Gm-Gg: Acq92OECzPgO2B9n51JiuBHHh974n9Q/qlV2CD+pYX6BKQBKFARoG7toFXT75kqd116 mDnwtsa8+eXx6ywrYtasttpNa51gTWA5eOkSDXxK6jKPPRhiOFUUS21ZTu4LILWLI/IL1njsjHa 1Jw8hoV2k37s5AGAJzRP61GsXTGP7lq60L6DiwtvibZ0S+v+l1U/bW3uiKY6da5PokxXd/8FiRx v0a1xaXJPsST1pMMPntBCkGJ9eYYYetRoA4AZ7U2Lp+C8uSeyT6opxmtvrV+OrJquPIHD7genGD Zwqx3IiEhQzn7eg4+VJKXCGjKz9EoP76qU90LijISU10/36WLaAcjZLnfY0rxlqZdg3lF8HkNS6 ZbovuxGyrN3zAAdPcYR7qiSJldDeJ8i1agWFkVR1ebCDHnc81ZDaTZBNvyFWO6Rx1KlQ6a/Kqqc iPlShXm+S6WJ68Ut1dB2mWj0FLSg== X-Received: by 2002:a05:600c:698d:b0:48f:e230:2a1c with SMTP id 5b1f17b1804b1-48fe6631158mr15651015e9.31.1778798784371; Thu, 14 May 2026 15:46:24 -0700 (PDT) Received: from [192.168.17.180] ([89.205.126.37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe537ccf5sm21332055e9.14.2026.05.14.15.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 May 2026 15:46:23 -0700 (PDT) From: =?utf-8?q?=D0=94=D0=B0=D0=BC=D1=98=D0=B0=D0=BD_=D0=93=D0=B5=D0=BE_=D1=80=D0=B3=D0=B8=D0=B5=D0=B2=D1=81=D0=BA=D0=B8?= Date: Fri, 15 May 2026 00:46:00 +0200 Subject: [PATCH] iio: buffer: only set IRQF_ONESHOT when thread handler is provided Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260515-patch-iio-buffer-v1-1-667dac4e55e5@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMyw5AMBBA0V+RWZuk3o9fEYu2powF0pZIxL8rl mdx7wWOLJODNrrA0sGO1yUgiSPQk1xGQh6CIRVpKYokw016PSHzimo3hixmTTHUWjZ5VdYQss2 S4fNbdv1vt6uZtH8/cN8PGLCg2XQAAAA= X-Change-ID: 20260513-patch-iio-buffer-395d8ca94768 To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?=D0=94=D0=B0=D0=BC=D1=98=D0=B0=D0=BD_=D0=93=D0=B5=D0=BE=D1=80=D0=B3=D0=B8=D0=B5=D0=B2=D1=81=D0=BA=D0=B8?= X-Mailer: b4 0.15.2 iio_triggered_buffer_setup_ext() unconditionally passes IRQF_ONESHOT to iio_alloc_pollfunc(), even when the caller provides no thread function. This causes a warning in __setup_irq() when the trigger is later attached: WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x4ee/0x700 IRQF_ONESHOT keeps the IRQ masked until the threaded handler completes, but with no threaded handler this is semantically wrong. Only set the flag when a thread function is actually provided. Assisted-by: GitHub Copilot CLI:claude-opus-4-6 Signed-off-by: Дамјан Георгиевски --- This patch is a safety fix for how the Industrial I/O (IIO) subsystem handles interrupts when setting up a triggered buffer. It changes the flags passed to iio_alloc_pollfunc to ensure that the IRQF_ONESHOT flag is only applied when a threaded interrupt handler actually exists. Full disclosure, I got the warning on my laptop, and got Claude to debug it. The explanation it gave sounds reasonable to me, but I'm not personally familiar with the actual code. --- drivers/iio/buffer/industrialio-triggered-buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c index 9bf75dee7ff8..40eea3a44724 100644 --- a/drivers/iio/buffer/industrialio-triggered-buffer.c +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c @@ -64,7 +64,7 @@ int iio_triggered_buffer_setup_ext(struct iio_dev *indio_dev, indio_dev->pollfunc = iio_alloc_pollfunc(h, thread, - IRQF_ONESHOT, + thread ? IRQF_ONESHOT : 0, indio_dev, "%s_consumer%d", indio_dev->name, --- base-commit: 1d5dcaa3bd65f2e8c9baa14a393d3a2dc5db7524 change-id: 20260513-patch-iio-buffer-395d8ca94768 Best regards, -- Дамјан Георгиевски