From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B46EE341AAE; Thu, 14 May 2026 16:40:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778776812; cv=none; b=jUWAraLc6JXn0js5lzmaTVvRSWEIIoNjaPuczM5qZ+9KnZccAjdq5zjKxhUdv3MmCX3a4cePSR6nFTeHI+PY6A5VdF06jZYlipwJFFu2XpR4V36MTZIL+ZiHtjPNBl5fqZXrZGO2qsZpgHrYsUKqkAPumcsTmP05KONbh5uOGUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778776812; c=relaxed/simple; bh=DZCS7RS/zZX6M7EQpJ9yUp6Bwd0V7zfuy9SAXOfMTts=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kTWYVhaF2lNzlVPlxXlaa0t3MxYASibeUjSW7vYk/lW33xMRyIV/ZcEGDjiPvpHqv97Gec5NsfDtp3IXVHwPtjzBVHTQ1YZfS5r1cF3mznuO1Dm/1OZ77ggrmQKds+0HcwE7dbIZR1KfEwTk38pKgatwBoHoLUsl0TPL2CDUjss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ABQkKMWq; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ABQkKMWq" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778776811; x=1810312811; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DZCS7RS/zZX6M7EQpJ9yUp6Bwd0V7zfuy9SAXOfMTts=; b=ABQkKMWqqOxIXcKkGMn62eOww8WUiCX0F+Kf0xBLMLhKzXAD9PEh2So/ HfEIy16NyHoY4lSWdWcNXMRlIGZMR1Fy2gKDP393BDmwuGpyo7dtCzhNY JcklBcNIGsI04JpijPYAO9cDqX+b8mb+uFNMRM45cAe6Tb9b57DbffBgE eX9Mv/x/turk2zrscGeeDh8XbzeEMVCs4u8cejQ6U+YoR5foiD4+/Jzra mtlpHLeoVJCacmGOK/X5DCUWmxaGBJIbLHgezGovNzMny8LFAWPm22byM D0xmDkFigH0bxrs83me8CLh6/q7aiw6VTXvkWjd9X1p6FYMFYBuVA092x w==; X-CSE-ConnectionGUID: J29AlqcOQT2PTibLrlOwFg== X-CSE-MsgGUID: sBYNmZn4RoiLsp7dE8BTGA== X-IronPort-AV: E=McAfee;i="6800,10657,11786"; a="90417421" X-IronPort-AV: E=Sophos;i="6.23,234,1770624000"; d="scan'208";a="90417421" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2026 09:40:08 -0700 X-CSE-ConnectionGUID: JNzrmP12RKSd5baCukAgog== X-CSE-MsgGUID: iP0ozFZrRt25d7a+eQYB/Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,234,1770624000"; d="scan'208";a="238534954" Received: from lkp-server01.sh.intel.com (HELO dca79079c3eb) ([10.239.97.150]) by orviesa009.jf.intel.com with ESMTP; 14 May 2026 09:40:05 -0700 Received: from kbuild by dca79079c3eb with local (Exim 4.98.2) (envelope-from ) id 1wNZ6Q-000000006mp-3hfi; Thu, 14 May 2026 16:40:02 +0000 Date: Fri, 15 May 2026 00:39:51 +0800 From: kernel test robot To: w15303746062@163.com, jdelvare@suse.com, andi.shyti@kernel.org Cc: oe-kbuild-all@lists.linux.dev, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mingyu Wang <25181214217@stu.xidian.edu.cn> Subject: Re: [PATCH] i2c: i801: fix hardware state machine corruption in error path Message-ID: <202605150012.iDZZ7jFf-lkp@intel.com> References: <20260507114356.247525-1-w15303746062@163.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260507114356.247525-1-w15303746062@163.com> Hi, kernel test robot noticed the following build warnings: [auto build test WARNING on andi-shyti/i2c/i2c-host] [also build test WARNING on linus/master v7.1-rc3 next-20260508] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/w15303746062-163-com/i2c-i801-fix-hardware-state-machine-corruption-in-error-path/20260514-165009 base: https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host patch link: https://lore.kernel.org/r/20260507114356.247525-1-w15303746062%40163.com patch subject: [PATCH] i2c: i801: fix hardware state machine corruption in error path config: powerpc-randconfig-001-20260514 (https://download.01.org/0day-ci/archive/20260515/202605150012.iDZZ7jFf-lkp@intel.com/config) compiler: powerpc-linux-gcc (GCC) 8.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260515/202605150012.iDZZ7jFf-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202605150012.iDZZ7jFf-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/i2c/busses/i2c-i801.c: In function 'i801_access': >> drivers/i2c/busses/i2c-i801.c:934:1: warning: label 'out' defined but not used [-Wunused-label] out: ^~~ vim +/out +934 drivers/i2c/busses/i2c-i801.c ^1da177e4c3f415 Linus Torvalds 2005-04-16 889 97140342e69d479 David Brownell 2008-07-14 890 /* Return negative errno on error. */ ^1da177e4c3f415 Linus Torvalds 2005-04-16 891 static s32 i801_access(struct i2c_adapter *adap, u16 addr, ^1da177e4c3f415 Linus Torvalds 2005-04-16 892 unsigned short flags, char read_write, u8 command, ^1da177e4c3f415 Linus Torvalds 2005-04-16 893 int size, union i2c_smbus_data *data) ^1da177e4c3f415 Linus Torvalds 2005-04-16 894 { a3989dc0b059a51 Heiner Kallweit 2023-02-16 895 int hwpec, ret; 0cd96eb0a74791c David Woodhouse 2010-10-31 896 struct i801_priv *priv = i2c_get_adapdata(adap); ^1da177e4c3f415 Linus Torvalds 2005-04-16 897 cfc69c2e6c699c9 Charles Haithcock 2026-02-27 898 mutex_lock(&priv->acpi_lock); cfc69c2e6c699c9 Charles Haithcock 2026-02-27 899 if (priv->acpi_reserved) { cfc69c2e6c699c9 Charles Haithcock 2026-02-27 900 mutex_unlock(&priv->acpi_lock); a7ae81952cdab56 Mika Westerberg 2016-06-09 901 return -EBUSY; cfc69c2e6c699c9 Charles Haithcock 2026-02-27 902 } a7ae81952cdab56 Mika Westerberg 2016-06-09 903 a7401ca5596e246 Jarkko Nikula 2016-03-10 904 pm_runtime_get_sync(&priv->pci_dev->dev); a7401ca5596e246 Jarkko Nikula 2016-03-10 905 1f760b87e54cf56 Heiner Kallweit 2023-02-16 906 ret = i801_check_pre(priv); 1f760b87e54cf56 Heiner Kallweit 2023-02-16 907 if (ret) e67d702846114f6 Mingyu Wang 2026-05-07 908 goto out_err; 1f760b87e54cf56 Heiner Kallweit 2023-02-16 909 0cd96eb0a74791c David Woodhouse 2010-10-31 910 hwpec = (priv->features & FEATURE_SMBUS_PEC) && (flags & I2C_CLIENT_PEC) e8aac4a9b417643 Jean Delvare 2005-10-26 911 && size != I2C_SMBUS_QUICK e8aac4a9b417643 Jean Delvare 2005-10-26 912 && size != I2C_SMBUS_I2C_BLOCK_DATA; ^1da177e4c3f415 Linus Torvalds 2005-04-16 913 ca8b9e32a11a7cb Oleg Ryjkov 2007-07-12 914 if (hwpec) /* enable/disable hardware PEC */ 4a3f77ea77013d8 Heiner Kallweit 2025-03-12 915 iowrite8(ioread8(SMBAUXCTL(priv)) | SMBAUXCTL_CRC, SMBAUXCTL(priv)); ca8b9e32a11a7cb Oleg Ryjkov 2007-07-12 916 else 4a3f77ea77013d8 Heiner Kallweit 2025-03-12 917 iowrite8(ioread8(SMBAUXCTL(priv)) & (~SMBAUXCTL_CRC), 0cd96eb0a74791c David Woodhouse 2010-10-31 918 SMBAUXCTL(priv)); e8aac4a9b417643 Jean Delvare 2005-10-26 919 6ff9d46cd36fbd0 Heiner Kallweit 2024-02-02 920 if (size == I2C_SMBUS_BLOCK_DATA || size == I2C_SMBUS_BLOCK_PROC_CALL) 6ff9d46cd36fbd0 Heiner Kallweit 2024-02-02 921 ret = i801_smbus_block_transaction(priv, data, addr, command, read_write, size); 6ff9d46cd36fbd0 Heiner Kallweit 2024-02-02 922 else if (size == I2C_SMBUS_I2C_BLOCK_DATA) 6ff9d46cd36fbd0 Heiner Kallweit 2024-02-02 923 ret = i801_i2c_block_transaction(priv, data, addr, command, read_write, size); 7edcb9abb594a8f Oleg Ryjkov 2007-07-12 924 else 24592482d235107 Heiner Kallweit 2023-02-16 925 ret = i801_simple_transaction(priv, data, addr, command, read_write, size); ^1da177e4c3f415 Linus Torvalds 2005-04-16 926 de461a2607c69c4 Heiner Kallweit 2023-02-16 927 ret = i801_check_post(priv, ret); de461a2607c69c4 Heiner Kallweit 2023-02-16 928 c79cfbaccac0ef8 Jean Delvare 2006-04-20 929 /* Some BIOSes don't like it when PEC is enabled at reboot or resume 63fd342fd121c3e Heiner Kallweit 2023-02-16 930 * time, so we forcibly disable it after every transaction. 63fd342fd121c3e Heiner Kallweit 2023-02-16 931 */ 63fd342fd121c3e Heiner Kallweit 2023-02-16 932 if (hwpec) 4a3f77ea77013d8 Heiner Kallweit 2025-03-12 933 iowrite8(ioread8(SMBAUXCTL(priv)) & ~SMBAUXCTL_CRC, SMBAUXCTL(priv)); 1f760b87e54cf56 Heiner Kallweit 2023-02-16 @934 out: 4f7275fc7e570df Heiner Kallweit 2021-12-04 935 /* 4f7275fc7e570df Heiner Kallweit 2021-12-04 936 * Unlock the SMBus device for use by BIOS/ACPI, 4f7275fc7e570df Heiner Kallweit 2021-12-04 937 * and clear status flags if not done already. 4f7275fc7e570df Heiner Kallweit 2021-12-04 938 */ 4a3f77ea77013d8 Heiner Kallweit 2025-03-12 939 iowrite8(SMBHSTSTS_INUSE_STS | STATUS_FLAGS, SMBHSTSTS(priv)); 065b6211a87746e Heiner Kallweit 2021-06-06 940 e67d702846114f6 Mingyu Wang 2026-05-07 941 out_err: a7401ca5596e246 Jarkko Nikula 2016-03-10 942 pm_runtime_put_autosuspend(&priv->pci_dev->dev); cfc69c2e6c699c9 Charles Haithcock 2026-02-27 943 mutex_unlock(&priv->acpi_lock); a7401ca5596e246 Jarkko Nikula 2016-03-10 944 return ret; ^1da177e4c3f415 Linus Torvalds 2005-04-16 945 } ^1da177e4c3f415 Linus Torvalds 2005-04-16 946 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki