From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-172.mta1.migadu.com (out-172.mta1.migadu.com [95.215.58.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 621062DEA7B for ; Fri, 15 May 2026 01:57:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778810270; cv=none; b=rxbXx1zsC1H//W/aRIjC2AHSBt3W4rTiLrqhOQIEwffjk4Ea40RA0X9D1SplrQDMpsvYXgo7Ve7/T2rmdwksmSgt7YvQKvzsqjm+Znw9gbF5DxbDrzo0TO2RyBkblVF+6YYlUQdWoVUvybGhYoBT+8IhA9Hw3suMAg0rjf5DVZQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778810270; c=relaxed/simple; bh=e7s/p1LiEahLGuHb60aWGdfK6J5CN7Q2yqtIiuuwBT0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-type; b=EWoRN8qgLlVzTbTT64NPQIWLKCTdMWL1ovIDYHUwEJinXV9p2ZGVSjdLtW8KWp/b7hzucaDS4d406/4py1ego6ZZ733jA8/fjblMgqY8jkPQZwvRAbcdVj0wVOclgciBY5X4V0k1T6zwcNnsiXy0Pc96dv5L2ghh3aO1HmButXE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BzWog3VZ; arc=none smtp.client-ip=95.215.58.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BzWog3VZ" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778810266; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=yUT+3E2sed5W08N7+AqBJgGJHLA+jsUduhXtueyYFlM=; b=BzWog3VZraCpxCy7iqr0T3VPijOXg+cx5QKGfz9cBdjut2/UJO5t3Er9arNG258boa3G9o KHgCPUnve/FTapPpB4E7Cky0CbrisrZEJU95ZW8Gy/qSY1qygURvefOUj944oVDFitQ3DA RCBWIvqwfR6hH2TKvqGSXH0kGK3z6ns= From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, chrisl@kernel.org, usama.arif@linux.dev, baohua@kernel.org, kasong@tencent.com, nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com, hch@infradead.org, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH v7 0/3] [PATCH v7 0/3] mm/swap: use swap_ops to register swap device's methods Date: Fri, 15 May 2026 09:57:34 +0800 Message-ID: <20260515015737.890994-1-baoquan.he@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This can simplify the code logic and benefit any new type of swap device added later. Patch 2 renames the page_io functions to a consistent swap___ naming convention. Patch 3 fixes a leaky abstraction where FS swap unplug bypassed swap_ops, adding an .unplug callback and dispatcher. Changlog: === v7: - Drop the old patch 1 "[PATCH v6 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c" as Christoph suggested. - Add the .unplug callback to address Christoph's review about the leaky abstraction. - Minor cleanups and fixes per review feedback. -v6: - Fix a code bug Kairui found out when reviewing patch in mm/swapfile.c in patch 2/3. Has fixed it by moving it to appropriate place and add comment to explain. -v5: - Change the return value of init_swap_ops() as -EINVAL as per Chris's suggestion and adjust its invocation in swapon() accordingly. - Add Chris and Usama's Ack tags. -v4: - Fix a typo opeations -> operations - Fix a code bug inside init_swap_ops(). I was taking a change at the time, thought the change is trivial, so I only compiled but didn't run kernel to test in v3. Now fix it and test passed. Thanaks to Usama for catching the above two issues. -v3: - Rename setup_swap_ops() to init_swap_ops() which reflect the function behaviour a little better - Check if sis->ops, sis->ops->read_folio and sis->ops->write_folio is NULL in init_swap_ops(), but not spread them where they are called. And once the checking failed, fail swapon immediately. This is suggested by Chris. - Call init_swap_ops() before setup_swap_extents() invocation. This doesn't harm anything and can benefit later adding sis->ops->swap_activate method. -v2: - Lots of cleanup for patch 2/3: renaming, moving data structures, and using const properly - Collected tags from Kairui, Nhat and Barry -v1: - https://lore.kernel.org/linux-mm/20260302104016.163542-1-bhe@redhat.com/ Baoquan He (3): mm/swap: use swap_ops to register swap device's methods mm/page_io.c: rename page_io functions to consistent naming mm/swap: add unplug callback to swap_ops to fix leaky abstraction include/linux/swap.h | 3 ++ mm/page_io.c | 115 ++++++++++++++++++++++++++----------------- mm/swap.h | 11 ++++- mm/swapfile.c | 9 ++++ mm/zswap.c | 2 +- 5 files changed, 94 insertions(+), 46 deletions(-) -- 2.52.0