From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4EF343E0257 for ; Fri, 15 May 2026 07:25:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778829945; cv=none; b=g+IGSb8l6jGwMUMZ7Zh5lM2xZrx/lraTZ0VaSC0dfnVZaTsOsQNTT0fnkj32gK+QbYrFzku68KBLndyUnVkmulB/Bugife/oqTJBw3tqRRoQrNTuR2rzoWlMEQ7W4U7RCbXCpZh7AevAXm9hQA3c0jhHjDzwmY319rBfvXxFreU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778829945; c=relaxed/simple; bh=V78qE48UZLs/XEakcgJEAYoYr9qaH6PyXDTJCVi3D94=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=sBtcv32Rs9EQ01N5hr1Mm5JpnVW88bkAYkQ/7a5m/hD/3S+7IQxYVW8tKce9FbcDMhkrUqWivuVfMoXK8RRCkU8E8Z2AG06VkJXWQn3zhah3PNTrYALRKPkU5Jgh/1kz0A95E5VA7aNWvqUl7c5fyKsRqZaItYrrzDULPLy3lac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AZUJdNtN; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AZUJdNtN" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2bcf48850c4so34694215ad.1 for ; Fri, 15 May 2026 00:25:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778829942; x=1779434742; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ktiNCFovlAzqzGJ/+v1M6lVl5fNaz808WBhWl9izIqI=; b=AZUJdNtN1HEMa8t6IxEO6AXVRuOi3i6o0qgnY+T0cqgRe3VhrxmM3z0kPOog8Wrukp uFjs0x+IIstY05rVGWZp3GJ8sJpZgWIp7qtIHyTs/5jSCZ250b0Bk9rtEhF6LIDI/WRO a+3+0L76kQ456ooWszvetQzT8wYBziOao6u/83CX33gdiv5W7GHHd71J+vgKpTV8olVj I8RNAkSBVwJ/N1CUHFiXY1kA9/w3/5WKmxZMkvB/jnA5QSwSlXShNgVUFnkLsdz0e58T P/pF/yDcFRC5KI1SrxQVRLSKnjHZVg/ZYabNPOqG4UK8O/h+0lfx7qOl48N1sHtLrzIE Iu3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778829942; x=1779434742; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ktiNCFovlAzqzGJ/+v1M6lVl5fNaz808WBhWl9izIqI=; b=HFkBna91rQemztspU38K32RXpr+VBVZmTCsD9b6eAppRmAnDYuk+Xeg6RtYMnswfLU ZiYyd/wnGub28GPGkn05RRgwLsoUqg92wocyQ8MnJQT4pua53Zfb08AGFl6a4cuAEkbK O8foXEuqseDy4ZsAZGELNsa5+9C4MhpRtA+xKq6HK+IowM6usBFCAE+kt3DCxLPVyaeX GzTgCt5r9WlAQKOwnEL+KrsFZWhUPQJMs1BNZDUL/xT68MWiPx93uNfj1dNalEJC4KVo bts8eSvjwZ2j+JP4gn8CYL15aemDHvonk6p4VBa/CItuvue1pBfwgvB+EevSU0OJBGGM IWhg== X-Forwarded-Encrypted: i=1; AFNElJ/C7XU2HqP3iQQzNhIEmFlyhLnG5lLN49rD2WLWCIL7/nw/7AmWv348ee4fJK5cRY/BaConbbonznECGDQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwVqBqxH5xzfxoprFu2wvHi2maqzvqvHSHVljnHjygEBVTR/dn7 YOJ3immUCBs/tLdBstzB1aM2lyO2CSj4hJabnAxeKhPBO5cYcmiMgV6ogFEDDw== X-Gm-Gg: Acq92OH7tTJ53V12xLPml1sOfo0c+h9EuscPd+MYc4r4nDQ/LyhHbtbYxRqabvSROdV nGn3w5BReADY+Izgo8y3nimS5HCswce5enafx0QahAbY3wpDM+/+g8+MhKnKlLsjqAP6kwCqGpI WmBWj5xc8k81VoNmMCWO+hr5s3moqT6e6h+rX0rIvp3QFPPTH4KFGFQT8kN0P3GLEZyiGgYdOiQ /7gisC02HBSkHcdsr7K4y8b00CjV6SXr1n20PmFjF2XA/Jr9fv3DJzfOmrauyOVKSusGajbFmKU QY4QeHI1WRlZzWQFQqtsEkNZawVNQQRbeKf/LTmFcdiPXH8CcayF/enu3XAXGgTt5NzSE16WbTN TgczBppQf484jzbj6ChwdpVbaUj7fawXxgcv5/MGBEeeKiZaY5qDu/JD26QbHsLZw8wisu8O9BE 5wongkg5sOGTbPPdSx5obIkaC6pFUiDLFjlaFxxmRH7sq7t3n1Ne0eKXJoV9vJwf1o8iIQRB6Vo syYC+IzppTLw1GI6Yr1q4lQQPOTvhUbdT48ZwvFa9f5YGKCeamb3Bl7gDTjKHyM1+A= X-Received: by 2002:a17:903:40d2:b0:2b4:5f69:715d with SMTP id d9443c01a7336-2bd7e8f07f3mr31799295ad.25.1778829942504; Fri, 15 May 2026 00:25:42 -0700 (PDT) Received: from ip-10-1-46-91.ap-northeast-1.compute.internal (ec2-176-32-72-196.ap-northeast-1.compute.amazonaws.com. [176.32.72.196]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5d12372bsm62501565ad.75.2026.05.15.00.25.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 00:25:42 -0700 (PDT) From: Daiki Harada To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mauro Carvalho Chehab , Daiki Harada , Kees Cook , syzbot+b1de0d5fd8a15fac11aa@syzkaller.appspotmail.com Subject: [PATCH v2] media: msi2500: fix memory leak in msi2500_probe error path Date: Fri, 15 May 2026 07:25:34 +0000 Message-ID: <20260515072534.389995-1-daiky0325@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit When video_register_device() fails in msi2500_probe(), the error path jumps to err_unregister_v4l2_dev, which skips the call to v4l2_ctrl_handler_free(). This leaks memory allocated by v4l2_ctrl_handler_init() and v4l2_ctrl_add_handler(). This bug was introduced when commit 2e68f841a5d1 ("[media] msi3101: use msi001 tuner driver") reordered the cleanup labels, placing err_free_controls above err_unregister_v4l2_dev, but did not update the goto target in the video_register_device() failure path. Fix this by jumping to err_free_controls instead, which properly frees the control handler before unregistering the v4l2 device. Reported-by: syzbot+b1de0d5fd8a15fac11aa@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=b1de0d5fd8a15fac11aa Fixes: 2e68f841a5d1 ("[media] msi3101: use msi001 tuner driver") Tested-by: syzbot+b1de0d5fd8a15fac11aa@syzkaller.appspotmail.com Signed-off-by: Daiki Harada --- drivers/media/usb/msi2500/msi2500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/msi2500/msi2500.c b/drivers/media/usb/msi2500/msi2500.c index 1ff98956b680..76e1f2bfab0c 100644 --- a/drivers/media/usb/msi2500/msi2500.c +++ b/drivers/media/usb/msi2500/msi2500.c @@ -1265,7 +1265,7 @@ static int msi2500_probe(struct usb_interface *intf, if (ret) { dev_err(dev->dev, "Failed to register as video device (%d)\n", ret); - goto err_unregister_v4l2_dev; + goto err_free_controls; } dev_info(dev->dev, "Registered as %s\n", video_device_node_name(&dev->vdev)); -- 2.54.0