From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A1263CFF65 for ; Fri, 15 May 2026 13:33:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778852000; cv=none; b=CL59VqfrP0ETRa0dSsbsieWpkC1IIRJ36Bw+jaj2OwU0GoVulNdnwfypFRo4fp3Zg5PEHLyrLtMHAi89eT6lM5T6+rUsqLFOWVmSgoAsE+Cb78f7wVkEt1ehW5jFXz9uPdZx6qal5kKfSdcNe7acLPIZhB3kJOCGjcgX5AYslyI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778852000; c=relaxed/simple; bh=3TBAhU6hGBxpskdX1Eg3IPTIlGQxreDR2zG0IrhXS+M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=W2U6bIfJOUJCEhqQHzwxbpOcTMHeQ2IGu+5EYaux74cCJ/B88+Mp/L7zJlI2xjufCp3d7SrP/HLH8D35EL+fqAc7MC8zHTi8hj3/QAS6oH8UjldMho4MFG2gNbYL2ASfX/vSG9zy7ALycf6JFzbhMiY+24m/wL1a8Nj24ZkAs64= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=ZW+U2i8J; arc=none smtp.client-ip=209.85.160.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="ZW+U2i8J" Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-512f750d4b2so73585211cf.1 for ; Fri, 15 May 2026 06:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1778851995; x=1779456795; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kMBTbyF/T6Vu//EwZXm52sbAHBRdnqX86jxiszQbrCA=; b=ZW+U2i8JYD2K+dcp3VUtrbiVOpVcMdQk2Fa3mOFXt+myhPnKtT8Jks3Ho/vPWXx+w0 zoG/h46mq5hwLDIbBwTfk9s83vjF2UpmLhn3IrtkbBCPwjPlizLMuCvgAf+LcXTXiA1D GZGqpJMPP17ePRwBZMdc6iyrsCI0rEPtvU5w6r7x2DkV8Rza5vni6UprFjOKbNJhaYrQ AjtKua2l/1Jr4AymvLBOSlroxojcinM/BQe0ncpJi+p9I8+c4NBtnoa67sTdHWl1lym2 dCO9zUt+sj9/5Hos3Od9vZdaK6DdHgqPYZPYPxK5DUnIRYjJGBIVkM5wdPLQsbGSh9Oc eN7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778851995; x=1779456795; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kMBTbyF/T6Vu//EwZXm52sbAHBRdnqX86jxiszQbrCA=; b=YeiGnj7g/yD+0gJdCSYV0A2kTEbrMG0zToXVRQksZDUwqY/n4L8sPae/pjuiPy2cPb FBkfY75U5MYy550bZzbC+Yo10DRMuM5Jt08BVkZBkApWCBUESmJDuR7/BhfGqjgGA2Hs 2corLK2hLxfa+bLOJKFa/iy8/2kxkvfdyqy7isHkt8C8Sqkgo1sDVwfkclby36VeTQaQ EVlF1OLKzr5UqqTlg9j67d7v7p9eNrlVtmbGSVnfhDzVe91C6SA8pG/lQTaDxq4H8oJv bvs5dHJ2WAe+cDflOhumn0NElB7CTTDbsgleiLgPbZNDRG5l9UhjpJhWAiB3Sw/6M1Oy efRw== X-Forwarded-Encrypted: i=1; AFNElJ9cZmY3y0MZRvUSwcVyE17PhYqigm+yZepryMP/qOUlab+2B6RP/cmE8sA1svHyVspJ9dWb4BusPoNgga4=@vger.kernel.org X-Gm-Message-State: AOJu0YxDjrBW1Bfrd07779eXVlSrrHXhLOLkG9bzNfV1XDnnMDu+2gOX NQbuB3G4xuJQSoVB3M9wK/udzzU9LpqrI+yNBirYy0fiYHbMaayne+ecAEPa1yTvxAE= X-Gm-Gg: Acq92OEAOhw6HYsIPBD//mc63qSGBV8tmX3oYOA3Y8ivnfu8ffjyQzNyCqtMWvtly+L aWgQx/UbLT1IGYg1m2fRPDVQlk8HBCSj65+NxzYAqxX7o50jfV63u7TRla7JW2MHhLHaSLLfTRh vGF02D/8HyQsKP0MHDCb+ay3d/XM3/BQsjE+okg0QUkCyGJWz12hEol5ViewX7n/0SaLxGeblfM WFwvFyj1U/s/1xLrLHZwGSu5e3UyLT9UET2EMOOvbq+jltUOO6i2Q8hAVzn48sDRCrsPXr5ljWp TmOqwhv3NY3GizjoeinZ6/BwCMXC5RvWByMHY66p3jRXnGV0hyNqpwiefseCgQxnPNsswFI9Nmu RlRGGi7Mt5epvIG0WXRXAEBBk9kb1FYwbht38PFJ5oMTMY+qRuoa8Y8pu19K3EjDgdIMT0XR8VV BHj1YhWkwwu7dgwKY+aMdlMP4jMRoUuKJ/XfhXEyWvL1xVvyPtHJNYN6fiTP2f55bqGYSqJ+9fO Eq0TsP1GH6+htdm X-Received: by 2002:a05:622a:5408:b0:50e:6183:beea with SMTP id d75a77b69052e-5165a0df42fmr56075141cf.23.1778851995075; Fri, 15 May 2026 06:33:15 -0700 (PDT) Received: from ziepe.ca (crbknf0213w-47-54-130-67.pppoe-dynamic.high-speed.nl.bellaliant.net. [47.54.130.67]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5164568a275sm44172361cf.5.2026.05.15.06.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 06:33:14 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wNsfB-00000007Q3c-3bJa; Fri, 15 May 2026 10:33:13 -0300 Date: Fri, 15 May 2026 10:33:13 -0300 From: Jason Gunthorpe To: Mostafa Saleh Cc: iommu@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, will@kernel.org, joro@8bytes.org Subject: Re: [PATCH 3/3] iommu/io-pgtable-arm: Use address conversion consistently Message-ID: <20260515133313.GE7702@ziepe.ca> References: <20260513215203.3852661-1-smostafa@google.com> <20260513215203.3852661-4-smostafa@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260513215203.3852661-4-smostafa@google.com> On Wed, May 13, 2026 at 09:52:03PM +0000, Mostafa Saleh wrote: > Use consistent address conversions in the driver: > - virt_to_phys(): For all virtual to physical address conversion, > convert __pa users as we don’t need to rely on it type casting. > - phys_to_virt(): For all physical to virtual address conversion, > similarly, convert __va users. > > That changes nothing at all. However, it will be useful when > compiling this file for the KVM hypervisor as it can cleanly > replace virt_to_phys/phys_to_virt > > Signed-off-by: Mostafa Saleh > --- > drivers/iommu/io-pgtable-arm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Jason Gunthorpe Jason