From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 76A79405C5F; Fri, 15 May 2026 22:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778885151; cv=none; b=CU6WNkv6HakS5I77St0FUDYKCAAROiAZzuu9tC4CbRrBj+ODvyxbbVxwbKgAznjaXM1aO1fvWQgntLETsRfZHCvy522KGU0qo5Xeq2DZn+y9hBOqL1tPryzPL1cw5K0s9roxemwpm/SFSPxaScitbJZnc+8Hbiyi6vcEFxkwLII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778885151; c=relaxed/simple; bh=uIau35s5bIEmw6EC+X8vEmauWXOWouZDyj8O9Ysx4Hk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gfs35Bu/oFSau7RDUq/KiZMz7CEh841CyWh552TPe86QI+N/862zl35O87JRlgW6DD+rjvJWQrgoG01WW8Di97+EpGxZfewE5SU0hk88Uyt2q1kgmoDtSvByEgZL4lsjj7eplR2rKGTeUsizbR87XCj0dxs5ibDtqQadhxPVSEI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YD35Xbkd; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YD35Xbkd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C7ADC2BCB0; Fri, 15 May 2026 22:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778885151; bh=uIau35s5bIEmw6EC+X8vEmauWXOWouZDyj8O9Ysx4Hk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YD35XbkdraLWjjJF2eEmG679oOXznOFhFTUbO22eWOAv+RcE5jaOG88AVtGZOTRMP IhCEyRF9n/eGWG+qyLbiD0vYaR7gMD5pEJSeUmt1O+iOsUYbnR8gBcOd1Stg1YSHmX yXRFgoyiaN9FNSW9lkkzqTDFxtCsFfry5wd1kVoD4vmuoFTgCDfkOk5vGYCj8V9Ht9 mlE4X8XB3A/vrs4eyC5cNlE+FO2XSou29VPAn5fK5SLMop6FAPudTzfpUytVaRUhTn Ohf8V7fQu3HNerYfEzmlmEN81nbzdExymFP3urjmBU6fjeihQT8UK9JT9HnIAykGqk hHuzNg0wjETRQ== Date: Fri, 15 May 2026 15:45:49 -0700 From: Jakub Kicinski To: "Frank Wunderlich" Cc: "Mason Chang" , "AngeloGioacchino Del Regno" , netdev@vger.kernel.org, "Russell King" , linux-kernel@vger.kernel.org, "Andrew Lunn" , "Eric Dumazet" , linux-mediatek@lists.infradead.org, "Daniel Golle" , "Matthias Brugger" , "Paolo Abeni" , "Lorenzo Bianconi" , "David S. Miller" , linux-arm-kernel@lists.infradead.org, "Felix Fietkau" , "Frank Wunderlich" Subject: Re: [net-next v8 2/3] net: ethernet: mtk_eth_soc: Add RSS support Message-ID: <20260515154549.307a61cd@kernel.org> In-Reply-To: <935a73a6e458b2d4fed2e59192e725483ca62126@linux.dev> References: <20260509190938.169290-1-linux@fw-web.de> <20260509190938.169290-3-linux@fw-web.de> <20260513185625.48e69837@kernel.org> <935a73a6e458b2d4fed2e59192e725483ca62126@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 15 May 2026 11:13:05 +0000 Frank Wunderlich wrote: > > > We can adjust SMP affinity with the following command: > > > echo [CPU bitmap num] > /proc/irq/[virtual IRQ ID]/smp_affinity, > > > with interrupts evenly assigned to 4 CPUs, we were able to measure > > > an RX throughput of 7.3Gbps using iperf3 on the MT7988. Further > > > optimizations will be carried out in the future. > > > > > Would be great to split this up a little more for ease of review. > > you mean splitting the code into more separate patches or the commit description? The code, seemed like it should at the very least be split into multi-queue/napi support (mostly driver changes) vs RSS programming and config.