The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Adrian Hunter <adrian.hunter@intel.com>
To: alexandre.belloni@bootlin.com
Cc: Frank.Li@nxp.com, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V4 10/17] i3c: mipi-i3c-hci: Factor out hci_dma_abort()
Date: Fri, 15 May 2026 19:26:14 +0300	[thread overview]
Message-ID: <20260515162621.57719-11-adrian.hunter@intel.com> (raw)
In-Reply-To: <20260515162621.57719-1-adrian.hunter@intel.com>

Factor out hci_dma_abort() from hci_dma_dequeue_xfer() in preparation
for further changes.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
---


Changes in V4:

	New patch


 drivers/i3c/master/mipi-i3c-hci/dma.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
index 906de7dbfdb5..f2d33068b8df 100644
--- a/drivers/i3c/master/mipi-i3c-hci/dma.c
+++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
@@ -597,6 +597,13 @@ static void hci_dma_xfer_done(struct i3c_hci *hci, struct hci_rh_data *rh)
 	rh_reg_write(RING_OPERATION1, op1_val);
 }
 
+static void hci_dma_abort(struct hci_rh_data *rh)
+{
+	reinit_completion(&rh->op_done);
+	rh_reg_write(RING_CONTROL, rh_reg_read(RING_CONTROL) | RING_CTRL_ABORT);
+	wait_for_completion_timeout(&rh->op_done, HZ);
+}
+
 static void hci_dma_unblock_enqueue(struct i3c_hci *hci)
 {
 	if (hci->enqueue_blocked) {
@@ -623,9 +630,7 @@ static bool hci_dma_dequeue_xfer(struct i3c_hci *hci,
 		hci->enqueue_blocked = true;
 		spin_unlock_irq(&hci->lock);
 		/* stop the ring */
-		reinit_completion(&rh->op_done);
-		rh_reg_write(RING_CONTROL, rh_reg_read(RING_CONTROL) | RING_CTRL_ABORT);
-		wait_for_completion_timeout(&rh->op_done, HZ);
+		hci_dma_abort(rh);
 		spin_lock_irq(&hci->lock);
 		ring_status = rh_reg_read(RING_STATUS);
 		if (ring_status & RING_STATUS_RUNNING) {
-- 
2.51.0


  parent reply	other threads:[~2026-05-15 16:26 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 16:26 [PATCH V4 00/17] i3c: mipi-i3c-hci: DMA abort, recovery and related improvements Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 01/17] i3c: mipi-i3c-hci: Fix suspend behavior when bus disable falls back to software reset Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 02/17] i3c: mipi-i3c-hci: Preserve RUN bit when aborting DMA ring Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 03/17] i3c: mipi-i3c-hci: Prevent DMA enqueue while ring is aborting or in error Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 04/17] i3c: mipi-i3c-hci: Wait for DMA ring restart to complete Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 05/17] i3c: mipi-i3c-hci: Move hci_dma_xfer_done() definition Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 06/17] i3c: mipi-i3c-hci: Call hci_dma_xfer_done() from dequeue path Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 07/17] i3c: mipi-i3c-hci: Complete transfer lists immediately on error Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 08/17] i3c: mipi-i3c-hci: Avoid restarting DMA ring after aborting wrong transfer Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 09/17] i3c: mipi-i3c-hci: Add DMA ring abort/reset quirk for Intel controllers Adrian Hunter
2026-05-15 16:26 ` Adrian Hunter [this message]
2026-05-15 16:26 ` [PATCH V4 11/17] i3c: mipi-i3c-hci: Add DMA ring abort " Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 12/17] i3c: mipi-i3c-hci: Factor out reset-and-restore helper Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 13/17] i3c: mipi-i3c-hci: Add DMA-mode recovery for internal controller errors Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 14/17] i3c: mipi-i3c-hci: Wait for NoOp commands to complete Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 15/17] i3c: mipi-i3c-hci: Base timeouts on actual transfer start time Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 16/17] i3c: mipi-i3c-hci: Consolidate DMA ring allocation Adrian Hunter
2026-05-15 16:26 ` [PATCH V4 17/17] i3c: mipi-i3c-hci: Increase DMA transfer ring size to maximum Adrian Hunter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260515162621.57719-11-adrian.hunter@intel.com \
    --to=adrian.hunter@intel.com \
    --cc=Frank.Li@nxp.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox