From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 536423E834B for ; Fri, 15 May 2026 17:40:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778866839; cv=none; b=eHuhCVAJKRhXbrZN1Jqt/Yg5e8gREceX2cjr9H8U+60Igvw1oMBR8kQkblm75QJP1cUw2Qe/H2tI+JA+cx9/VMzdOhQFQmYKVtPuBBnOphxna1LWQoaafYVkpVYTd5xgGapR0sPyW+zqtww8Wswqq8CGHt9141Ah7Qvy/L3y7Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778866839; c=relaxed/simple; bh=vUNSUQJ2vSW/5TNiCAc3VZ2D/GxuOb+QHqUWQE4SluI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DvMnwjKOA2SX+vjFCkW7C28wPbwDiRXN0UrHXYgh3kEuEnIzUhZgPFFn8seJEZ4NrFRd66ZBbxkMSir96BurqDMR3ZeBEsuez6bHXnKmtkzxY6BqSYOS4OMBDnj0RxfivxnBeSreZx1/XWBUqzu/fIDsPjLRhc2NcxLajqOtsLo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dB16fdow; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dB16fdow" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82748257f5fso872795b3a.1 for ; Fri, 15 May 2026 10:40:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778866837; x=1779471637; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oD4ghlSzEM0XpzQLkuHFPVSH8xE4TvBhIbAIWqVBMCw=; b=dB16fdowP5S8zvRHJO/bOZdlfhcc0jYXycbFrUt8MuzaTZRc8Escv3p4eQZA+o/lQc kV02zMXRMOW+E6Y/Q5nTOM1tUWM7csU+mqqIM3QedzmF8XVPn3DX6jFsY+/PQu4RHJJ2 7BEx2pCOT76mIoLtga5wSApk+6iBzkvG94H1PXuFUowhkYf9wz84WrV+DV2d8BA90UWl IJtE8bbD78mP7GDH6YCk7xJWyEXpwKNcaJBj7IK3TWvv54yyNn1CXI5Fi4Fy5IZVASEB O19Di4zq5AHgfohoevHT0HlBeWY9P0sYjBH8R1JsHvfLIAO4YoaFTQ2mWqAlgbxrm7ZG YI1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778866837; x=1779471637; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oD4ghlSzEM0XpzQLkuHFPVSH8xE4TvBhIbAIWqVBMCw=; b=iYpuPeeVNaDFsuEC9leW8vP9/nOYmjr0hH0lsQ54QRWkRw0ST445R1urQSczEghRyf HthePC/Atwg0lPPiENUK+buD/Gw8X5yS8JfnmgxAz/xxJ+POMEAj+BqlSnMnRhm4Ar/5 uGyQH865shQIXM0cFQkigFPwVqadPhvefsF5We+urL291M1QSlQRL8qajlGCwGta7O3q pEAfz7GZ9tH/2U9HRHeU4zQJ3Z7uIyqzv6GLkbZQPq+Egt0GdwS0g3Fr7nBa/Is1i/IX vLAYDx70Tu7SDADDMQ+6zOsG5lcBSNLwiGkmvU4e1SATfVwm2n1Udcrjh/cNh91Q68nA HnqQ== X-Forwarded-Encrypted: i=1; AFNElJ8jg0TpBi1Vu74m+En2IZjZnwlyJ2C48AKlaxaUP5upT81ctajs179/ElAgtvzVbiX83dh/JZcvY3pKQ7Y=@vger.kernel.org X-Gm-Message-State: AOJu0Yzd/oPKPcjO4OTzPNIwVDm7DT8oaFmGdgY5Wv3cPMUW2UDvJV6+ HPPVo0c8/rpb5y056zctgRaA8fOW17s7btv30o80pFWkqGAXaVeXCs2P X-Gm-Gg: Acq92OG5OtyCPbypHSWldMQizTNTPnqsfYtXCPTuqcoWtBo/Lz1oeMUMziFMKs7uat0 eqx2yvLIe2nxqgfEl2Ucya+M4xl/NewBr3miCFXdpS4I6xCUjllAAxTKtxX9tESCnZB9go2SbFw tPbxJx3LvPYhWVYYguH41sIWoMWdEW5nShtXdPW1Q86VyAmbytMfN5jufqRyA+WljQUV453YUZ3 78/k4CQwLDb3jsAcr4hff58z9use5JbJ3hsNJOrXSih4xTkMG6TdC7+7YycGyfrKmL9wlYtFYVN 5p2lFE0NndpbJOfj2e0bohbZ2oLT6gBjI1IKISCw0IEGq5TEESD4OdqpeWyBuqQxXf1btKWU8rP sVFnKZWTF0N9TL5kH6Ze0v/4IEvaajPfv0+5bPS39s3wycKVD/aJGIf4gSUcu5289ppLk1O286C /NxNq6pqY+N7zFQa5hBgFn7Xatfepog3JSrnU52yuXnt9F8Vhm X-Received: by 2002:a05:6a00:ace:b0:829:6f7d:3086 with SMTP id d2e1a72fcca58-83f33b62df1mr4199988b3a.11.1778866837486; Fri, 15 May 2026 10:40:37 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f2875f0fbsm5579034b3a.57.2026.05.15.10.40.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 10:40:37 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org, kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz, kyungmin.park@samsung.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 03/12] iio: ssp_sensors: refactor transfer logic into helper Date: Fri, 15 May 2026 23:10:08 +0530 Message-Id: <20260515174017.3962168-4-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260515174017.3962168-1-sanjayembedded@gmail.com> References: <20260515174017.3962168-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Extract the core transfer logic under comm_lock into a new __ssp_do_transfer() helper. The change is preparatory for converting mutex usage to guard() helpers in subsequent patches. This restructuring simplifies ssp_do_transfer() and makes the transfer flow easier to follow. No functional change intended. Signed-off-by: Sanjay Chitroda --- drivers/iio/common/ssp_sensors/ssp_spi.c | 50 +++++++++++++++--------- 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_spi.c b/drivers/iio/common/ssp_sensors/ssp_spi.c index 3d377a482161..ebcda6de56c4 100644 --- a/drivers/iio/common/ssp_sensors/ssp_spi.c +++ b/drivers/iio/common/ssp_sensors/ssp_spi.c @@ -196,20 +196,13 @@ static inline void ssp_pending_del(struct ssp_data *data, struct ssp_msg *msg, mutex_unlock(&data->pending_lock); } -static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, - struct completion *done, int timeout) +static int __ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, + bool no_irq) { int status; - /* - * check if this is a short one way message or the whole transfer has - * second part after an interrupt - */ - const bool use_no_irq = msg->length == 0; - if (data->shut_down) - return -EPERM; - - msg->done = done; + /* msg->done must be initialized by caller */ + WARN_ON(!msg->done); mutex_lock(&data->comm_lock); @@ -224,15 +217,41 @@ static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, goto _error_locked; } - ssp_pending_add(data, msg, use_no_irq); + ssp_pending_add(data, msg, no_irq); status = ssp_check_lines(data, true); if (status < 0) { - ssp_pending_del(data, msg, use_no_irq); + ssp_pending_del(data, msg, no_irq); goto _error_locked; } mutex_unlock(&data->comm_lock); + return 0; + +_error_locked: + mutex_unlock(&data->comm_lock); + data->timeout_cnt++; + return status; +} + +static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, + struct completion *done, int timeout) +{ + int status; + /* + * check if this is a short one way message or the whole transfer has + * second part after an interrupt + */ + const bool use_no_irq = msg->length == 0; + + if (data->shut_down) + return -EPERM; + + msg->done = done; + + status = __ssp_do_transfer(data, msg, use_no_irq); + if (status < 0) + return status; if (!use_no_irq && done && !wait_for_completion_timeout(done, msecs_to_jiffies(timeout))) { @@ -243,11 +262,6 @@ static int ssp_do_transfer(struct ssp_data *data, struct ssp_msg *msg, } return 0; - -_error_locked: - mutex_unlock(&data->comm_lock); - data->timeout_cnt++; - return status; } static inline int ssp_spi_sync_command(struct ssp_data *data, -- 2.34.1