From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C80D63F39C8 for ; Fri, 15 May 2026 17:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778866844; cv=none; b=Y2CuCoZM2gThrz6Sal6cmH6Qv3UxvfFgQG161MyXsY3Lc95dsO70T9fgNVlxXIeCsgmFoAcbyUkdbX6n4Q6tnQwlchncxpR15xxIYvdmEgPVibGGbSxK6R3dF3ucUtIKfJzJ6UH2Ie2UOw3uXcZ6L+A7/c3OFdNbSc54uP22nNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778866844; c=relaxed/simple; bh=YI085fm37/ypf/0BfgnyWYfjlnTlCAzVT3T4Drtf7HI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=uO8jvPTVFOHSZ9PpozZaG6xz+oyCHhnrYdzEUbXv0vYPqtY8soPdc4OidT+qhwHZxo+ApAoVAc/NePg47XPnn5H+wnUVaZ4cNbjiA9yew8L35hZhugecWpKosanYeF57GU5fGVb9bHvqjBc8hHPM9H2acFzP37xvclftYznlkbA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oEFPWXwy; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oEFPWXwy" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-83ea84df1d0so51299b3a.2 for ; Fri, 15 May 2026 10:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778866842; x=1779471642; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0kNSilLvGuFX4bD2pG7PVn8FSSIgnqfPybpOGUR9Wlw=; b=oEFPWXwyltXVz4hs47KwsDBtw+0Ljc6/SC5m/fUWwWI9ZuCa6MqcvHdaA3mabWIS4W ZchRDGg5Is00n3qrTXSNvZGJNj7IWNjPTv8S3RlqjUHIbjSu0VyoUwImUT3AqwA/jywG 16QfpY7d3CUSOorq/UaIIdal0jBwwwJv7nvO8W3c48Pyv7xYFUWJVWVMkGZlnxnPB2G9 dXDnu20yC6FRF4+kj+f2UMoza3VUOpudjC1lUKIPVAnRRq3CP1KsiYBA4allgZnK3y/S 9YqQVhVrg7DMpwsmmdDQBwBAaNRy5pjXpkOqLW/8tWfc7M1sYSteDF+E6g8atIrRVj9r KGng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778866842; x=1779471642; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0kNSilLvGuFX4bD2pG7PVn8FSSIgnqfPybpOGUR9Wlw=; b=AZ97KIQJ6+8+TYSOHRS/1FKZsFTWu1R2tljKlyTITlTg3EPB+YIZPLBUS/zEGLQEq7 EQ9u3n3lc+ubk7DltWOejdryjcCGfoV39DdMyAn3At4f/MBplsCjyRo4vVG5i1EfnsZT Ik7yy9Q4BPk2ox5XTNG2BEFESs/RvWHyP+fZtVRAd3S+o4pVKBbgltvrWakGc4k4nHfD Csez/pSYTjhEn6uno1gri/RP50O/zBPcqkQh4erHPgofx6/Vj0eAKgB7duTxcTkhaaA9 lnVlIyZZuXWfRY8qnTmbm5ldnmj7yjyGyGD/4jd0JxWhBaP05natBm7wLLVhK2K42pe3 WPsg== X-Forwarded-Encrypted: i=1; AFNElJ8Wb3Zo5KE/hI7upilClozeNNgLEZ/hhKAOQYS7Pt19+ZO8uttigj1GEUouw5pK0/SUSnTZs3+yaQ2McUM=@vger.kernel.org X-Gm-Message-State: AOJu0YxT7lYmLxD9qOXTSn8MDaTIhjq7OvJcw+AwzeA1e+BT2+LvcXtO CJnoIHe0LkSaEDJa2aL5MNRWmN+BmJsm38i1/VxU7e84IhuezfxDblIV X-Gm-Gg: Acq92OGvVHWFKuf2pBsYdoaX5D50VBH2npqP3/jooa843qHmunIdqLenv2n5Nb4Jz2+ upJqtABAhP0SWf3SUmS9LoOXrWOFAQ4NNuA1DlXL4RtsEJPTWv7CZ+onQXFrbjZc5xswYBX01I/ zGtlHsm66geOalTzgptrcdBMth2KQEn4GSGJz6KJBs+T4jH26PdmAWdA2glLCUTZgWYtgJcn51W m+G0c+52aVDnIbvoyqDgjPOFUBsxiB3zg6/93ZjEoThfvh0tefpwOj/YE0kUD87Asn8xNmfvrup PSWPwSXx8Zj+IIw1QaszlepgSHxpjAOjFeveYxsJkWWD88HpPxhffhhAOJp4Wk9XWVfm8ZNhhYS 0CuWlB/YUbYZs/fvjFMoAUSwxmzm5h7FdOQiP6zuylJz+6Npt7thMkbN4J21FMZy91/96ZAPOf3 ymHdKKvKsNIqD5kYSRkCM+R2XlII1Zi5HDXAECweO0ty5lRKkh X-Received: by 2002:a05:6a00:ad5:b0:823:cbb:a484 with SMTP id d2e1a72fcca58-83f33cbf6abmr5447942b3a.14.1778866842002; Fri, 15 May 2026 10:40:42 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f2875f0fbsm5579034b3a.57.2026.05.15.10.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 10:40:41 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org, kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz, kyungmin.park@samsung.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 04/12] iio: ssp_sensors: factor out MCU enable/disable helpers Date: Fri, 15 May 2026 23:10:09 +0530 Message-Id: <20260515174017.3962168-5-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260515174017.3962168-1-sanjayembedded@gmail.com> References: <20260515174017.3962168-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Refactor the MCU enable and disable logic into small helper functions. This simplifies the control flow and improves readability. No functional change intended. Signed-off-by: Sanjay Chitroda --- Changes in v8: - Following comment from Jonathan, split function to have separate changes for each small helper function and demote the log level - v7 change: https://lore.kernel.org/all/20260426091710.3722035-5-sanjayembedded@gmail.com/ --- drivers/iio/common/ssp_sensors/ssp_dev.c | 43 +++++++++++++----------- 1 file changed, 24 insertions(+), 19 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c index 51730dae5871..4280eb590c03 100644 --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -89,23 +89,28 @@ static void ssp_sync_available_sensors(struct ssp_data *data) "SSP_MSG2SSP_AP_MCU_SET_DUMPMODE failed\n"); } -static void ssp_enable_mcu(struct ssp_data *data, bool enable) +static void ssp_enable_mcu(struct ssp_data *data) { - dev_info(&data->spi->dev, "current shutdown = %d, old = %d\n", enable, - data->shut_down); - - if (enable && data->shut_down) { - data->shut_down = false; - enable_irq(data->spi->irq); - enable_irq_wake(data->spi->irq); - } else if (!enable && !data->shut_down) { - data->shut_down = true; - disable_irq(data->spi->irq); - disable_irq_wake(data->spi->irq); - } else { - dev_warn(&data->spi->dev, "current shutdown = %d, old = %d\n", - enable, data->shut_down); - } + dev_dbg(&data->spi->dev, "enabling MCU (was shutdown: %d)\n", data->shut_down); + + if (!data->shut_down) + return; + + data->shut_down = false; + enable_irq(data->spi->irq); + enable_irq_wake(data->spi->irq); +} + +static void ssp_disable_mcu(struct ssp_data *data) +{ + dev_dbg(&data->spi->dev, "disabling MCU (was shutdown: %d)\n", data->shut_down); + + if (data->shut_down) + return; + + data->shut_down = true; + disable_irq(data->spi->irq); + disable_irq_wake(data->spi->irq); } /* @@ -146,10 +151,10 @@ static int ssp_check_fwbl(struct ssp_data *data) static void ssp_reset_mcu(struct ssp_data *data) { - ssp_enable_mcu(data, false); + ssp_disable_mcu(data); ssp_clean_pending_list(data); ssp_toggle_mcu_reset_gpio(data); - ssp_enable_mcu(data, true); + ssp_enable_mcu(data); } static void ssp_wdt_work_func(struct work_struct *work) @@ -584,7 +589,7 @@ static void ssp_remove(struct spi_device *spi) dev_err(&data->spi->dev, "SSP_MSG2SSP_AP_STATUS_SHUTDOWN failed\n"); - ssp_enable_mcu(data, false); + ssp_disable_mcu(data); ssp_disable_wdt_timer(data); ssp_clean_pending_list(data); -- 2.34.1