From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 497983F39E0 for ; Fri, 15 May 2026 17:40:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778866848; cv=none; b=qzKUYnJFX4G1UL1gpX/Qmn4UKRuiMfi9pdOo7GpmQXrT5BabhiW6L090M6/Uq6mbpkn5d0IEFNsxc1QFxIVLhtmY71CpGzuAgjmkAjXSvWOYIg8idLA9XPzB5+KqoLWVxCaD7mVnmekKFHSFfJiI1gW+xbuWIf6wAMyBqWuB96M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778866848; c=relaxed/simple; bh=QpOYFv8tYMRTdnNISpiGdgVYHufG68uVcQwITa5shwI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=J4Qjwx4Me2TIyb2fBzWOUtQX/V/BqOzUdvc1Glsn/ECurVTSoHMNjTY4DmEvBgx4jCgGm1gm5lrq5cW1U9uh/YS2TbEN3e5Wu4phfX+L/d6VWVIpcUoSGkHMvp++2NF1IVrSEf/FRJhWXU6yJlmUa8dsLqrlnGzEJFXyFJjZWD4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LysmruCW; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LysmruCW" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82fa8d6425bso75018b3a.0 for ; Fri, 15 May 2026 10:40:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778866846; x=1779471646; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fcTs3eLyOIE0l5GPVRit0A4+HMRVxCXis7Msp6YvA7k=; b=LysmruCWLLA+qeUSFHWT3o8XBjJYByrhpoRtqpxx5eV3mpG8Na61N9NWiA68QVUP0k u+SnKMZv2F6mGeVJVIxUSJ4fzyotGhMm70br/l8k9GqkYsMC7/pcXj9nO41m4GeFP8ar 1tgy/Yh/MQBlrWYHXJqxfrTkeyatne8783CjDV969FW3IhjEZ+2S6EYYPjHAah3z22AE 6uC1r0cwUneqYwvbIsAUZU78d4wnWCqGxQ29+i2CfC85/Wy9Y94M24UmNdUYqeciBmhx +chXlfs0IeDo6YBi7BwnW0iH9qDyKTbrv+Cmngrmn715V4pta8fyzGUI0+Vn8rQEw+/I oIbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778866846; x=1779471646; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fcTs3eLyOIE0l5GPVRit0A4+HMRVxCXis7Msp6YvA7k=; b=kxTJDvo6pkktsH28fp+zQ7p2dbW84MZeUifz2gvTlkhRZEq30v5d2oUFQolY1V7bCP lsK0VZ4A8zvC4cM51yt9Yxhw0CvH7Z8rtHNJyCR+d7kiUbGSf7uwSbCeMv9nl8AxrX10 j9keB7jhmTKj/UKi2WoGO617uoFbLmtNBVVJznOjxBgs1n85vre8h+5ZIBfYcuoaUsrf M+HyVlzV8s3rjjpPKtbAKxL94URBeBONdy2OtsWwe6q9/jsa+Arzdp0eQzqlXBgCa5Kt jJOJCpXx9YDpZAXwT66/zHWmUqr4N95VbDETjOiG3r/p8+D0OK9qJGHys4FQFPTq/Sdq BPAg== X-Forwarded-Encrypted: i=1; AFNElJ9tM9tgWid2Pi6x7QJNlstj1SC586dYg3848bZOahbQt3sWphcTNstwPXnw6Ox23qGJczKIckQOdLPV6eo=@vger.kernel.org X-Gm-Message-State: AOJu0YzQFGA5OjKLTvM9F4y5nA56b7q3htcUxR5N3UrojlYgy/0d62Xf zWYMa9ZY+nucMVyDmJ449dmJKLRyvMcQv6pBRygzjQUoXyos/z4+Du78 X-Gm-Gg: Acq92OFNwfa9Sc7O6eHWzL9/OOmJaUAT6veDNltBN86o71ZoCDpd/u6ADo2w40l3pCr 6j8813OB6HK0NHYyTc8HH5ZggubSEmhV0pDt+eRwRBNky9FGEhwthuwhhvwWpS7dVq0MpaqiCpU eeAh6KBKHej3MDLJmCXpLWVDbrlC/KANMil0TxlmtwM4ZRCX3Xmh/wsjoqtVYPAUlao9JcabI/H XsBYS17lqoNtNJF5+++CE/KtL9x6j2Wrk8KFFSEt7QKLplsQWBlAPNyIBuv2LA7cKmCKJ6D+uPx mwjT8mxyI2TY1lsOfWOnWo8d8A8bHntkeRvktF4fkejCUWM3jJ0B6ACDP4Xtd+zWBvAsVj74Q4y HON0+wb9OT4Q1ZFvv+csT4nj/Q1sxlzoMySsiONLKaR9RB6fBimOoTmuH+kXwXZcB1jaeEWqS2i kk2Bgb0DNQPBwlXsBYefHmQSN4R7L3xUte6cd/E1RN01KSHwJwEt/WIMXdt8s= X-Received: by 2002:a05:6a00:4f8f:b0:837:b5b6:1b98 with SMTP id d2e1a72fcca58-83f33c7aef6mr5385845b3a.12.1778866846467; Fri, 15 May 2026 10:40:46 -0700 (PDT) Received: from hu-ckantibh-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f2875f0fbsm5579034b3a.57.2026.05.15.10.40.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 10:40:46 -0700 (PDT) From: Sanjay Chitroda X-Google-Original-From: Sanjay Chitroda To: jic23@kernel.org Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, sanjayembeddedse@gmail.com, tglx@kernel.org, christophe.jaillet@wanadoo.fr, mingo@kernel.org, kees@kernel.org, nabijaczleweli@nabijaczleweli.xyz, kyungmin.park@samsung.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v8 05/12] iio: ssp_sensors: use local struct device Date: Fri, 15 May 2026 23:10:10 +0530 Message-Id: <20260515174017.3962168-6-sanjayembedded@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260515174017.3962168-1-sanjayembedded@gmail.com> References: <20260515174017.3962168-1-sanjayembedded@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Sanjay Chitroda Introduce a struct device *dev derived from &spi->dev to improve readability and drop redundant "Probe failed!" log in probe path. Signed-off-by: Sanjay Chitroda --- Changes in v8: - Following input from Andy and Jonathan don't mix variable reorder with new variable addition and drop redundant log - v7 change: https://lore.kernel.org/all/20260426091710.3722035-6-sanjayembedded@gmail.com/ --- drivers/iio/common/ssp_sensors/ssp_dev.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c index 4280eb590c03..a652bb56c61f 100644 --- a/drivers/iio/common/ssp_sensors/ssp_dev.c +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c @@ -487,27 +487,28 @@ EXPORT_SYMBOL_NS(ssp_register_consumer, "IIO_SSP_SENSORS"); static int ssp_probe(struct spi_device *spi) { + struct device *dev = &spi->dev; int ret, i; struct ssp_data *data; - data = ssp_parse_dt(&spi->dev); + data = ssp_parse_dt(dev); if (!data) { - dev_err(&spi->dev, "Failed to find platform data\n"); + dev_err(dev, "Failed to find platform data\n"); return -ENODEV; } - ret = mfd_add_devices(&spi->dev, PLATFORM_DEVID_NONE, + ret = mfd_add_devices(dev, PLATFORM_DEVID_NONE, sensorhub_sensor_devs, ARRAY_SIZE(sensorhub_sensor_devs), NULL, 0, NULL); if (ret < 0) { - dev_err(&spi->dev, "mfd add devices fail\n"); + dev_err(dev, "mfd add devices fail\n"); return ret; } spi->mode = SPI_MODE_1; ret = spi_setup(spi); if (ret < 0) { - dev_err(&spi->dev, "Failed to setup spi\n"); + dev_err(dev, "Failed to setup spi\n"); goto err_setup_spi; } @@ -543,7 +544,7 @@ static int ssp_probe(struct spi_device *spi) IRQF_TRIGGER_FALLING | IRQF_ONESHOT, "SSP_Int", data); if (ret < 0) { - dev_err(&spi->dev, "Irq request fail\n"); + dev_err(dev, "Irq request fail\n"); goto err_setup_irq; } @@ -557,11 +558,11 @@ static int ssp_probe(struct spi_device *spi) if (data->fw_dl_state == SSP_FW_DL_STATE_NONE) { ret = ssp_initialize_mcu(data); if (ret < 0) { - dev_err(&spi->dev, "Initialize_mcu failed\n"); + dev_err(dev, "Initialize_mcu failed\n"); goto err_read_reg; } } else { - dev_err(&spi->dev, "Firmware version not supported\n"); + dev_err(dev, "Firmware version not supported\n"); ret = -EPERM; goto err_read_reg; } @@ -574,9 +575,7 @@ static int ssp_probe(struct spi_device *spi) mutex_destroy(&data->pending_lock); mutex_destroy(&data->comm_lock); err_setup_spi: - mfd_remove_devices(&spi->dev); - - dev_err(&spi->dev, "Probe failed!\n"); + mfd_remove_devices(dev); return ret; } -- 2.34.1