From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD8C73E16A9 for ; Fri, 15 May 2026 18:43:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778870591; cv=none; b=YV+u/4KG22ykQdgBjnE0lbQG8MMEERDvgQHGV5FGfD0LMQniqPLqAhIwnxkgLwwRVroOIUeg3z6q786yur7mKfEJ0MXwewMIoiKaZBRsV3pOTDXNzRrxJq0P/4bnS18SQHnO3Dzur8FD18RvxwW6vHSpK7SgLxhU3B5ug16Mky8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778870591; c=relaxed/simple; bh=QH9FJvwVzG3kwhmgx+COL9mP2nHm1UlLgbekHxUB6dQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=SIDxrugOMapROthpFH2w3IrHRfuqLuB2Pt3108wLSOZey8BpGXKBUI/KsnPkCYGv9EAIXEjyg9YUcNk8VnQKmCNo0SCHMmj+VrwpnMhJZAPmsuJqnk5HBkFQVx7iedU4yorsy5B8IHwL2e76gz3P3LPRkqLbLN/KibwTrCrWkgc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TX6CAtpp; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TX6CAtpp" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-36627a0ea23so59225a91.0 for ; Fri, 15 May 2026 11:43:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778870584; x=1779475384; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Vx+lhp6XxON2YOyCdm1ChngOqSePZVBarBxt/yXA8c8=; b=TX6CAtppauCYGpQNbOcCyrwgBiWs3/VypzNOssPTKX9/O1Rc4N2kJ4esBNwrQmK4ee san7jdd5ryGMcMoinsNzXvZCmlfSKZc+B+BsX6goYSYmTPC2TiYK8UeKYJi7BkGDiKW9 dCjkOOvQidyvtX1Wh30xJoqM0ioUmmYLlzdbsdMymCYcC7Y4rcWaTNRRNi5o0NxR9RFb TUzBS/97VEVSihPZuH5isQnwesyb4QkI83RS8C91zobabaLhBcq8SV7mBUzlquqk9x/7 pDqLCDgBbGtxB05Tn0yRj/apA/r5z2O5X4HXLu7Z81lNsXtUbqicmaRlTflL2OknhlGw A04Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778870584; x=1779475384; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Vx+lhp6XxON2YOyCdm1ChngOqSePZVBarBxt/yXA8c8=; b=eSwHErlTW/1+9yswsjoc3Vk+hEf8vmI9LjCWJI2gK+5Hc308IljbV2kHzKKcvGZAEB HqJ3lDFfijV5csgtc7V19x01Np3nQaYzsjHEitM0VmYMe4+l6jw/5p9k5ENWYDxLm9B8 Rxxk+TycJKjfLdMY2rYC+KqZjqz4smuZc0iPiPj3lOxYGP/O+oDEPWnDloU/vAu8nqhj jz0zdC8HYHv7jRECfU9caCh+GazZVfTj8I+w/M2T1ELRqqZkO/Ds2bGR2jJBGIvvKjME pF9vZl+6Yo1ZIcFNtZA3ynbFL2Pf4zFLPh1poi43kKZW6bUiLpo5TvDCNYGcBJUc3JTd cA3w== X-Gm-Message-State: AOJu0Yz2Hukx8cHvg9ptltAiufakPVfXJGN/Nz6uqRLwMYeYY3hjW7m0 FajB8709PQdwnVTe7TBicbkN/8pNf6YYWVL2/0pZtqa5a4EcJTNWdPS6 X-Gm-Gg: Acq92OGXGrY7xbrwRmV0vkO3zHs9be7xe1XMqIPZCwvNxXBu9lor5y9QsI4a5xAeLY2 EOv71668evGm/d6Q1i5MT/VyEZOhKhyWV2yazHZuFmsZf+gOUUv5D3PMz05t90i62xjqtRtdNwI beKeeXksXIiTwVoz3I9BdK4rxL7YHUAD8yY10ChYAzwgT2tkJj+KWOB2sxYU/f7V+e5KC2aVATh 04Ny6zaqNkGsNmJrRg8cW7TQan8BTo/dskJF6/+20wRKazSzcl8mDGiEDIk+W9GQFZVeNuuaFkS +Y3HMTWOcHfpVjMkX0jxH9qYBbcwTdQDzTO+LjSKY2nIz2oLGYQVUo60On4ImTa5u2VpVSLclRL XPY2MwI48PCOwri/UVQE8h1Ex9oP0XJ5xCSOKLprpc1oA+awsQO3EDzZLcsJDd7mAC6jNdYAcdf 7dwY8iVg2RIM5lVe7uZNCxK2lM9+hvapeg X-Received: by 2002:a17:90b:5788:b0:368:4cb2:17b8 with SMTP id 98e67ed59e1d1-36951b9ad6amr5283785a91.21.1778870583733; Fri, 15 May 2026 11:43:03 -0700 (PDT) Received: from gmail.com ([58.84.60.109]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3695155a0d7sm3315930a91.2.2026.05.15.11.43.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 11:43:03 -0700 (PDT) From: Sumeet Pawnikar To: rafael@kernel.org, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, sumeet4linux@gmail.com Subject: [PATCH] powercap: intel_rapl_tpmi: Handle PMU registration failure during probe Date: Sat, 16 May 2026 00:12:50 +0530 Message-ID: <20260515184250.228062-1-sumeet4linux@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit intel_rapl_tpmi_probe() invokes rapl_package_add_pmu() but it ignores the return value, so a PMU registration failure may leave the driver reporting probe success despite the PMU being absent, with no log trace. Worse case scenario, the previously-added RAPL package would not be torn down. Add check for the return value, log the failure, undo the package addition with rapl_remove_package() and fail the probe. Signed-off-by: Sumeet Pawnikar --- drivers/powercap/intel_rapl_tpmi.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl_tpmi.c b/drivers/powercap/intel_rapl_tpmi.c index 7f41491d9cd1..8bc95310b542 100644 --- a/drivers/powercap/intel_rapl_tpmi.c +++ b/drivers/powercap/intel_rapl_tpmi.c @@ -414,7 +414,14 @@ static int intel_rapl_tpmi_probe(struct auxiliary_device *auxdev, goto err; } - rapl_package_add_pmu(trp->rp); + ret = rapl_package_add_pmu(trp->rp); + if (ret) { + dev_err(&auxdev->dev, "Failed to add RAPL PMU for Package%d, %d\n", + info->package_id, ret); + rapl_remove_package(trp->rp); + trp->rp = NULL; + goto err; + } auxiliary_set_drvdata(auxdev, trp); -- 2.43.0