From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD51D413D7D for ; Fri, 15 May 2026 19:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778873995; cv=none; b=g4ii4n5/qHjG1eaU0Tg8jYOnfwUJjD+wVW9zwRe9sBWKg5RhAWGkcP8FjyFie9c3GxDifpQ3AXSMaR63HVliIfJSLDi0mevBxvs4o3v4b/MfrHa8ob3VuDqjFjtIcoYHT3wDt8G0/Y8l5zQdomPeG0TjYLkzzwdNu145ZPotC/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778873995; c=relaxed/simple; bh=z6bA6belrSfAUypBILamq7CWKvxjiNvjUeDFMb09bws=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=iwpc3LWsh0LXtEwB3riCSVi+cMtAdOdRtaFBXTMpDKAPjXKGHEx+krNGwleq1YjtNtCEaFgXvujeCPald8g4kdwpxlLfGoxHwYoGFrhp2a8yMfXfEO8+br5QnBz0NZnVPkDLL95FqweDiSYh8zJUx6gEmDugvUWu6SCLwRMvTXY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=OC3wVBD3; arc=none smtp.client-ip=192.198.163.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OC3wVBD3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1778873993; x=1810409993; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=z6bA6belrSfAUypBILamq7CWKvxjiNvjUeDFMb09bws=; b=OC3wVBD3salIDSUzuxqqrY8z5o5fycUcdGFCosG5jNuFYTtc0xYaYu8p N3OBXccE0Wg02c98J0uw/Tv52/R4SC/4RnzoB8vsRLzDe1HmJWUoeXGLb iNMxKgWWm64sXA93gWuCa5apyByLoNBqhNFdEBjTCyZ8unKqY5KCjH1pV vbG/sYLa4AKQH1Xlp1sVqVlFpzRl/oVOJ4qHbRqgoIKqgBBQuAVeyWNSQ iLLGduN9+MtZ3OMGzE0VtF2nvqIzhPeit/+q6rwNhhSXP9UGyHSp93/J/ nNhfmFgZUved6sD72chg2EhnZD9puurp1gf/UUJ4F2eK3jrMb6g4ZDbQ1 g==; X-CSE-ConnectionGUID: Qzu88kwNSeK7yK64P/iNiQ== X-CSE-MsgGUID: I/KSrCQ2Sq+VeqsvF5ZBHg== X-IronPort-AV: E=McAfee;i="6800,10657,11787"; a="78972228" X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="78972228" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 12:39:51 -0700 X-CSE-ConnectionGUID: guA8r3jSQK2N9pOBgbOKEA== X-CSE-MsgGUID: nDUIVyG0TkqxbGKosg3K7w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,236,1770624000"; d="scan'208";a="237916565" Received: from hanvin-mobl3.amr.corp.intel.com (HELO agluck-desk3.intel.com) ([10.124.222.27]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 May 2026 12:39:50 -0700 From: Tony Luck To: Fenghua Yu , Reinette Chatre , Maciej Wieczor-Retman , Peter Newman , James Morse , Babu Moger , Drew Fustini , Dave Martin , Chen Yu Cc: Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Tony Luck Subject: [PATCH v2 2/5] fs/resctrl: Free mon_data structures on rdt_get_tree() failure Date: Fri, 15 May 2026 12:39:41 -0700 Message-ID: <20260515193944.15114-3-tony.luck@intel.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260515193944.15114-1-tony.luck@intel.com> References: <20260515193944.15114-1-tony.luck@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit If mkdir_mondata_all() succeeds but a subsequent call in rdt_get_tree() fails, the mon_data structures allocated by mon_get_kn_priv() are leaked. Add mon_put_kn_priv() to the out_mondata error path to free them. Fixes: 2a6566038544 ("x86/resctrl: Expand the width of domid by replacing mon_data_bits") Reported-by: Reinette Chatre Signed-off-by: Tony Luck --- fs/resctrl/rdtgroup.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c index a6376a3fc4c3..506b40dc9430 100644 --- a/fs/resctrl/rdtgroup.c +++ b/fs/resctrl/rdtgroup.c @@ -3071,6 +3071,7 @@ static int rdt_get_tree(struct fs_context *fc) kernfs_remove(kn_mondata); out_mongrp: if (resctrl_arch_mon_capable()) { + mon_put_kn_priv(); rdtgroup_unassign_cntrs(&rdtgroup_default); kernfs_remove(kn_mongrp); } -- 2.54.0