From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 321721A6813 for ; Fri, 15 May 2026 23:58:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778889505; cv=none; b=Z6NWZK3CkzuQ6UvP+m04MSJ7ReZ7LzBeGOrac+qmmkW8YmQil3Sw1SBKBxVErmtbSnKtvKmgA4g1AW9irFUh1HRGQSO6bQv4fsukVjE3KgBfDDnVoFvDMYFzBQPRX6KGr/n6K3ESZGvjUCd8vQF9Uzcal4pYcrPslD3uShQ0bD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778889505; c=relaxed/simple; bh=DRFwCkj8ZqTEpiURsa6RjCEdEirSkU7fwSbrQ9CFLAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YJChXkGXxoF22MElJt/1QeQO8N+7aWWG+oe5p89To0QeLqLNTABlrA89DdatH/xyjM8eE3zekb/RtB9ccmaVYUVxiFxUoCjp6yve4wIueByWU2cYGSJIb3T5d5O+pQuYXgIQACbwyxsv3cO4jhOYY5cAmpWCo98kO2jIKq0ZgO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jLmOJFuA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jLmOJFuA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9626DC2BCB0; Fri, 15 May 2026 23:58:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778889504; bh=DRFwCkj8ZqTEpiURsa6RjCEdEirSkU7fwSbrQ9CFLAU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jLmOJFuA7sO8r9fR6IIs8EvD91wurBFs1jjDPLVKjPAnfKAe5Xyac7zOckX5NWUWc hchltuFSGhCN07K01l3Ikq/YS7Bdu56/DORv6NHC3pEAiS7fuv6ccaoI1b6iQvy9oj 27xHNYXCAXJBquzJMmXiUBx4Qyko/9bN8m/CEpnV8kEn6Mwldoiml0wbvmae1QTpzH yrdyD0xHbYaPWVQrkwwi+U+5phf1NzZK5QqiKxIp48WMoHMZe5+c3MA1/u3ziIzxdQ eRdR2VY8jbx0etdzOfrR5UyrkDfo0hO+2RTfhBbmbmDfOVSToXVENWmpAjMp0091cB TAHqxUFosFxZA== From: SeongJae Park To: wangxuewen <18810879172@163.com> Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangxuewen Subject: Re: [PATCH v1 1/3] tools/mm/slabinfo: Fix trace disable logic inversion Date: Fri, 15 May 2026 16:58:16 -0700 Message-ID: <20260515235817.136362-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515065325.4009527-2-18810879172@163.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hello wangxuewen, On Fri, 15 May 2026 14:53:23 +0800 wangxuewen <18810879172@163.com> wrote: > The disable trace path in slab_debug() had a logic error where it would > set trace=1 instead of trace=0. This made trace functionality permanently > enabled once turned on for any slab cache. Nice catch. > > Signed-off-by: wangxuewen checkpatch.pl gives below warning. I think that should be fixed: WARNING: From:/Signed-off-by: email address mismatch: 'From: wangxuewen <18810879172@163.com>' != 'Signed-off-by: wangxuewen ' Also, should we add Fixes: and Cc: stable@ to this patch? Assuming the email address mismatch will be fixed (my second question is not a blocking question), Reviewed-by: SeongJae Park > --- > tools/mm/slabinfo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c > index 54c7265ab52d..39f7eae7eecd 100644 > --- a/tools/mm/slabinfo.c > +++ b/tools/mm/slabinfo.c > @@ -798,7 +798,7 @@ static void slab_debug(struct slabinfo *s) > fprintf(stderr, "%s can only enable trace for one slab at a time\n", s->name); > } > if (!tracing && s->trace) > - set_obj(s, "trace", 1); > + set_obj(s, "trace", 0); > } I think it might make sense to use 'tracing' as the third argument. Just a loud thought of my personal taste. I don't think that's what this patch should do. Thanks, SJ [...]