From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E99126FC3 for ; Sat, 16 May 2026 00:02:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778889770; cv=none; b=GgAAqNw7nnlllyf+oqJj822+9aSsHY2evmT29tuK6aDxzNsrQFWVZNo1VBmhmFkXlmE4MPP4ZN6V1NYBPaixmFUz2QN1G8/748uKTTvrO0oLpOIhxDdOgek89bF8+/DxI4sW75B/gOQ2MDPmCW0agjhkCjg5IfwLvXhdNt+wdS4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778889770; c=relaxed/simple; bh=q/RcEyZ++E4Irr7VcVtFjd200tk6TSDeapQfTiXOsXM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=mOfKeMXQXQYzUv04yIEplDl05W1+rHZF04zs/IfiW0LOblP11GSBgtkdrpoLldcZqOqLY69Ztzp2pTUo91epOreYVg/K2LW/p0uBQDk4iHOXoVovhEudEFH7+TTHPyrjiinxq/S1k99Zvv9LyImiOVJ/7ewTp65fMajzYsB6Ouk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=vFPDmMyJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="vFPDmMyJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49E51C2BCB0; Sat, 16 May 2026 00:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778889769; bh=q/RcEyZ++E4Irr7VcVtFjd200tk6TSDeapQfTiXOsXM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vFPDmMyJRZjBMvPujRgif2haUPlvdyRr18wue+QSCFbkNhBrC2qF+WXNk4Ptsbmps Vn04LzKadVYvMXY+CDbqspOKnEkSEEBYmbmR3fbNut2bIH7AEcysEYHFnuK67Lz/Le +8FHFd7tJW6CDKYaWcoaK7hLwg+m52HM/CfAaA3O7/lyM2KigZVaPOx+K3jZNdlkLY xPxBgEkfJwFHs6hMpkTRDGV1z6QX1C0AxLzfGZd4MvZzEmOU3al4vd9RQPiuNI+weG NBulSeJUl2s7iMRB+pFKsz208KVeM/u4+4/k8vettcF0RBXtjdgk2Lq9moBQeTyJRD 3ZlIkg4t29n1A== From: SeongJae Park To: wangxuewen <18810879172@163.com> Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangxuewen Subject: Re: [PATCH v1 2/3] tools/mm/slabinfo: remove dead assignment in get_obj_and_str() Date: Fri, 15 May 2026 17:02:41 -0700 Message-ID: <20260516000242.136498-1-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260515065325.4009527-3-18810879172@163.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Fri, 15 May 2026 14:53:24 +0800 wangxuewen <18810879172@163.com> wrote: > The assignment `x = NULL` sets the local parameter variable instead of > `*x`, which is a no-op since `*x` was already set to NULL on the line > above. Remove the dead assignment. > > Signed-off-by: wangxuewen The email address mismatches. > --- > tools/mm/slabinfo.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/tools/mm/slabinfo.c b/tools/mm/slabinfo.c > index 39f7eae7eecd..ac00daee41d1 100644 > --- a/tools/mm/slabinfo.c > +++ b/tools/mm/slabinfo.c > @@ -194,7 +194,6 @@ static unsigned long get_obj_and_str(const char *name, char **x) > *x = NULL; > > if (!read_obj(name)) { > - x = NULL; > return 0; > } You could further remove the braces? > result = strtoul(buffer, &p, 10); > -- > 2.25.1 Thanks, SJ