From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5A98405C59 for ; Sat, 16 May 2026 09:07:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778922463; cv=none; b=EthNeNiuuLCLFBy1tq10gzPuHjaHl1Bvo6o2xKojDTQLy6JVMsFDcL/dLjK7AnEthLBAF9qKDrcHl34dA3ktB9A62bPAja00xPUj2IuvOA/k8CL0udPDKKruX976EAIXw6Q2R5GRq+z9QmHVa/TKEYDxh+4qhASr4cznebPj4ik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778922463; c=relaxed/simple; bh=ndYhF2CWwUwE5KJwraXl/Izca/Zs7isR1/9AJ49V6Ds=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=A3wI/XI9SQ2F3jBOdV83Ps+vsfR5WHgrR0wFmrC4DHqx95TcRSruikfS495tWWbZVSk9685zLR+oLhPtEhIRAM5fZPGO6yEyQttraKprf0uLooRDZ6mTDyKO42+axuEdMlJtpgvRWrLFBquJhz49el4cxVzQWxM0VcdAwaakT3M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K4KY4iK2; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K4KY4iK2" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48d10c981e4so841505e9.0 for ; Sat, 16 May 2026 02:07:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778922460; x=1779527260; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=z9iwndGPdhhfbaDqoUlTzWSRTEYwd9nb6CJHJivhXZA=; b=K4KY4iK2nCHOH+QXR5KdWl9sOgd42e03zWXUZs21/Mh/jCG/USG4c/MGpfD2TthLEM uYTXNcq9drZ2JLs6gSodXDNX4MiKMF7h/W/WU4CAcvU8anMcLikcIYIduERkn8LwuuWt qzhIRgmY6K5dBoELD46L5P4JScMsU3b163MQTTb5Iby+evsHG+jvw2AIM0uL0Qzqj+Ah BpVVfQItxo3kwq4mGpraVZjUi31PKf3HHRsvQ7IqK2uFivO17AL/BZ4GXa7Ym9FAhtct drBM/ee9t0KfmK7NqOxG0XKovIwvJ9vs4I4tznlnRpVkiQP83k5Q4/Jjm1lHX/c7RP5E 03Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778922460; x=1779527260; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=z9iwndGPdhhfbaDqoUlTzWSRTEYwd9nb6CJHJivhXZA=; b=HIN9GUHV3l2tAcXyp8CjAx0i6MB5RjA6GEQsK4KGbrTepLKaH2JvJ1CqOqcKTo+FJ9 18M7oMaqKACnO6aWcBwHe+5aQmxvEmZ9YrlBdegkyiycpsSPYAl2yyDheEpaC3soz28R NoLrcQr9o+WcP0tY9ANtC9+2iAeyPksfeyhKxcFD44lJriErHszu/N3kHr2XlQIkJ7Yl pixpNYhCue5n7C2jnNfxwM3qSkHrXx9j4hM/mbvw9x+emQqhLomL4oMr2GDY5IAcS2Wq sSc5qckiiLA4sOrH8HqAmE03nhkCGGfSdyKcUkrtQ2TvD+duCJ+g5nJUT5wDhjS5EEXn MfCw== X-Forwarded-Encrypted: i=1; AFNElJ9EE32gj8RcRB3uxSQqg5ImMMRaJs+TCL01iVEYlQ3dkzigSEU4E8OixnmHKvL7Nu7uwVcBYz5WPgdAodQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwDiWLM83F3KPI3RR2pc2+e1Ccae5Vg7lFBtCn42VQ2PGVP8wfo PA8lRrMRSCS9H+IYBb2WlLcKV4tE86pC35+v37HQQf3xWQ9tnV5ZA1MeqBp4wYtoaJI= X-Gm-Gg: Acq92OHKJxTrrCAFmX3hH84DbNroaOY7OdWheDuykOMW3lLFxcT6bHBPjo/YKWoy0Zn sQoiFkDi0QMmq6EtZ3Q5e46oGfCVvbcBNySZ994TzqBuJppnuv4zKBtx7vqqDzb40hKnd7r2cio zjFp2nTrXywVj07z3uz2bd0aCmReHZxsE5gR7DpCVO3Zr0LsY0tU8DrCUrjOT/NMkPbbxAK4mDG g5D/vNaZMAiP4is08yhCwkr7z1I2XLKhitdrDYVa0MAk/fIg5g+g1X6dqSLYI8S8bYwQB2piCNN LXK3C58Lz5rK7CUzrqj+59sGaUIAjLvNvBnI2GQa4vz9bh/+QR/PxShYU6f7rHHzuZAomN9QfNI i0D9Crzvy/Od2FF/LfHpaBP3E71iyouVXap0vtil2zPWMNsMT/jJHGdU2/hJ+xSVHM9l1GIViLr TXCWrmQ6P+ZFxLDqWOA3qsVioUon++7J8iUk64kctfystm X-Received: by 2002:a05:600c:4704:b0:489:1ca4:c999 with SMTP id 5b1f17b1804b1-48fe66550aamr47129795e9.8.1778922459852; Sat, 16 May 2026 02:07:39 -0700 (PDT) Received: from localhost.localdomain ([82.215.118.79]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48febe66544sm32827265e9.23.2026.05.16.02.07.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 02:07:39 -0700 (PDT) From: Stepan Ionichev To: gregkh@linuxfoundation.org Cc: Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, shawnguo@kernel.org, hcazarim@yahoo.com, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Stepan Ionichev Subject: Re: [PATCH] firmware: imx: scu-irq: accumulate wakeup sources via sysfs_emit_at() Date: Sat, 16 May 2026 14:07:26 +0500 Message-Id: <20260516090726.38362-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 In-Reply-To: <2026051633-doorstep-sequence-6782@gregkh> References: <2026051633-doorstep-sequence-6782@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sat, May 16, 2026 at 09:15:54AM +0200, Greg Kroah-Hartman wrote: > This is a horrible sysfs file, and breaks all the rules. Why not just > delete it and use the proper api for it instead? Yeah, fair. The sprintf change just papers over the real issue, which is the interface itself. Quick check: no Documentation/ABI/ entry, github code search returns nothing outside the kernel tree itself (https://github.com/search?q=scu_wakeup_irqs&type=code), and codesearch.debian.net also shows zero hits. So removing the attribute looks doable. Frank, Sascha -- any out-of-tree readers of /sys/firmware/scu_wakeup_irqs/wakeup_src I should worry about? If not, I'll send v2 that drops the attribute and logs the wakeup source via dev_info() instead. Stepan