From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f195.google.com (mail-yw1-f195.google.com [209.85.128.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23DC237C103 for ; Sat, 16 May 2026 21:04:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778965446; cv=none; b=DieHHkeuDixrJGVQ/V7s+XTaDTDaRZ9/TeXW1yYrDbLin6XU1WyRfwFCDEv0v+SY4uQT1EVdkmL+bfgUydygKVc8/A1idtIWWUb5D7yTYgyS6bE+hZrEwWzUVx0ElRoqnGvpdZZ9vkP1eQ2ruteU2oJ/kB6pXA2l7aQnMkLxXK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778965446; c=relaxed/simple; bh=9ehoVGHCch2YDXFpAgGWGiRbcBZMIbDp0HeIrubwg+g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IuwW2/De281P1ElNwk3yQuUdXL5NIvqdouN9CwD9MaRmkZt0px97HqnL5/WoFEHZ+O9JNjB3LMKZf6CqmgDztns81AYic8FHd7oTq409479M3zCKLqE0rlkFCAfBslDU15qRxXoAxlo87ex7CyclU+PP2OFLSqXPTKkhMhOVjJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GlCZE/16; arc=none smtp.client-ip=209.85.128.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GlCZE/16" Received: by mail-yw1-f195.google.com with SMTP id 00721157ae682-7c307937816so4789317b3.0 for ; Sat, 16 May 2026 14:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778965444; x=1779570244; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BHb6DjRXqj9xDQrypI0jK8ctMTDK6O2uioTTtx6jNrM=; b=GlCZE/16pFOKeErCrhmEmpO7nMBG8qrsunEUO9E14hquTV0Ew2Ty5Hi9PZP2pNqsZa WCpBM1Sb74N9URMSESPHT6GW7aCwhE9cFri610Kw9O5rUe0QXGWC5M3cHg+8b4riX78j XGZcoXXC5idfI9Y5BDR/OJtCVWP7k47af78gc797xdhi/NCFg3gFAiRCHS08pmFywKkt VD8HLRVStvkBb9bVBIRLYcjQWHbQHkHfSiLjV/9FlJ+Aa88cMUmy5F4ZdpP8ZskKifJO MrNDQnQCw3nDd84teTws2kHsPYXluDBkGQ7XGgn/cIAihG3JUUGyIDMRZB8BoYa6VDFl y3ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778965444; x=1779570244; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BHb6DjRXqj9xDQrypI0jK8ctMTDK6O2uioTTtx6jNrM=; b=RebkklYT7/cTVtXti7wW0Q2ugqGaaXbmktO2yCxH89Jj1pKFCpM3QGah2BlTUYKQoD 45NyqIy0ryPPKYrdh9gSnG/oAce+EEQBHNT0swe3sJklUxH0KrqIfReVIU+y9v281wl+ FNPm5W/DX927MHG0+wM/5goiOlEe9VLBdIVe5MuyY7j2aAXjAP6igmm0j6/8mbW4Rdon WrFHuUOie1s7qkGsUW+c+qypQbE0FwkJaVzc8iemeSBeSpTa3VQRMAFimHnWdCcQvVA4 sN2sqXvgbA6zMZ4VXJQWiisUbA4lnVcCAkd9gZOLb6W2iFzhMLywsfUYS6R8FgAueM5S X0aw== X-Forwarded-Encrypted: i=1; AFNElJ8QgzG6/DcwmnPXyAeAgzTae3GBklVj6WJAwLJEMNMzn5ctpm/pGVmuQjgR5aJEqvD330E1XqjL4aKlcN4=@vger.kernel.org X-Gm-Message-State: AOJu0YxxwZXnvx9ciW3KwITEdW8aPh1XNi4FEqJb1MghK/EBvGOPaBeC 9rQ8WO2MhGV5377sx3aKpwSxInpMyiwif65hAxKdS3A6ZcKvsKN4eVw= X-Gm-Gg: Acq92OFtZeAYfxsaa0em2EsRGALsxJmlSIJ+rBZRWGIMB8Z/ehbDrA79kzMK75vn7mS BQVHfeYr1EluPji+TkBZ3K7M5uWFQ8vCZtCpDWcgbZ2XlFw/GY47yw/Y56LC67En+Eyy3YIBqIw 9fBMQPl3mN16B2xYQa0UpZa8GA9cIQy7d2vlWsK4bRcdpFxtCv8unDa9TCMEc//VidGy4niNWs+ zhAhEBwK3FK8pGAzIcJa8PLoT0ZEI8kvLgSABOBmtxqPLfS6h1AGUfabgSYYVnyuFYq5Ywx+kbX dsqGfQGfP2VnFwM4ZasEJeq3om9eCqL/WYtSO3UfGtmiCpykty9GjeY8JQo3wpq9Px/Usj7yiLu rzAdQye0mKS/JTFz9+NsSP1DfkHMxmQ4AhBslPTts5kcLVJV9mxXvmyfFTgTrqP8aL0hpWIrlkn KpiQOq16se2K2RRaF0m4CwAPGC104mNoQdl5upIKp26P+8nZaZ5VU/KpFFdVYaBdiMLSwRz8dam w== X-Received: by 2002:a05:690c:c4fa:b0:7b8:1b67:2571 with SMTP id 00721157ae682-7c95d1da54fmr102587527b3.42.1778965444167; Sat, 16 May 2026 14:04:04 -0700 (PDT) Received: from localhost (23-116-43-216.lightspeed.sntcca.sbcglobal.net. [23.116.43.216]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7c7f54c29ddsm48585327b3.34.2026.05.16.14.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 16 May 2026 14:04:03 -0700 (PDT) From: Ravi Jonnalagadda To: sj@kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Cc: akpm@linux-foundation.org, corbet@lwn.net, bijan311@gmail.com, ajayjoshi@micron.com, honggyu.kim@sk.com, yunjeong.mun@sk.com, ravis.opensrc@gmail.com Subject: [RFC PATCH 1/5] mm/damon/core: fix nr_accesses_bp underflow in damon_moving_sum Date: Sat, 16 May 2026 14:03:53 -0700 Message-ID: <20260516210357.2247-2-ravis.opensrc@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260516210357.2247-1-ravis.opensrc@gmail.com> References: <20260516210357.2247-1-ravis.opensrc@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Guard against unsigned integer underflow when nomvsum/len_window exceeds mvsum. When that subtraction wraps, the moving sum returns a near-ULONG_MAX value and corrupts nr_accesses_bp. If subtrahend > mvsum, return new_value: this clamps the moving-sum estimate to the current observation rather than wrapping. Signed-off-by: Ravi Jonnalagadda --- mm/damon/core.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 3a8725e400c6b..9975f3d9ebfe9 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -3449,7 +3449,11 @@ int damon_set_region_system_rams_default(struct damon_target *t, static unsigned int damon_moving_sum(unsigned int mvsum, unsigned int nomvsum, unsigned int len_window, unsigned int new_value) { - return mvsum - nomvsum / len_window + new_value; + unsigned int subtrahend = nomvsum / len_window; + + if (subtrahend > mvsum) + return new_value; + return mvsum - subtrahend + new_value; } /** -- 2.43.0