From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DE4335F5F7 for ; Sun, 17 May 2026 12:40:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779021625; cv=none; b=R5Pwo7KFiME0xfyCpJyUWeD+grPq01sb619VVcI8TlDNAeuNoSmzUIHiF/B3zfyEIzfdzib+zjnY0yNh0HnCEjYdFzJZNHcKztmvCZXsL633zCGxw5BBg0oykgNADRomO537y2AH0Ut3OMmFkSmw2lQ7aHmdDJtlEYYgLMUaee8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779021625; c=relaxed/simple; bh=SqdcfXhNySjfZ8jeGKU6fVRD6BYJ+PAXJFdsSakJb5o=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FNXYdQNV7iKEUXF73BoyzGcg9AgOQZ8wSIg0Dz9So8ikgBGOS8a2IdpYAjcdehf4B2qGiMcOF5Egn/BuodJdzYB48tzDRxz7jtZ/ziOuuI0CtWBiEfcMcHebpRR8tVJOyRgMzKEphTpd17Q1TP7hfJ33fy7h02hLvHVlubNCyN8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AZevd1rb; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AZevd1rb" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-48d146705b4so13938965e9.3 for ; Sun, 17 May 2026 05:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779021621; x=1779626421; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ZRYhLpPlO2XIGLy8e2lMtFFSB/FdoHcKXbU93W0aFKw=; b=AZevd1rbqeQr0/JN4JFmLruJCmntaJsNGFNDHF0cdMzcc8YLbJeRXBrool+xSM6NE7 V05h1WMZxz6oEfrGZqrIoOY7ajjBS+s3G/ufl8geyg+mL4KqRsWnALvVf/04y76V0617 AmRoMRQ/xH/0KkTJwsD+X6l6OFP/hD14mcNNKq0hyx20w0sIMFJPEdQ14e87WgkdpVwv ehK4GGFWrb17/BVW37PQ7W7umigop3o+wj1jIs+SVqnD2pgID+BUIyFpGmETecghVtxf fHPt0QwZ602vfNH5b2d35IcGVm9sbY4UFsVQZyjSv6G1Uia/++7Sb0hNKl2ZOkTGtlWm StHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779021621; x=1779626421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZRYhLpPlO2XIGLy8e2lMtFFSB/FdoHcKXbU93W0aFKw=; b=Z1FSRvyLMzgc880BB4KqdSqtRD/wumKx4p0VEQiPIw8IHEVxi8L5m83QmNt1z/NNy3 GeRYbxghhBtn6La+ELbWrzI3/po1TPkEJc8sEP7xGHfhhuJ/S9rC11NRXGF6fGw63d73 uA1uysqDc7e+f3n/shXNm8YS+LVhlzvUB7WuoEQKX5VCqHaqdvvBT/DSKCks2rPpvAEu UUm48Tn6cYDOTOTpPNcbbRZELcCKZ1sEQtMrkdWbobhii0pVuyw9x+brFYveQEnInRbC 6+amiWqDIhCgpoBgQQPC3TUjcHeyVj3heQtMsesn2UH9GM6YvTSPqjD8NbqtSp86ploH Nrrw== X-Forwarded-Encrypted: i=1; AFNElJ91pFeH0UIMeH50y0e81jn4yMQa7kCvpdhhFrcBGUFfzuQiCmSm6nDQa/YdYv3y2Yi5i9Ws07he3vo7p5c=@vger.kernel.org X-Gm-Message-State: AOJu0YxuODnkLnvBs++wxj47h0HMlLjx5Zxkjbn2c7ngI5g8jO0SBz/T Y7gIG8EeB1cSC15xnpPpXvLRtY6FdomiIT9N11x8zrpOjmG8dI+U+T0u X-Gm-Gg: Acq92OH8rHQZ0f58xakrt8ie9BULHUuPASd1RSppPe1c6AnSEhOY7KqSnaEMOWdJE3s pIt8NcHFe36Kp7M/+PmPfDRn6gN9fXQIAGesJiQ0nEZ6b3VdL7DBkbrQYFRUlVFk8thJbbFQQax B+1jRDRS9J1EBYgVrSAzJ/faLrPN4gM49eJyuz0+aOmuHsekwjN+EIl1AeHYNqwEBkbYhDVCVsz /yde7fiY61eLwCDWdrtCnpowQrNi13AFDFsiovxvVSMfw9UT/g4qyhUKy02If4T+0b5rCdx+zuX O8pq+cX4uECg6d8KCpFd3jDLLziBvj10jxH6D80/5FnfWCkZ6IckkPiegEyAj6B+48XTxPh9H1h 3Vv5skAk45TVMV5wvUBS2RViakQ37cyW6eJtObpve6Mk2MuQVMy+mYnpUSPV48NDgIJNpv583vO DTzjIXuv4fRqISnckp96kk/cQUAYlenDbV1xn5PrKxIGYT2Kr2AgR5HWNkKwLJCdEh X-Received: by 2002:a05:600c:3493:b0:48f:d2fc:d042 with SMTP id 5b1f17b1804b1-48fe61f1a27mr173743315e9.13.1779021621084; Sun, 17 May 2026 05:40:21 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53ab773sm201337395e9.3.2026.05.17.05.40.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 17 May 2026 05:40:20 -0700 (PDT) Date: Sun, 17 May 2026 13:40:18 +0100 From: David Laight To: Andreas Dilger Cc: Amir Goldstein , Miklos Szeredi , Christian Brauner , Jan Kara , Al Viro , Linus Torvalds , Nirmoy Das , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] err_ptr.h: introduce ERR_PTR_SAFE() Message-ID: <20260517134018.62901443@pumpkin> In-Reply-To: <56380C61-04E4-403E-B721-F9B62DEA5D56@dilger.ca> References: <20260514200129.94862-1-amir73il@gmail.com> <20260515193010.056ef472@pumpkin> <20260516094242.77d20c92@pumpkin> <56380C61-04E4-403E-B721-F9B62DEA5D56@dilger.ca> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 17 May 2026 03:13:00 -0600 Andreas Dilger wrote: > On Thu, 14 May 2026 22:01:29 +0200 Amir Goldstein wrote: > > > > The check for constants may be fairly pointless. > > One of the static checkers may already detect the obvious fubar ERR_PTR(EINVAL). > > > Actually, I just ran across an issue that checkpatch.pl does *not* detect > this "obvious" case. It complains about "return EINVAL", but does not say > anything for cases like "return ERR_PTR(EINVAL)" or "rc = EINVAL; return rc;". > > The following patch fixes checkpatch.pl to report many more such cases, and > has very few false positives for checking common error return assignments. Looks like there are a few too many false positives in the network stack. Mostly because sk_err holds a positive errno. They do all seem to be 'err = Exxx' though. Does look more useful that some of the other things that checkpatch checks. -- David > > diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl > index 70c78a3..e3fdedf 100755 > --- a/contrib/scripts/checkpatch.pl > +++ b/contrib/scripts/checkpatch.pl > @@ -5795,11 +5795,12 @@ > } > > # Return of what appears to be an errno should normally be negative > - if ($sline =~ /\breturn(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) { > - my $name = $1; > + if (!is_userspace($realfile) && > + $sline =~ /\b(?i)(return|err =|rc =|ret =|retval =|ERR_PTR)(?-i)(?:\s*\(+\s*|\s+)(E[A-Z]+)(?:\s*\)+\s*|\s*)[;:,]/) { > + my $name = $2; > if ($name ne 'EOF' && $name ne 'ERROR' && $name !~ /^EPOLL/) { > WARN("USE_NEGATIVE_ERRNO", > - "return of an errno should typically be negative (ie: return -$1)\n" . $herecurr); > + "return of an errno should typically be negative (ie: $1 -$2)\n" . $herecurr); > } > } > > > Cheers, Andreas > > > > >