From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 970B737268C for ; Mon, 18 May 2026 09:09:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779095381; cv=none; b=mJ/ZOd95q5wpvIhvMvpp8+A+vLtuZbCg417U+1yfkm46GFpP+TUyUOERhuVzbhk5ePc1KXTZSGwhw+eJKOKjCmcAcPrYYeDmWEwZBMR3LgPZ5d1j/+tUohEqVcTVVQNPLZLPnH2AzpECQlCd0A1ZU9l1uGGqFy9E8cPiEeiarKk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779095381; c=relaxed/simple; bh=ixHCoYPt8QVq9K+Qv66P8axoI6rIOo3kX6kuOGZiIlY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RkD/8I64es0mKVy++/sfOTaFDJQiT4WXkZh6AHPLTYMC6IEudzcPfk4JOB+K77m7fH7REw6HDXpxZUX6e4p2VIlIEKQ7kSvxjjRisxUs4ByW4ArsgJcKcmcNeArDRrNVc/ydwA0R+WDNDSTDha9uAxuIXZWWrFAHwKcKn5M1KpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=By4MEPff; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="By4MEPff" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-44e1860558fso1085229f8f.0 for ; Mon, 18 May 2026 02:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779095378; x=1779700178; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=PSkb2dZhXWUDFcAf8XBLBz88v/zr+2Lt6xaVCyn8T4s=; b=By4MEPff59v/jyA9VP5bcimz/4DDL4scaTaGYce+wph28Xm0ot82mjUwMKjqaVJpPe Yb3aFK9VfoQct5GUY938bmV2q9n9gCZw/ywYhSsq12i33p7cBVrMmN+fyIr8FR58GMY2 3ljI90GTdD1sARNxKVcdaGTO79NyW2gCgUoV15ofa+y1GIdgjkBz6KQtdpmgwFa8GFyH MONCYqw6olneQkdvyZPOVhKFHtVrAMv1NST/ROMbRmKTjJkdih1e5AzlMQpwb68SrZZO 0y5k/tGYKtey4q1cYzLcOBu17ls0K2+posBocpmnr9wGhCpTc+VYheSEuP5AKAN46Xnl cI8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779095378; x=1779700178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PSkb2dZhXWUDFcAf8XBLBz88v/zr+2Lt6xaVCyn8T4s=; b=sjUitM4SkSDgOpFhXr2QUIccYbVMkwOkxw5MiLxOqWAqaMk+HG5sF8S8eQLLkty+dN seSsaHVgbVvl9nlgMuJGOtkmOvtr7mlQq9bz9M+SqIKfKgUd9NV3ym9I2CiudRDhE/9q gmN20/myucoJHOdUyYZL/PZRbhNYI8uJ8XLX6Y5Lnd9Bvlc1wCl4Sl0/c6SUbAjY2dzX 2xy5YukZaBdhOptWPdXp1/DoPcHX+ngzSuD3ld3IsN3Kuc2Olj7gsveV9ULr6feDWQQp oE1NKGAGlc2jAQ4XrO7BLFR2l2+CeEJylrDj/YDpZtYRHUS7G1RbDiwFn+rkwAva67Gg pDDg== X-Forwarded-Encrypted: i=1; AFNElJ9POQMl/4dv9e2HFvbo2lQGl2AtdXcR3MIoNjlpxz33ICxEDlxrcDkxqUpD/rFcafSTO1MTGTRrAdHFHKY=@vger.kernel.org X-Gm-Message-State: AOJu0YwuZGR5VzEdrRKqNQP1TQ6UqIc0ITok0GrlsHEq3c3zHPFE2JC2 yt5Hr/DmhysHEkoSSVOfB8GVDcE806arZ6xOjTnbWg0YDvSiqIDw+prc X-Gm-Gg: Acq92OFqSaQOEyDW6+ypWdauJZfW8TR3SLlXpJ8HQ46v9tBpJUF1A2BQePZR9UIRC/s /x+KrZD5opiryqcyUNEZ7JhU4NzYNkBWjmgndN+0YIc7yjaZLMhgCceKyrAi0n9gxafLR7RRet6 Nl//1TD0yV3xWOycKAt0q+MJgiLV9QRPY1sQ+iWZ24U9M3OAFClpk+/fL7xkhHDDp6TZes/lnuz 4ExTEfQt5A8+eHpYHjmjkFlrHDabxFCNo/dYAN83c4CkVuaxa3+5ya5I8EI4Mx33q4F9O9PWo2j /CHa1FXPei9t5ojb2Fu576OdyOvrlzaydO0nUhT8jpJYw6BYBXxxmgoGwHHyfBkcqiHS3OZ5gXr Ieb/rQsV/7Xt9XKLnZHYeU1TGOix/QVt2fQ+TSxmit0T4ImufkEmkXzq0OfyRGCa1L5iFoJw3CH O43ac4l/qhkk7xciA48L56Jccxsaw/J+DQYSylZJ2e0BPvZo5BEoUUm3i1OgLD2l91 X-Received: by 2002:a05:600c:34ce:b0:48a:592c:e63d with SMTP id 5b1f17b1804b1-48fe60d7832mr233907695e9.14.1779095377620; Mon, 18 May 2026 02:09:37 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48feb00bbe4sm78272355e9.12.2026.05.18.02.09.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 02:09:37 -0700 (PDT) Date: Mon, 18 May 2026 10:09:33 +0100 From: David Laight To: Yury Norov Cc: Thorsten Blum , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm: add bytes_to_page_end() helper Message-ID: <20260518100933.6bfe5b8f@pumpkin> In-Reply-To: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> <20260517123428.1181981-5-thorsten.blum@linux.dev> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 17 May 2026 11:28:05 -0400 Yury Norov wrote: > On Sun, May 17, 2026 at 02:34:30PM +0200, Thorsten Blum wrote: > > Add bytes_to_page_end() for the common PAGE_SIZE - offset_in_page() > > calculation. > > > > Suggested-by: Andy Shevchenko > > Signed-off-by: Thorsten Blum > > --- > > include/linux/page_helpers.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/page_helpers.h b/include/linux/page_helpers.h > > index 102a4f3c3868..981731faa1fc 100644 > > --- a/include/linux/page_helpers.h > > +++ b/include/linux/page_helpers.h > > @@ -6,5 +6,6 @@ > > #include > > > > #define offset_in_page(p) ((unsigned long)(p) & ~PAGE_MASK) > > +#define bytes_to_page_end(p) (PAGE_SIZE - offset_in_page(p)) > > > > #endif /* _LINUX_PAGE_HELPERS_H */ > > I've got a series for this > > https://lore.kernel.org/all/20260303182845.250bb2de@kernel.org/ > > The feedback is surprisingly negative. Please add people from that > thread. Maybe you'll be more successful convincing them. I don't think you need a another new header. There is already vdso/page.h which is where PAGE_MASK comes from. -- David > > Thanks, > Yury >