From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28F413F7876 for ; Mon, 18 May 2026 11:47:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779104835; cv=none; b=pfspm0gyR51ILrs54BXpazKRYDUA9c71X2DrJc9V+TgqRcSjXeOlaRdq0BRy4+Uug3A6Km4hqzwPoswLwUxso/pa0onU6lwJtvSefGLzZqgoTd8tc/fzbLOZY7EptMqMhp/MREB0Bzc9ytPOe0yzDufV6xrdSYQcr9pEM2QFrsg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779104835; c=relaxed/simple; bh=5agnIUk6zVfimPSXwREgWs2+7BJvB3+u1r1/4XX7nYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=s/O1ZNr/jiGJP6tZ2ouXQAbI5ewQMthvpruVwX13e7eyIzJiuC5YDnKabSPWewlkKo7BzFIAsnj4+rYySNMMqrMa6SU6u9brtJVG51YR+VCgLQkHQcnNXAQrcvyH42mceFr5ge//K7TaPqp2l4+oO4CKOVoTrgkCchzWBmb1PsA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rjgYfL5F; arc=none smtp.client-ip=209.85.128.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rjgYfL5F" Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so32631545e9.2 for ; Mon, 18 May 2026 04:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779104832; x=1779709632; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ud+sEG7q0wP0zBzQht1NZnMd2Z7mvrdCEOMs+je9r8=; b=rjgYfL5FT8Y1o3u0yih69Pwfleg9GBjPpfmtxGux1Cvq1QoWkOGqFThwh7BKJxVn05 DOlyeMbO2coGZV38L6a5jnlD44UXWIK4H4yEj/GZloVa8y9RcwYSe6HZl9PRzb+fBtNl 07zapUG5OZR+5muwvt4y9WyDOEMxOHVY/F7CLXIF3grK++weOyONBSvDbozwN+Md4fet ln0Az2uMRqVvg+BIY0hrCC43ZBNkEq3D/ywshjCfMeKggTHkfEOgIgRMDslVNXuqLhRx bPB3YtCZiUv9wImDzCM/Kjdd+4M+Uns+Hbib6vzD5iiWOSG2W4yDWx8I9PTWv+nVp24S NxQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779104832; x=1779709632; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1ud+sEG7q0wP0zBzQht1NZnMd2Z7mvrdCEOMs+je9r8=; b=RN2fK3tRaTBGW9lXVlRBk1kniTA1InCejEiCniHF/dBm9vZm64Opz4xU9/snaOcasD c+KbTIIo5wgQ4feeKg4zqsWN32zshxQqtsnx09/gkyG7a7EdHosKkjyR3bLEeFiD4oYU unmCraswE+I0yxdUUHiuDF25OGRn2Od/gt/umSQg7+vS3WKvrJDDiDmEe5xN/d+mKuFc JeUTPIAORJgNs2TYRYhDbABmNgpgXU6lPvFua1KQySErm87TdypYt1zLoCeGamjcgB3D qbHqVKqD1w8h59bsxbXS8qjA4FtpjGVqidsE98jwDLx/R00NXhxqM+mM0o8nQi/mamfB zGIA== X-Forwarded-Encrypted: i=1; AFNElJ+VUzJ1ZIMXfpVH3UkO0DNdh2nuv2QpC4EyTG+y3Hsb7S1qmnNwwpgGrellbwYOtYNxOCiwjl99M0AXY/U=@vger.kernel.org X-Gm-Message-State: AOJu0Ywfox2ct71dA8PS4MKf14rGm6KCa7rKBnBm/3vsa0avtaNzeSHq yeH8vYUIak2yUYnVtXFCehZF6bMczTNdVLIYAMANbcRQxyGML4VrupM= X-Gm-Gg: Acq92OGLKg7XmzavIMOXjguxrtNCy0iajTlBrme25MDKAXnmHtxjozLkuSFZzzRjx8f HWJ2Q0HqWmpHphKWthjGVfBnYXocKJpFCd+bMgBivD1TYc/irh2r3HmYf1AsLNRYrk2VOwhMGid hYxJ7Qf7CYsB86+TNRiFcGYUq0jPPfbzoRBZEg2vNn66vGbjeAKloz7vFLZjoQB6Rs7VB5CCB9B TZKufZ+SoxWaegLs583hlo9znq9z8Jf9gWlAVL6bxWciQM7iMJq1MFK8LcCCkIC6bqIwGV+m9kf dbIr8JdM1tArCKb3kmsbX0ikg5CWZrg1az2jn7l3Gnyf1fIGfb7rp+pWm9PqxK0GPKAry3QthAm V3qkuY0BKzLo23/WLcm8raE2PPe5OIMzKPd4wT0VCAx1gXIPo3AMgNOQKTOFTaPxphiTBxNCqY7 UKTc21be4WHZcxL3ydqCjquHmyxYdHHLqXxbe0j8XuDAoTurZwAD7W0/HhQ1IknM63xIbazs5Gi 1Q+4PG0nvC49Ff9va9edGwdV7EzKQ== X-Received: by 2002:a05:600c:3f1b:b0:48a:7965:b943 with SMTP id 5b1f17b1804b1-48fe661db6dmr224835215e9.29.1779104831563; Mon, 18 May 2026 04:47:11 -0700 (PDT) Received: from localhost ([2a02:810d:4a94:b300:f15c:fd38:3fe1:9653]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-48febe585absm82341205e9.19.2026.05.18.04.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 04:47:11 -0700 (PDT) From: Florian Fuchs To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-mtd@lists.infradead.org Cc: linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org, Rich Felker , John Paul Adrian Glaubitz , Adrian McMenamin , Florian Fuchs , Artur Rojek Subject: [PATCH v3 2/3] mtd: maps: vmu-flash: fix fault in unaligned fixup Date: Mon, 18 May 2026 13:45:20 +0200 Message-ID: <20260518114521.81564-3-fuchsfl@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518114521.81564-1-fuchsfl@gmail.com> References: <20260518114521.81564-1-fuchsfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use kzalloc_obj() / kzalloc_objs() to allocate the memcard structs, instead of kmalloc_obj() / kmalloc_objs() to prevent access to uninitialized data. Fixes runtime error: Fault in unaligned fixup: 0000 [#1] at mtd_get_fact_prot_info. Fixes: 47a72688fae7 ("mtd: flash mapping support for Dreamcast VMU.") Cc: stable@vger.kernel.org Signed-off-by: Florian Fuchs --- v2->v3: no functional change, add Fixes, Cc tag according to feedback v1->v2: no functional change, just rebased. v2: https://lore.kernel.org/lkml/20260427114750.2480900-3-fuchsfl@gmail.com/ v1: https://lore.kernel.org/lkml/20251117224408.498449-3-fuchsfl@gmail.com/ drivers/mtd/maps/vmu-flash.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/maps/vmu-flash.c b/drivers/mtd/maps/vmu-flash.c index 75e06d249ce9..b76d0609d1b7 100644 --- a/drivers/mtd/maps/vmu-flash.c +++ b/drivers/mtd/maps/vmu-flash.c @@ -609,7 +609,7 @@ static int vmu_connect(struct maple_device *mdev) basic_flash_data = be32_to_cpu(mdev->devinfo.function_data[c - 1]); - card = kmalloc_obj(struct memcard); + card = kzalloc_obj(struct memcard); if (!card) { error = -ENOMEM; goto fail_nomem; @@ -627,13 +627,13 @@ static int vmu_connect(struct maple_device *mdev) * Not sure there are actually any multi-partition devices in the * real world, but the hardware supports them, so, so will we */ - card->parts = kmalloc_objs(struct vmupart, card->partitions); + card->parts = kzalloc_objs(struct vmupart, card->partitions); if (!card->parts) { error = -ENOMEM; goto fail_partitions; } - card->mtd = kmalloc_objs(struct mtd_info, card->partitions); + card->mtd = kzalloc_objs(struct mtd_info, card->partitions); if (!card->mtd) { error = -ENOMEM; goto fail_mtd_info; -- 2.43.0