From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A36B03F88AC for ; Mon, 18 May 2026 11:55:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105350; cv=none; b=TPuSaPVEaL+CwBqy3+8eP2P8Z/MrQOEyT+eHQpDcjB7E7Puuipe9TiCYRCCqqD6vpoj51tzrt1axDu5IWVI3NpdxhygCzwyewMdntMVgq81hJL3JcY1K0yDEHEJJGmpO3lZiSz9knMWy8xEhgZOC4vm6oablNT4ZwhYUZGsRGoQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779105350; c=relaxed/simple; bh=x9wINvGzkhXWZhz0LHxePidlKWHibKXGhzDQTSxC8h4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gLO/Zw099dvFCEhZxiTN+d+CICj1VlvNP8BdK2NCpEg0fzXkMUNCl51ps7tTjT2DL0yjhk7MMR4w+e/kplz/DJVeXA1FKe/bfULZB27T2T7QkPCvAwj/iodbUoGwsAPgnFDoSUgleefoxxUovl0bjgD/XYz6YYjnXJ0/JfZs9to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eJwjxDIp; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eJwjxDIp" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779105348; x=1810641348; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=x9wINvGzkhXWZhz0LHxePidlKWHibKXGhzDQTSxC8h4=; b=eJwjxDIp88C6l8u4nv/Z9aFjf6iRgXFD+mijEgXQ5pucdDeOV4KJ2Jim a92V1Y/9KoSLudROMJFwwWI0ZGkF7qHTwabURzS1LTGJFtwibThDB0lHx I6dUm6Qudo9CrlGDtXvxqdksKNaRtLvnqC+glfJe48tYUVoqdGXDsJ0ak 8NA+sfdzx+IkuEVTODiwl5k9boNBFHq1f6UbgW4JdonTCcDKHk5WoMVwh oWhn7J8Q/gVoSKBMlSPLhNt5HiX6D3arA05RNxCFrpePPOdsU08V6iTlr 4s8tp9NXgNLD47pMZoHpggqfpIvhKNTuNzQZFizhla5rj72z3FGEXaZ7R Q==; X-CSE-ConnectionGUID: 090HqDIDSMiN7TTL711Rpw== X-CSE-MsgGUID: YvHBjn9JQ/i+GAIigvdesg== X-IronPort-AV: E=McAfee;i="6800,10657,11789"; a="91347074" X-IronPort-AV: E=Sophos;i="6.23,241,1770624000"; d="scan'208";a="91347074" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 04:55:48 -0700 X-CSE-ConnectionGUID: fCE30K8ORbC8nt6KjVq5fA== X-CSE-MsgGUID: 1PTJVs2iTxyFrz5Kn1lP5w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,241,1770624000"; d="scan'208";a="239663423" Received: from egrumbac-mobl6.ger.corp.intel.com (HELO ahunter6-desk) ([10.245.245.220]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2026 04:55:46 -0700 From: Adrian Hunter To: alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, david.nystrom@est.tech, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 5/8] i3c: dw: Drop redundant Hot-Join cancel_work_sync() in shutdown Date: Mon, 18 May 2026 14:55:16 +0300 Message-ID: <20260518115520.98335-6-adrian.hunter@intel.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260518115520.98335-1-adrian.hunter@intel.com> References: <20260518115520.98335-1-adrian.hunter@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Organization: Intel Finland Oy, Registered Address: c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Content-Transfer-Encoding: 8bit The I3C core now installs an i3c_bus_type shutdown callback that flushes master->hj_work (via i3c_master_shutdown()) before any driver's platform shutdown hook runs. The explicit cancel_work_sync() in dw_i3c_shutdown() is therefore redundant: by the time it executes, the Hot-Join worker has already been cancelled, and the shutting_down gate makes a new worker a no-op. Remove the now-unneeded call. No functional change. Signed-off-by: Adrian Hunter Reviewed-by: Frank Li --- Changes in V2: Add Frank's Rev'd by drivers/i3c/master/dw-i3c-master.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i3c-master.c index eb9a13a73684..c7030d0cd8a6 100644 --- a/drivers/i3c/master/dw-i3c-master.c +++ b/drivers/i3c/master/dw-i3c-master.c @@ -1793,8 +1793,6 @@ static void dw_i3c_shutdown(struct platform_device *pdev) return; } - cancel_work_sync(&master->base.hj_work); - /* Disable interrupts */ writel((u32)~INTR_ALL, master->regs + INTR_STATUS_EN); writel((u32)~INTR_ALL, master->regs + INTR_SIGNAL_EN); -- 2.51.0