From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47616494A07 for ; Mon, 18 May 2026 16:53:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779123216; cv=none; b=K4IcxRz8G5IdIRt7flnXKCjIIzYizWiJxThANk2RchMO3bRCw9U81812jz9z2/Xjg57Pl9hrRDw7sXZyANpA2LjfS39OYiscfGmQBXJyj43F781BZCrAQDG5NghMUk91SWQW/VlAFOU1krdA7hsgCaSyVglyMZEW66fjAlcX+AA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779123216; c=relaxed/simple; bh=URFYTieCVSZC7c5z09SQJ1b36jUaan5k48W0s0/ZCLA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nLachthfUBGGfUPDlOxgE8MQ3Il9E+p1zaufYSC1jxoo/nm8FkmGPtZpa2EsgbHomPPXgY+/NGqAFu2ANDyFy9niaHI87bBmN7xzNdHD61h62BG8BAaNPX64+EAIc6P4/7god6vaqFpC8O4kTFA5+DPBrdyfN1UlcxK50glfDYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rn1wewad; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rn1wewad" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-65d071aac6eso2128033d50.0 for ; Mon, 18 May 2026 09:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779123213; x=1779728013; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Qta+TGt8f8bCNU5lXsak/sMOHDnwEN56jda27IdO8xA=; b=rn1wewadbMdYNBApEV9E1quik05bze1uz5pNbmVDetrKQLcHduphxPpJqPOlzFz4Ha bemBwZR+M2j1Zy8C6IvX8LmT4YaYy/AyHH0TzZuB3J7P1Y72vmYNLnMWpcPrrZtZNVVe G0fkHM2WnxxnDqPyBgAvBhfew7mxF/OzaXKV+Z7rN1MK3VWDYYpHaPTqWApqJ2bn/EYJ kI2470hRWueZen/ObOtLjqSaH3TNn5QkaOlG/BLLlG20Wiamq6G17jxLIyYC8n8t3+Ze /0Ot75kKWD0FRqO88wdKxQLWSAmF/3XfEnckEH5P1zDnjArhGInQnOi5pyG+aEoX2oAa GYyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779123213; x=1779728013; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Qta+TGt8f8bCNU5lXsak/sMOHDnwEN56jda27IdO8xA=; b=aFD/kravk88GQ7keBnbRrNV4tQb/8grlJ0YkO7CEK+Upwz/jsSS4XaEzBnZOY05VAU NLFoNVCIQObQpWZSqFQTLr3K06joENIduGf6NOymxlcMjKhnVX56YAmrPNSFcpnZkZrV QRfSfomPPj/W232k8BZDwfwvtH1p7qki2CaX9xoToYdHjC9Iw1iQslCC41bzJeraKqxY 8bl0OleKMPOBaX5XtkMLcro/bx5xTFBMDks+6vkZHSyZp2R8caSKlx0X1sNNIyELsLPG 2fkIUtP2e6WffX2VyAxJj0f1VCI20s8254s9ZBZRS31dZBlAo1OuZ3sIxy7per3Ilpgz x6+g== X-Forwarded-Encrypted: i=1; AFNElJ+XrAVpgJ+ymQHXmbsn3D+Rmbt5g/vg5VKr7i/k0+eSmJ5jpQzLx/Y7P9k0yomzIx11AqgL8A3+K1tgq8s=@vger.kernel.org X-Gm-Message-State: AOJu0YyOhFzZ3XATDDA3gReSzz25i772m8vMXGU8SYAtlN++EXnfj4Ub H73NypfeOeqGUVIEI/LPpLwfUponNpLqGW0r37MjVfqlZqG1hzAyvTth X-Gm-Gg: Acq92OESes4rCXvV//siyiahLckW6F1w0mCeB+/sMblgDSc5EednMuzHg7D+6hM6D13 Ee37yza6MME9If5HVYS3neczy0T01bMAZ/WBrn092iAuPoS1ANU05mkp7iLpQ26dpocymjovsac /dDLiBLR5QmmR41PWCf6hT2HItKXd+qz7+qRQgvijGxn2O9knNZJnFIlqJUp6oIXu7MeVB0xMTR I8taEkeHepB6x8Yg2RnUZfEb4Kc9QBvXsCgLBlril/VhCyUgsQLHW2RX/FRUMpH9w3jaGHGF/bM 3D4IeoNJUC8xQ3CqZo3aBHZwURF0OSVWbo/iJsAEZdOons3fsLoulHRrDfwwbUAGw4kyjnPGDFJ gz1QIf10/r0t8YQ80zabH8AfGLbqLPXq+f5qhnzTiZV0bjTx6HG8XpEHHVzchnpUL3+83bMQZRj fB3a/uKPEOzsZD2D63VrjoCKhEgcp0t4elytuJEy4RbF0ctwbXlpnvfLFWUg8/bJL8LmAe27TRi Tmb60qjY0S4csiR X-Received: by 2002:a05:690e:1482:b0:651:b13e:f9ef with SMTP id 956f58d0204a3-65e226d2c42mr16777704d50.14.1779123213099; Mon, 18 May 2026 09:53:33 -0700 (PDT) Received: from localhost.localdomain ([186.151.100.108]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7cc965ab98dsm24232957b3.0.2026.05.18.09.53.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 09:53:32 -0700 (PDT) From: Sebastian Alba Vives To: yilun.xu@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-fpga@vger.kernel.org, conor.dooley@microchip.com, mdf@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sebastian Alba Vives Subject: [PATCH v7 1/3] fpga: dfl: add bounds check in dfh_get_param_size() Date: Mon, 18 May 2026 10:52:16 -0600 Message-ID: <20260518165218.35388-2-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518165218.35388-1-sebasjosue84@gmail.com> References: <20260518165218.35388-1-sebasjosue84@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit dfh_get_param_size() can return a parameter size larger than the feature region because the loop bounds check is evaluated before incrementing size. If the EOP (End of Parameters) bit is set in the same iteration, the inflated size is returned without re-validation against max. This can cause create_feature_instance() to call memcpy_fromio() with a size exceeding the ioremap'd region when a malicious FPGA device provides crafted DFHv1 parameter headers. Add a bounds check after the size increment to ensure the accumulated size never exceeds the feature boundary. Fixes: 4747ab89b4a6 ("fpga: dfl: add basic support for DFHv1") Signed-off-by: Sebastian Alba Vives --- Changes in v7: - Correct the Fixes: tag commit hash (checkpatch). Reported by Xu Yilun. Changes in v6: - Rebase onto linux-next. Add cover letter. Suggested by Xu Yilun. Changes in v5: - Add blank line after the new bounds check. Suggested by Xu Yilun. Changes in v2: - Use (size > max) instead of (size + DFHv1_PARAM_HDR > max). Suggested by Xu Yilun. --- drivers/fpga/dfl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/fpga/dfl.c b/drivers/fpga/dfl.c index 4087a36a0..4c63c7c85 100644 --- a/drivers/fpga/dfl.c +++ b/drivers/fpga/dfl.c @@ -1132,6 +1132,8 @@ static int dfh_get_param_size(void __iomem *dfh_base, resource_size_t max) return -EINVAL; size += next * sizeof(u64); + if (size > max) + return -EINVAL; if (FIELD_GET(DFHv1_PARAM_HDR_NEXT_EOP, v)) return size; -- 2.43.0