From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 895844949E7 for ; Mon, 18 May 2026 16:53:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779123218; cv=none; b=RgxtHyaILpKYLCC/SM/w4HVRVnq54OS+uGwdbEOVqD9jQFB5LnFsOT7OkbjwxmuSRHGdbasO9hjCZKbVLET3ShWmc6O/z7IcFRdX2YmQdJBKHgEOr6aGUM9V6mqQQAQ4p3KjbmJuNkHpgi4Md9/PKUUBBMs7SATENPnbkGQ6Sh8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779123218; c=relaxed/simple; bh=NBZHuKv2ldtGIWJAnz+NCfK2xasjAlOHK3ocGE6MaRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DA6ljeFTV4kq2lEJNsQfsyZrvDoWYDQ3m1pn/26laLezMqpD1RnTnYnXpND5VwOJtXZY+oVyDFlUOM5/ovDow0p8C2dyWKzp7Pi6Q7C61+VY1vSkEAZYNZjot6zOAiwUPAUgfTAed3p4c8wh2k659nZOcuuzBdPuSG1djDIZwpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sFbqnw/Q; arc=none smtp.client-ip=209.85.128.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sFbqnw/Q" Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-7b4ee3a88e1so20677587b3.1 for ; Mon, 18 May 2026 09:53:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779123214; x=1779728014; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=taXFjdWmYy69nXOR8QvrAj+hN3E0MfqomsmbUhRahH0=; b=sFbqnw/QVvvac7icwqA+B83l9++wx76rwbXAuqWO/ojKzdMas9pJCpQwc5fFaG9yBF EpktwLP1DXu53HAdD+Rt/vXkh+Tl6iKvbGHylxqTnlsk6QCsVVVPVmWuWHXZ3udTi4a/ bNbEo3XgVtulBKKnaXSOHTRgudEuDJOaxbU5O9Cc5ec7BdjM4TeH9n2ndSrTc+ac/zi6 AIaONSvERsb9IBsXntp/ubp5tyOG283t6h4KQB9WgaXIHlL4ZkA+TG2/fofRh2/pNRBd w9X5Ph5q7PAB6lKJGHarV1Yd+FHGOOc5dTTRuqEOybjtEasiImQwkYMu2t4/Tw+uqoVy PJ1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779123214; x=1779728014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=taXFjdWmYy69nXOR8QvrAj+hN3E0MfqomsmbUhRahH0=; b=G8Ik1clfEEAS9BLq27fmRT02dJxm02RxEirmhOcjwQvFAyJEVQJOfNRn9cguZ9zkfl mwozhCAxMDQyP73C9ja0Z7QY3ZB9f2os1I1lAzot7zu9eQM3VV3HU7XMQCgwFKk8yokF BlYufYoygJjL29CCszX1TKFLvJZDzscGsWUxfpIa0hrmyI85Af7fbqIgSHzRnfdWM5ic HFMmETOpnf2QN8wTVLM1+zo0Y48bhs2UAQwi7Er3kLzl7M20N32nc9U8Ez9bqiFOQEKE NJLlBJIMv7hP8McC8ufM/aCYWb2C/yAz5VxcBCWVkvL0bJ997QM98h31FtsMRNGtPvf2 QYCg== X-Forwarded-Encrypted: i=1; AFNElJ8GuJ5cUdQH/55gwBxaAM+KkfsGeQNnVSliUAz2Gar8iDQIaW/Kl4fD5Kk5a/wWJZXEe46pHvDSE5Y6L8k=@vger.kernel.org X-Gm-Message-State: AOJu0YxoJy36NDoq6xnCLYXh4TKNHldR5GoFYXQUHOAws0ChGTkrRWIf BeoEquUt56wkzK0NoTrnjNBEpNZH7tx9bEn7U/Ly9JVWzhqg8rw8oK8A X-Gm-Gg: Acq92OFrwGYeFL4zGMqGxT5HINwSMFrkM99IrPCnqVYJEgCcsnHP0/OsyuxCaIu7dvN ddrdE7PgOKbLqEYjP8pzHhb9gN3CgwbQx9zW53LnIfpMisdB+8moLxHoFxboXScAOT1IeBK0DoN GAwEoj6njOuWj9JS9df91NMC8qSuhmvZhATnx35v64QYWiDb6EwTG23/CkQ0V3ypDqJvdryo3Wn FKPJtaIc9BUm9Q9TJNKc7+aTKn6ns/ykuyBktawkeDctGo0zA+UcoeeXhV/06kg8Yi4nUs0i5Pf 00J262sMCsBgwSgojdt2l9M8dNDh0xTYeg0llFCLfky1e/mufOFdUpEixmujf7c+ywsYB+Uzmkj xhXwOqWXrUpwb2Bp8wqcZm9fQU1lKloMg8e86US4fF7KkPcS78Wj+76cHpM0/pb+RDDB1DsAhz1 ABiJYWc/4bgULf3muLFj0fhZmUd3Il9JUt6DA+yLpziwkEMfgDrBEe94UgRwG87ZE47l96gVPP9 S5R7VcKRgUZ0us/nxDcJQTmfrk= X-Received: by 2002:a05:690c:38b:b0:7c5:f6c:d132 with SMTP id 00721157ae682-7c95a967084mr182102907b3.17.1779123214581; Mon, 18 May 2026 09:53:34 -0700 (PDT) Received: from localhost.localdomain ([186.151.100.108]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7cc965ab98dsm24232957b3.0.2026.05.18.09.53.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 09:53:34 -0700 (PDT) From: Sebastian Alba Vives To: yilun.xu@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-fpga@vger.kernel.org, conor.dooley@microchip.com, mdf@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Sebastian Alba Vives Subject: [PATCH v7 2/3] fpga: dfl-afu: validate DMA mapping length in afu_dma_map_region() Date: Mon, 18 May 2026 10:52:17 -0600 Message-ID: <20260518165218.35388-3-sebasjosue84@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260518165218.35388-1-sebasjosue84@gmail.com> References: <20260518165218.35388-1-sebasjosue84@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit afu_ioctl_dma_map() accepts a 64-bit length from userspace via DFL_FPGA_PORT_DMA_MAP ioctl without an upper bound check. The value is passed to afu_dma_pin_pages() where npages is derived as length >> PAGE_SHIFT and passed to pin_user_pages_fast() which takes int nr_pages, causing implicit truncation if length is very large. Validate map.length at the ioctl entry point before calling afu_dma_map_region(), rejecting values whose page count exceeds INT_MAX. Signed-off-by: Sebastian Alba Vives --- Changes in v7: - No changes. Changes in v6: - Rebase onto linux-next. Add cover letter. Suggested by Xu Yilun. Changes in v3: - Move validation to afu_ioctl_dma_map() at the ioctl entry point. Suggested by Greg Kroah-Hartman. --- drivers/fpga/dfl-afu-main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/fpga/dfl-afu-main.c b/drivers/fpga/dfl-afu-main.c index 3bf8e7338..097a97eee 100644 --- a/drivers/fpga/dfl-afu-main.c +++ b/drivers/fpga/dfl-afu-main.c @@ -723,6 +723,9 @@ afu_ioctl_dma_map(struct dfl_feature_dev_data *fdata, void __user *arg) if (map.argsz < minsz || map.flags) return -EINVAL; + if (map.length >> PAGE_SHIFT > (u64)INT_MAX) + return -EINVAL; + ret = afu_dma_map_region(fdata, map.user_addr, map.length, &map.iova); if (ret) return ret; -- 2.43.0