From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A0D2376497 for ; Thu, 21 May 2026 09:32:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779355961; cv=none; b=Qx2RBOAFj6ClvM3nYMF4FScVC8pXh5PAHSL3X19oObyTi17scaRkxVnHHhU8MGtruRKH4barD1gj1fCBSUje8/4Ze+NwarbHS7jZLevKAw/o79pIt+J/+Zn+AzShWrNvEk+R/nWkryLrslUYXf9+DGInkoHm8LUZFTob6H8Of+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779355961; c=relaxed/simple; bh=+cDRlUu2QCzryvbzD7LTu/UqKMvAgylgZ151GWHmn6k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=W2TPMrHYLxnMW8xIYAjM1F6+0clDb2q7FF1ou18Ti2C4u04KOF7PrggKWx6Uxu2XkGljp2gV5wEE+5IGE0UdRiX4Lya7mh3lR4hA+KR6QUDYLMKiLhMT4Lr1cYNL3iVOOMCHEvblgnjhO/NuZqgWkhZb/bVpVTSo6LF+f4g3fwk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NeaxHbcU; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NeaxHbcU" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4903997fcb5so3763335e9.2 for ; Thu, 21 May 2026 02:32:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779355959; x=1779960759; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=9EVWPWIDSLM3eafPF6uEWUcBfdQa+Lwt5Bo7lrpafPQ=; b=NeaxHbcUjv1qYZEU3MDlDaABpJtefUbGhCq0MF5La85R8psTZc0NcWlnd9ymBF18in nJW+XbGDkbaR3Oddaq0XJRxbm7J+Zm+OeqCsVYoJVUdLcElbSGo9RdSdEDYR6yDxkJeW Oedq8XF94QXj07fKjJAuoZw2AQpKcXv5OMHMSqzTRyOYe1XPsL19IwkwdNsg87JMKwrL KjWn8f7F6pPZrPsJiZtokudgc2VNhX/+5Vk7m+AoFDs28y0sGoyhjD1DEbyxqlaxo/hF z+2A6Q9ND938/uUYrOaFlNppwUstMgXpYv4WzYfehGh2d5LCsWgcf901m0PytukBXvWK /JHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779355959; x=1779960759; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9EVWPWIDSLM3eafPF6uEWUcBfdQa+Lwt5Bo7lrpafPQ=; b=CYxLSpDpTCOb5uv4Fns3Ypgfgk/9dQlM+VgmEt1DFzUn+jr8Et5E+WJK2u8XqgdJed 5c3bD2YDaOFOx+Pv3KJnsasatfGFFNKn5ApWyrmh45czByAUJAvYwtQymSWI01/R0/Jx MBGhEbt4EH0h/smqXutKAx04EOE992AiS1uqCfN2IvduDHtoMU294PlbY4N0ER+I01VS Z6s7ANWPg1jIPhYdEHO8ezrKOO0vO0Cd+RdcIz1DrlK2RqgboI8Yl+EfTS0Nt0UVJ+Pk zXAeIR2rb6GvJomgRgVT+0S+CQNzmuZ7SCT6tsjJp41h/5JyxuPWeKAXJgWsI21JJ9g0 xiIA== X-Forwarded-Encrypted: i=1; AFNElJ9eejB3XrtTtaJMHqZ66V7skDj1dt3ckGGN14AT8w7Q2y27NLoMNQoPm37ydNiWHROTooxvJKZ8e8YWCSk=@vger.kernel.org X-Gm-Message-State: AOJu0YwR17BfbDDvNxJPxtRblo+7jm4RfBTsmMOHDy588BnkhXmjDLmC 7VQuyo3vZ26JQu/g2Ek0lqOnm6R/9SM/4ujvDqTXz/vRUHYSHu0pJHOy X-Gm-Gg: Acq92OHQfN3h02nkLK/rHeolr8cqSe9GExHtqdh9NyeeXho7ANQzDKxGdcFAUfnxpuY 2Cx/px3pAfncyaRWG7wwuxFvZ2DZzN91qUnIDmv7jceD8Tz4f2fP7bNpOfJCsmh1iVflIY72lna fD5+b6KE5FTaOPCMDojFQlNolRE6fUWCdDY04jDWNV/TsCFjzm7mEMY5o8sQEbgl6qC3F/Kcf6Z 4W0cqmSLlKw/HFEJWHfhuhZ6Vbjwuq5pfjm20MVffE0ozqXmbdtR3x+KviqRZxO35B/ym42B4af GRRpgsMmMK1jhgl4vgvyRgeDycI8wy+ADseh142Ez3d9MbnfVjJJd6p8MLmAZxlYmu0hej3gddW Qyv7tmgrT14syDxZf9zlBp8z4Rnd1O2mTorMPSXxGEpZL6g0h6xTwOtRyglrDjwn6Vr1emxRC2q J398m78j6dfnkVEh+RE76PCFpnpc20xj/wIL4oy+JBBTiO0KgV2iLFRP3sMNmmOkr7DWLB7tvJz hC2+2wN0e5j/g== X-Received: by 2002:a05:600c:26cb:b0:48e:6db3:ff33 with SMTP id 5b1f17b1804b1-4903605d502mr18288435e9.14.1779355958345; Thu, 21 May 2026 02:32:38 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903cae778asm11707075e9.13.2026.05.21.02.32.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 02:32:38 -0700 (PDT) Date: Thu, 21 May 2026 10:32:36 +0100 From: David Laight To: 2564278112@qq.com Cc: Barry Song , Qinxin Xia , Marek Szyprowski , Wang Jiang , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dma/dma_map_benchmark: fix fd leak on error and exit Message-ID: <20260521103236.747dceef@pumpkin> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 May 2026 16:02:41 +0800 2564278112@qq.com wrote: > From: Wang Jiang > > Close the file descriptor when ioctl fails and on normal exit > to fix file descriptor leak. There isn't a leak, it is all tidied up by the kernel. -- David > > Signed-off-by: Wang Jiang > --- > tools/dma/dma_map_benchmark.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/dma/dma_map_benchmark.c b/tools/dma/dma_map_benchmark.c > index eab0ac611a23..bdb8a837f020 100644 > --- a/tools/dma/dma_map_benchmark.c > +++ b/tools/dma/dma_map_benchmark.c > @@ -130,6 +130,7 @@ int main(int argc, char **argv) > > if (ioctl(fd, cmd, &map)) { > perror("ioctl"); > + close(fd); > exit(1); > } > > @@ -140,5 +141,6 @@ int main(int argc, char **argv) > printf("average unmap latency(us):%.1f standard deviation:%.1f\n", > map.avg_unmap_100ns/10.0, map.unmap_stddev/10.0); > > + close(fd); > return 0; > }