From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2B92407CE6; Thu, 21 May 2026 14:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779374081; cv=none; b=Mz9JT/WuWa9cFMG2tVSfgCWpmyW1agRf0bXptcYdyM/9hyr91jyoc9s6JOMCaKlWo63GLwINtbcCIgsOTWM9mlkPDfHiK+eRR2Bbt2bqnTU8C960WDB8CbD3TpCQcdMmHignuevgKgT3mNAn/OU7FC+Qndrwu2H0IxJT18iBRp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779374081; c=relaxed/simple; bh=/YKZkQU2w0xT9X6y4g6IAtKtOkJAVQT/NTHny/zpY+0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WUBLXDXDJsoNeAtg0AhzvfQHZfDfSNiS9UhIJejTCjRc8vp2FpBcm6y0Co7KLt+kwjBYAfxdJMdhQ5tbSFdfdnCfFs8bF8lbWnLNV5nwyuaMmFLucCV7wsJyrY5uIAxd4nxeNGkt+NUrg/ig/CCrJ8XOJamO+Ps5jZGiSkPW4kA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IS64a2PH; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IS64a2PH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 669551F00A3B; Thu, 21 May 2026 14:34:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779374079; bh=NwOzNgtGbmRdNv9xvtTz1sguHFhxD3l9rWcheeXYL1w=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=IS64a2PH6/REiXHI6VNWirE2NqkzSzWCIc4tb38kavuiH/RK+OTzAUFs9X47En1pW yss1y5NSvZ2aY9tVyugrwCUaqEJXgncShSlYeAjr89Num+YAtjAI3Tu3QSr7fVu4tU LqlFycjyRjV/LN9pgJUBq2RFCr7GvXJsToq/+YiOdEE6waCeQ7yHGxjUotCSptL/St Vx/Oan14SPL1BAIBxQxuQ1Jmib3P0zydUZRp6+abIUMyL/iUSk/v6XNjrFmee6cZ2x SejYA7L8VWeZfe08W/kCipDCvMnNOkbcmiV8m2rlteX4DwXd0myXgfgtd5zW8MXsdl Pc0R2JMLoc4+g== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , damon@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: [RFC PATCH v1.2 06/14] mm/damon/core: hide damon_insert_region() Date: Thu, 21 May 2026 07:34:16 -0700 Message-ID: <20260521143428.83157-7-sj@kernel.org> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260521143428.83157-1-sj@kernel.org> References: <20260521143428.83157-1-sj@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit damon_insert_region() is being used by only DAMON core, but exposed to DAMON API callers. Exposing something that is not really being used by others will only increase the maintenance cost. Hide it. Signed-off-by: SeongJae Park --- include/linux/damon.h | 11 ----------- mm/damon/core.c | 11 +++++++++++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/linux/damon.h b/include/linux/damon.h index b9370c1779cba..3acca7deb1693 100644 --- a/include/linux/damon.h +++ b/include/linux/damon.h @@ -1013,17 +1013,6 @@ void damon_add_probe(struct damon_ctx *ctx, struct damon_probe *probe); struct damon_region *damon_new_region(unsigned long start, unsigned long end); -/* - * Add a region between two other regions - */ -static inline void damon_insert_region(struct damon_region *r, - struct damon_region *prev, struct damon_region *next, - struct damon_target *t) -{ - __list_add(&r->list, &prev->list, &next->list); - t->nr_regions++; -} - void damon_destroy_region(struct damon_region *r, struct damon_target *t); int damon_set_regions(struct damon_target *t, struct damon_addr_range *ranges, unsigned int nr_ranges, unsigned long min_region_sz); diff --git a/mm/damon/core.c b/mm/damon/core.c index 7d1de6ff54eba..53b4bdd27b39d 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -256,6 +256,17 @@ static void damon_add_region(struct damon_region *r, struct damon_target *t) t->nr_regions++; } +/* + * Add a region between two other regions + */ +static inline void damon_insert_region(struct damon_region *r, + struct damon_region *prev, struct damon_region *next, + struct damon_target *t) +{ + __list_add(&r->list, &prev->list, &next->list); + t->nr_regions++; +} + #ifdef CONFIG_DAMON_DEBUG_SANITY static void damon_verify_del_region(struct damon_target *t) { -- 2.47.3