From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8673739A4B9 for ; Thu, 21 May 2026 16:55:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779382554; cv=none; b=cWk4mtj44s6ZZKbsx0b2URv1V6l5YgyIoc8ay4NGgsQK4+IQXMrKkBh1Hw4rTzZvGBQfFVhWFIVt7XffACgixnGvD6zRZdoHroidPS8Pa5UrGo1zayOngHMlFPzx6TEhq5V+WJrifuGSOkuP3at6IhejWZEp9RkCCzmVerRWc/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779382554; c=relaxed/simple; bh=KldFHpf/7ny0qHbOcWSEpAE4BwUxQP29kdNTvWDuo+A=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TZ+20q7RMOXqhk6h/cTZGZVNkSXhIopE+f0XMZ460Hh3Loe938CamMY3pLTyJy7F31Gmavkb9ytCq/EQ2nH+x9SMxNylb0Y9n8PM0fpQ1KLGoBnKSw7qQETZyMMyy+6i4vqvJs6cDjU396x0DfDNsHuZaWfhzXCYQMm4Ujum9CM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dgx3a7mS; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dgx3a7mS" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4891e5b9c1fso57184355e9.2 for ; Thu, 21 May 2026 09:55:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779382551; x=1779987351; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=k7qjfCSIVLPl5u1gIaO5P/Vio0n5VJVARL9FB7rXD2k=; b=dgx3a7mSidVDSbJa8ee7BNlwTVOJ8RrsOOuvRaXBnQRPQWYe1htq97CZDotoRpFEGS vZLQ5AL++03UT3CbfcatpCN6Xma3oj8NtPj3sE0kdw1cY+bsBAs5v56awiY9DNcWkmbn PEwxGRO74AK823L1lNklsdky20elw7jU/vnHzS7jFzVWCfSz3osqSq5uyoBT0EYyaHM/ QZZMiQmFSg2OSyLZldqqtTmqVAx0z3Cstf6XLILhcljjenFBDRznPKze08by5txg66Ip hM7ycyxZFaJ9nTvdwSl+JWLdHekyOw68zWwKywW342rFJ1Z5zfmdTpF7aGF/pocLkvRF atMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779382551; x=1779987351; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=k7qjfCSIVLPl5u1gIaO5P/Vio0n5VJVARL9FB7rXD2k=; b=WNMP7v1MJyL++AMAOgoULKBCW75NjN4957Cdf09TalUMfkUZCjveKn8yYUXoBynB8h cgXch1Vj0R3gb1ww2+1Ar4QdB3nEhOBCij9KouGOQ2hQXxLeS2bZj0OH8rj72CJghEDr +d6FZyEwblY4chzeB7G9YLFawLshtrQ65JpFR5jlSz23ViQog+J09G7stzyNg8xwAMSb 6/WsuAeTGR3YvP+swq5VUVIyRNYOVzQTF3MklaGQjoiS3zc70dRgBrB6bIB6ErfKgXro sYRmbWfONH0DScE5PkgZEYLV3aukBmsAsmxiocAqbMyp3avYKlQ9JmXi0ea2FGujlzb5 MVUg== X-Forwarded-Encrypted: i=1; AFNElJ8vZIO3adb4z/E65baYbWM3U6E2jJ/K8qST/b/Bl9zGUb0cgt89UrVTbAHca9G6tfBStRTHGnV/7AuaqCk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2QvSpZhUfw5F+eJC8ExKJCmzeU19uEywSZgswAWaXcJQ4xvgb Ps9GyRlx6avw/lnhJLJpPt3kQYMp0LPSVAAi1jAnyFYIlQocvBsHmyQ4 X-Gm-Gg: Acq92OFV49MJ80djya6jrkfM4Mndp+mOz/ueAgPkzKqUYNeGQBbhIbCqHXf74STjzgf +/qOfoUzfjWXiOEJ0stagi7r8suG8VssUtjdQ0HjJLP99GCfOZhUzjY4XqOwiC3wTPVVZS7rQmR om5l2wCylCF9DNp6gAS5l2MMxNImkOpbih3QPOHsDl0exmAqJCBxvB2EatxSIjKLxS1Iy+hE0Vf cMLSqAKez4gbn70Db9hq6dpdvz5969PFUT0+Y5feDQbD6erj3ISGdl6f07aYv3OyKTGJ2QkGKk7 yTEey9zGL92n6CVNyFVaGC3vRVXxGfpH1hKEwGFxdHmAhac+s0WBd+1wyNFiov4t1jZiHMaOGag hC3qlOmfeyb7T5UGnyQ2ZJA0hfbShCCymrFvQN8imuiZPbt2GlwdH74FX5v4JxlZYAi4J6MjSl6 POpCZS9QQsIbJ8no+1/kLZMx7W+/jcM3nUmn7EO0Uqoup00x/xfthjdLx52Ni2Hwq6 X-Received: by 2002:a05:600c:4513:b0:490:3cd6:db37 with SMTP id 5b1f17b1804b1-4903cd6de06mr36938395e9.12.1779382550722; Thu, 21 May 2026 09:55:50 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49033d3515asm86408645e9.1.2026.05.21.09.55.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 09:55:50 -0700 (PDT) Date: Thu, 21 May 2026 17:55:49 +0100 From: David Laight To: "Maciej W. Rozycki" Cc: Andrew Lunn , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes Message-ID: <20260521175549.70c27369@pumpkin> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 May 2026 13:45:26 +0100 (BST) "Maciej W. Rozycki" wrote: > On Thu, 21 May 2026, Andrew Lunn wrote: ... > NB as I point out in the cover letter I made sure there's been no change > to binary code produced, so I expect no fallout, and as we discussed with > Jakub the removal of the driver broke `git blame' anyway, so there should > be no cost associated with the cleanup. Can 'we' make sure that the commit that re-instates it has the git tag of the old version in the commit message. That lets people go back across the remove-add. -- David > > So as I say, may you both please weigh in pros and cons and let me know > of the outcome? I'll then proceed accordingly. > > Maciej >