From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CD423D9DAA for ; Thu, 21 May 2026 17:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779383635; cv=none; b=JZFvIji/i74xATswdT9QyJ0CHrZiVrPWmRLS0bDnrdLXSSJCAwTnNMt1e7AjC8a3bREqMKYYY778NOh5Og1qSVaSTLBVrwL4pfuYVZaYcGiAHDP01YO5iQFiGPIBBWWpMk3fOX73EupPGFWpscEnbMxt17F2QE1RnI3vVBjj6w8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779383635; c=relaxed/simple; bh=X9MG1kwNUf8O8KAK/Sm8SuGe/dZdaTwPaR1MzEF3AHg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=ClvOkvRb4agSCPyWdJsGm6QqAkYOy951O5m0mlQg8pgMS7fmchSXqypyuQCLRuKmaaZQaEiBqJ3D3KCkCon3N+vl+v5Piwf33WDo1PdscwLnKfTHNGudLSZEeeZQY7iVdgzy+UhHU4HcCljdwkE28G07jcu4OAjRy913bXzLws4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nzBH2mki; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nzBH2mki" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-488b0e1b870so89652095e9.2 for ; Thu, 21 May 2026 10:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779383631; x=1779988431; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=zIuChPU1JlP7AlPyeu7nnCYpBOhiwGUpJRXAIqjmuvM=; b=nzBH2mkicctXAN/292q5htBM8uJbtgNpVclJmeiZKdI2qZBJzQP7W0t8OkfXqX86a+ U9FNJkbdGMFuH1WuT5mjjd+aXL57+dA3HUPOPJrdtueEf8H/PeHL0dfOiBJdv5ZdbUEc DEEd6F5mW+px4Cqdq3Z4sWqqWrHweRIdrrYt8k6W735dfAkvHALNt/obFyNQnGDjTwam DKE5qj2VWkcmqngZnzjza3NOZoIjJHPK5GDe/CQnpCNJJJ9h6JdmWI67EqhKVibqNKPT Z0100IzuYtrGo5eGLQMg7cgIc46ZruFAZAvLfMipIL0nLAsXeq8fTQRgHMTfwqNE6MMu bkSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779383631; x=1779988431; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=zIuChPU1JlP7AlPyeu7nnCYpBOhiwGUpJRXAIqjmuvM=; b=ZY8l6Yerltqlo7OQYn1MdfNwWGzbn7VViQaHiPqt/rb2+aQYoYwuYUOp9ekwB9Z7ek iFCJ7jAuTFRyM+R5jd567oGTrPfqWvt9Fo4fW3hPelCkqn13LDYkGK4nl2ZYLqwT9uJ1 849We0fCwXXg65DHK3wX4b0vt8VMdHS1F+VkkM6Xl8J83XlYkTZ+fJi/IYqcMsbkf3Vw SFIJNSe4pt1DxldldcZCajohO2UPf2I6PovHKuw3hzbBb6pmDVa63mdSez+RJlT1e8TM ZDcnkGdVsBzXdGu5AjCTVb6uqo3dkjoDj820WEqG/iOLcV+w24Ev3ZRJJhnluprZO0Rx bZww== X-Forwarded-Encrypted: i=1; AFNElJ9+aCMXyif80GH8vp2Jz1la2e0bsJC6NJCslJy/6Gc42XWKkULrrdY5IiCJIdst1pbz0fWG6FehFKx/xn0=@vger.kernel.org X-Gm-Message-State: AOJu0YxXGKgaSY/SOVaX+3KOPaK4g4lFANIZbV6SigC5zY3YIK/zIBef r2aie8JASwzBfHEBXt4iQ/Vj2yhjovEogpKwa4C7Ql7U+9X5+0/hRUsz X-Gm-Gg: Acq92OHhgW9m7T6NZ1eiPnuhyjElxPDLS4tJwwTqaf7HV1v6qJpjuzWtTR8W2SUjC6D Mr7qZDuhCb9j9ZEDMVRmDTGXf9ubZB7Xb2cL2TvTBTEWw2HU4aQbXHGbVMRF/bIaRxdXn2dT+dR Y6bifjmgkAerZDnhUFMeO8Bv6wHuUScuWF+kFMz3l2Yd/9d5Qtxvkwa5CMqpJSllgBYPbwg8UaY 7RNfFjTCYdkQuw6oXuLnUtx/tiGzN45EJoFoJHZ6kOq3XzZN4EtYHqpNQdbWFaJFh8R2DkjYtFs fWAmJ+2sDml0QoS6WYsouAyRKrrciXXXZeyPqHf0ZSpsA46BF1v6fOpsRV195dVQJOGOFw7K3Ru degZdRsf9J5vTPard271HhmW3eZyqOYylQQOwnjoeT3o87xDcCuRLrbrxFdgTbzoYv3iwr3Pw61 C3I2vBZy9r554rkM0gXf9JvCEzKxrW96WrlNKSG1UDPnNJbODGGX+vPb4efzdiwYhQ X-Received: by 2002:a05:600c:828c:b0:485:4eaf:eb53 with SMTP id 5b1f17b1804b1-4903606b5b2mr58827015e9.19.1779383630691; Thu, 21 May 2026 10:13:50 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eaa7cf23bsm4086708f8f.5.2026.05.21.10.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 10:13:50 -0700 (PDT) Date: Thu, 21 May 2026 18:13:48 +0100 From: David Laight To: Stefano Garzarella Cc: netdev@vger.kernel.org, Xuan Zhuo , Simon Horman , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Jakub Kicinski , Eugenio =?UTF-8?B?UMOpcmV6?= , Paolo Abeni , "Michael S. Tsirkin" , "David S. Miller" , Jason Wang , Stefan Hajnoczi , Eric Dumazet , stable@vger.kernel.org Subject: Re: [PATCH net] vsock/virtio: fix skb overhead overflow on 32-bit builds Message-ID: <20260521181348.3d61858e@pumpkin> In-Reply-To: <20260521124732.125771-1-sgarzare@redhat.com> References: <20260521124732.125771-1-sgarzare@redhat.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 May 2026 14:47:32 +0200 Stefano Garzarella wrote: > From: Stefano Garzarella > > On 32-bit architectures, both skb_queue_len() and SKB_TRUESIZE(0) evaluate > to 32-bit values. The multiplication can overflow before being assigned to > the u64 skb_overhead variable, making the skb overhead check ineffective. > > Cast skb_queue_len() to u64 so the multiplication is always performed in > 64-bit arithmetic. > > This issue was reported by Sashiko while reviewing another patch. > > Fixes: 059b7dbd20a6 ("vsock/virtio: fix potential unbounded skb queue") > Closes: https://sashiko.dev/#/patchset/20260518090656.134588-1-sgarzare%40redhat.com > Cc: stable@vger.kernel.org > Signed-off-by: Stefano Garzarella > --- > net/vmw_vsock/virtio_transport_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c > index df3b418e0392..71198bf23fc4 100644 > --- a/net/vmw_vsock/virtio_transport_common.c > +++ b/net/vmw_vsock/virtio_transport_common.c > @@ -417,7 +417,7 @@ static int virtio_transport_send_pkt_info(struct vsock_sock *vsk, > static bool virtio_transport_inc_rx_pkt(struct virtio_vsock_sock *vvs, > u32 len) > { > - u64 skb_overhead = (skb_queue_len(&vvs->rx_queue) + 1) * SKB_TRUESIZE(0); > + u64 skb_overhead = ((u64)skb_queue_len(&vvs->rx_queue) + 1) * SKB_TRUESIZE(0); I was thinking this should use mul_u32_u32(). But that is all moot. 'skb_overhead' is a memory size in bytes, 'unsigned long' it more than big enough. No need for 64bit maths on 32bit. -- David > > /* Allow at most buf_alloc * 2 total budget (payload + overhead), > * similar to how SO_RCVBUF is doubled to reserve space for sk_buff