From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F7A334B194 for ; Thu, 21 May 2026 21:55:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779400541; cv=none; b=EiJGvoAHXywqaySSIhDzDxNeQOUBG13rerUT9IXuje7utLgmciK4mm9sfKfMH40ggcpkA6qXhKgxRsuxASdzOaH+81s+maw3MSFx/qIwjYGqn+cEHIRi8yrdSnSy5eJax5M/L1gyERYinqk6LheQPIbPisrB+ROWpuLwuR2WNIk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779400541; c=relaxed/simple; bh=5cqPB3+SwRfBO8Ct4IGJehGsBMhMU2/xMj6otSkR2VA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=txzVG6eGKi3ssf+cxtxqhiv61A0Dv6hYsamSiURJ2L6E2FAoHw0QUEKWVBFi+JjsLzWs/HiHlYCoFwrgvp0FvkOQN4ljXBOGa4XZHCcX0nMyhmi9Y0t2EGQx8O11IrkPu7/IoSohQomVqzqnTtnFAeR5WY9eCHr41HNUHLiNkWQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nrrcCKHs; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nrrcCKHs" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-49041e84237so1507375e9.1 for ; Thu, 21 May 2026 14:55:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779400538; x=1780005338; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fjS78Z3Qswu8i7cXKtkfbhBl7RI0zMzp/ofF9gwFPs4=; b=nrrcCKHsM4KoZUGqct6ghA9IxBmcauY4sxujCG4si5K9kQfRAVo09vRVTze+SkDHK2 E6VxSc8HZINHY3REZ1Q/IDtuK0INo8Ib//MTXSxrnq8VlFcBJdbF+dVyUds5e0v8GMki GVaH0Wn1PQ5cFiz7pWMYqmRkgNInzVXsFvxeZsf1MvSKIu1qDfpRkr872AFtuJ/gF7Jd vUv4xUorPLPbaVPK41ZhyJaiLUQeIFOywJDZCpa1+NC91wijmSKMlFFJVIncuPHXeuAm Vjfh7XyVKoE9K9oDZ6xvjiOQ7lRTHFUjFQmSg/kSt2dr1pKjbkEYEB0+ntLIFjKOG/Um Levg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779400538; x=1780005338; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fjS78Z3Qswu8i7cXKtkfbhBl7RI0zMzp/ofF9gwFPs4=; b=sdjqQxNlGGkCGa0St6j9IbofSnX2EARO1txZxr0oUiwA7mpEQTIsChvzAukVeqPvqc JjReUx7we9xGnkAA6PHILWBFAXqBv9tFI34VyMbtnjhZMC/kjt72mO8D1o+Xd78YXxeD h1NqJfPe3ndUes29Cle++TArbPCnIb5YsY+DESxCx3FKEV8dFXeOKb2DA4TJxZhRFjhH efHA+DjJNptvSoz1huHTx3wmh2lbSh9hLT3mAPgFmeVdCzrGXjlDgSO8VNOlKJo0FaWG diilPJhRRbg0ENaR8uq6+BweO+5vEy3o43xBOkBAsaAc8P5eJhOE7GgnbSlJM1mhrihu 11aQ== X-Forwarded-Encrypted: i=1; AFNElJ9bjDz4wM+8S39JDBaj8aENwQlAXNTjoAUVH5R1pe2bKOc/ZDTRnOKkeJ28dIX9Dms82LTEc+lQo0M4sMs=@vger.kernel.org X-Gm-Message-State: AOJu0YzyXyNAgB7VPkOW/9JGdswK5eKhGfRs4p18PWnH3ZT8ljag9l6H FDaeR2qaUX2XoDk2ezm44/vTzLKXS/2oxSdBiKwk3pmcggTMqrzDxufN X-Gm-Gg: Acq92OH1hO4eIpTAdXSr1i/bs/Fd9uQZ4BQzRphRtctAeu71JQVNgoTogYDHpVEaIfW JdE/TIsAp1pNM39U8YihyLnyjKIrkWPUzXWpH9QhUnkwq2i8tY/Ep/o2HIcQfop3kFn87R6+jU7 uFRVrDjjQRp9E0IaQHkkxf2OnH8azUEs1B1As3N9wgmf0iAOsaDsqknxvzr1+lS2uWWKJZ43/Dk upJwg+SO+Eum4aqkxA6hz7eT9zNYrKmNWuf2VnaUlOUcB2Aw5DPzLgS4Ur/74+Pbh4rDwp0xqT7 GY7brm8ExTOOxFvhJH4vgOP6F+TQI/siN6/QFoF6ziOO9SN0qCvrPj/DN04nVDVRsDs1I0JYzyK fTEn9aq3Vuc+/Uu9d72wsRfCXBCIdJHsPPeokteYsJgQXXXOhbBXefBFsdoz/T5Pe7+3TwMfrT5 U08LeHfczR1/5N2QAwGKeyZ3wPNAl/NWsng5vRBJai1pWxHJC+iOR70Z0lR+5OyQ0txRp++Hxoo /w= X-Received: by 2002:a05:600c:1c0b:b0:48a:53cb:8604 with SMTP id 5b1f17b1804b1-490426a495amr6525425e9.14.1779400538508; Thu, 21 May 2026 14:55:38 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4903c9abbadsm52437075e9.8.2026.05.21.14.55.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 14:55:38 -0700 (PDT) Date: Thu, 21 May 2026 22:55:35 +0100 From: David Laight To: "Maciej W. Rozycki" Cc: Andrew Lunn , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 0/5] ethernet: 3c509: Bring driver back and make some fixes Message-ID: <20260521225535.3f60f0f9@pumpkin> In-Reply-To: References: <20260521175549.70c27369@pumpkin> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 21 May 2026 18:49:52 +0100 (BST) "Maciej W. Rozycki" wrote: > On Thu, 21 May 2026, David Laight wrote: > > > > NB as I point out in the cover letter I made sure there's been no change > > > to binary code produced, so I expect no fallout, and as we discussed with > > > Jakub the removal of the driver broke `git blame' anyway, so there should > > > be no cost associated with the cleanup. > > > > Can 'we' make sure that the commit that re-instates it has the git tag of the > > old version in the commit message. > > That lets people go back across the remove-add. > > It has all the usual `git revert' stuff. Have you anything else in mind? Not sure :-) But you were suggesting it would break 'blame'. I know a 'delete' then 'add' gives serious grief. -- David > > Maciej >