From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75A601DE2AD
	for <linux-kernel@vger.kernel.org>; Fri, 22 May 2026 12:14:06 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779452047; cv=none; b=RHaWHWmhqM8Blw5hhcotj6BvFkoyXZSTCfLoB5eG2NtSCIzgZG70PUhBMn0qVeHvcdhOfi1dAo2Jum8/e5nltNVEIit1PMdU8PrCupSwR9u9OwbgWyAgbEppoZBD+Z99oyQi7w0kX0/4McXHAK+TAkX9lufn6njrYOn44sdQP1M=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779452047; c=relaxed/simple;
	bh=8sa/VijUWQw8URKPOPvjl2sqHWknScRmgLg9Ep/M9yo=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=JgbG8N8aU7WCFtiqRLTOnIc+80ZUY0DctIaqX8eEy0rF7WcHz6znP2nLMp7+xkvv4fayDShIwJQQPlYNP/VCoH7FuFE28yQJ+whKrkAM7xicKBe2ple/3Zgu+gp9nmFFWeN0DCkCqyGPucFNzVaD7hECMzuZsJaPWrbrajnWj8o=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id E7F5E68BFE; Fri, 22 May 2026 14:14:01 +0200 (CEST)
Date: Fri, 22 May 2026 14:14:01 +0200
From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Chao Shi <coshi036@gmail.com>,
	linux-nvme@lists.infradead.org, Sagi Grimberg <sagi@grimberg.me>,
	Jens Axboe <axboe@kernel.dk>,
	Tatsuya Sasaki <tatsuya6.sasaki@kioxia.com>,
	Maurizio Lombardi <mlombard@arkamax.eu>,
	linux-kernel@vger.kernel.org, Sungwoo Kim <iam@sung-woo.kim>,
	Dave Tian <daveti@purdue.edu>, Weidong Zhu <weizhu@fiu.edu>
Subject: Re: [PATCH v2] nvme: reserve a keep-alive admin tag for all
 transports
Message-ID: <20260522121401.GC21338@lst.de>
References: <20260515071248.2689513-1-coshi036@gmail.com> <ag4Y5R1X0gkZbU-g@kbusch-mbp> <20260521082549.GA11208@lst.de> <ag8Y5c3sjYFZzan5@kbusch-mbp>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ag8Y5c3sjYFZzan5@kbusch-mbp>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, May 21, 2026 at 08:38:29AM -0600, Keith Busch wrote:
> This command is already special since we filter for it on the completion
> side. We may want to selectively filter other Set Feature commands too.
> For example, we don't want user space turning on Host Dispersed
> Namespace Support, because this driver is not going to correctly react
> to that one either.

True.  So maybe start filtering out all these things will go wrong
commands.  Chao, can you start on that for keep alive?  We can then
extend it as needed.