The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Andreas Klinger <ak@it-klinger.de>,
	Andy Shevchenko <andy@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v9 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property
Date: Tue, 26 May 2026 13:31:35 +0100	[thread overview]
Message-ID: <20260526133135.318b3ded@jic23-huawei> (raw)
In-Reply-To: <CAMB+xka2uJqf3E69r7XhB0LEkT0bWy4XCW2rCztTST9JX+KYaA@mail.gmail.com>

On Sun, 24 May 2026 08:12:13 +0530
Piyush Patle <piyushpatle228@gmail.com> wrote:

> On Wed, May 20, 2026 at 3:39 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Tue, 19 May 2026 03:32:18 +0530
> > Piyush Patle <piyushpatle228@gmail.com> wrote:
> >  
> > > Document the optional VSUP supply used by the HX711 on-chip regulator.
> > >
> > > Signed-off-by: Piyush Patle <piyushpatle228@gmail.com>
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > > Acked-by: Conor Dooley <conor.dooley@microchip.com>  
> > See my reply to v8 around dvdd needing (I think) to be in this patch
> > for the hx711 not later in the series.
> >  
> > > ---
> > > No change from v8. Already applied to iio.git testing branch.
> > >  Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > index 1ea60dff98d5..a8eaa1f18de5 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > > @@ -33,6 +33,10 @@ properties:
> > >      description:
> > >        Analog supply voltage (AVDD).
> > >
> > > +  vsup-supply:
> > > +    description:
> > > +      Supply voltage for the on-chip regulator (VSUP).
> > > +
> > >    clock-frequency:
> > >      description:
> > >        Controls the SCK bit-bang timing. The value is used to derive the  
> >  
> Acknowledged, and sorry for not acting on this in v9. In v10,
> I will add dvdd-supply in patch 02/11 alongside vsup-supply with a
> description that makes clear it is the digital input supply of the
> HX711 (and not just a bypass capacitor point).
> 
> The description will read something like:
> 
>    dvdd-supply:
>      description:
>        Digital supply voltage (DVDD). On the HX711 DVDD is a board-
>        supplied digital rail, distinct from VSUP; they may be tied to
>        the same supply or driven separately.

I'm not seeing a reason for this extra text.  The standard nature of a supply
being present covers all this. Otherwise we would not have it!

Fine to have a bit of this in the changelog for the series + maybe
briefly touch on it in the patch description.

Thanks,

Jonathan




  reply	other threads:[~2026-05-26 12:31 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-18 22:02 [PATCH v9 00/11] iio: adc: Add support for AVIA HX710B ADC Piyush Patle
2026-05-18 22:02 ` [PATCH v9 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-18 22:02 ` [PATCH v9 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-20 10:09   ` Jonathan Cameron
2026-05-24  2:42     ` Piyush Patle
2026-05-26 12:31       ` Jonathan Cameron [this message]
2026-05-18 22:02 ` [PATCH v9 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-18 22:02 ` [PATCH v9 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-20 10:19   ` Jonathan Cameron
2026-05-24  2:45     ` Piyush Patle
2026-05-26 12:32       ` Jonathan Cameron
2026-05-18 22:02 ` [PATCH v9 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-18 22:02 ` [PATCH v9 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-20 10:23   ` Jonathan Cameron
2026-05-18 22:02 ` [PATCH v9 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-18 22:02 ` [PATCH v9 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset Piyush Patle
2026-05-20 10:24   ` Jonathan Cameron
2026-05-24  2:47     ` Piyush Patle
2026-05-18 22:02 ` [PATCH v9 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-18 22:02 ` [PATCH v9 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-05-18 22:02 ` [PATCH v9 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-20 10:31   ` Jonathan Cameron
2026-05-24  2:55     ` Piyush Patle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260526133135.318b3ded@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=ak@it-klinger.de \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=piyushpatle228@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox