From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6BB52C0F84 for ; Thu, 28 May 2026 05:30:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946237; cv=none; b=AiqDuYDb/0TO9KiIoDa7uJ9FwTZhOYANX57bvGFsq18gEkfOQi8lxg7EnwYps+a9qP9QZnkHTX4PjDmKCtjwitlIYjGXghzmM8d+vQLyY9dOxmpDkgFzDWmdaQvmEeeEOABQozZSdNHYc9HNiKtqZrZ4U8aTffo4WTjdkLRxa+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779946237; c=relaxed/simple; bh=Bjf7hN3TI8rBFo86J3VB/I2bXgASxc3O0HsCfJhlguc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=brsvsw0qm/1M05/7toxPYGlhZcpejH1dJnuzQPm4+sYBVPFZ3ZylVD5Uv11bWsCDWzzerXsxK6tDM2YxVwqnWnj7moizdZuxw5fGOkacaQ4WcvnPTFr2DwbNKNixQYVT/iM+vUDpb1gcFFwOrx8etYxGK9x6iwzaqbAGHr2HuH8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jIh3IE6S; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jIh3IE6S" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c822652f82aso10145733a12.3 for ; Wed, 27 May 2026 22:30:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779946235; x=1780551035; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=llv9eK39iuv/ZdjHyRDnfcx6/aCeoNvT9KJ0UUI6ILE=; b=jIh3IE6SPpXt+sV5tXZ5+3zvzfXUp2qbku+Qihf53v/4pTI5mKdmCycB0aboYjaaxE hfAb4zowjJcF7FwXlPAQ2KnUrbDP8ISvo+h06xwvVDoGil0jTCrQzpiSe70MgeRLbtsf rqq6Hn0+XHb4jT/yjt+DG6l00xAfrPwFw0a2MK+WKKgUNBt5MPQIIRG/QzwBVFA/w4K7 IMlgLMUE0DIbxiakgK34LUgKWzpE2ZY5OYfYZmdF+rYwoEDu2i1o8ra1di+DmN1UJi2S oHD3PB3BSdX0M37ekbeWWCR4QU8+5HHJ8ZhnAAgG1stuJKnGQ+UWPklQE+M3WNu5V0EF nxfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779946235; x=1780551035; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=llv9eK39iuv/ZdjHyRDnfcx6/aCeoNvT9KJ0UUI6ILE=; b=tRhVlCurGexBAGgnE8oPbkW8qpTUbObj1cdN+rRteQyv+okcsKxrBtnlwiztso+KuK eLrqP83XFuZ8+xiuj7CcdkHiig66inBb+/WBiILWjPgfMs3ApSOtsC4VOdSeSP5sik+Q MakHL2vqAnAUyAvnUFicijE7g7Z5Cju6Ml0BiHSvbGa8rz0f1Un/qXXvUqrjCeLDj59x /6hsHIoiWThJh3oXZXCmdLVjRhfSLA/vXwKqubmCCv9I1friAk+goC1v+2jgpTPL4CTB vfvnn7Ylmg7oGRTYxdpFy2Zen6xU/fAmxhH4irrELp1LC9LuvIAi+iQ3kF6re/0OF3A6 Zs2Q== X-Forwarded-Encrypted: i=1; AFNElJ8gvClirjAdvXoadJQ5EClVSMWx1SNWzEI4Tey72iA5gJM7YDW1DWaihXs/fypSUngSf/dvW20xaJ9brds=@vger.kernel.org X-Gm-Message-State: AOJu0Yydq+M4OzHlsTKrTthxNo4MWIqT6HaDe9uEmY9pvYfG/stYaq1X SC20z9RbbXOEDknJJO1V1wwxGJufXFDouzaicIETBfbchzLQLQr/47lR X-Gm-Gg: Acq92OG8q3JCPYZ7+t2a//WQnsONfIZ7YKctefMorQEmBLRvK2ZMJ0B9kUG3A1sBXMX CPUWFBv7t1qlCDCzclfqugas9tFNQUwvNnXACzrJFZopTfOT3h/EYbpED/8gs1LlAs/4cfeqEu3 0TCZGpCvKU4PhiSMKtWwOvdWS/tohtm7mVXS/BDAzv9CeJ0mo7qKAlKe/YRsWeSY9KWf8+BqcLu ZJ/eHduJkzPXk3D3O6q9cuGdY1Ov875Bx4Fh+es+wQCpxSuIIiMqHZK9BWJcEV9+k8/ZLCfJovT yYu4ZAJ3bEg8SY9MC6Cd2sXDLUWXFDxhLMCCoR+JYdd6z2SVijioiqj2COFt7MEnYAi0iaxylt9 cKi4F0fdeipBxM9WG9Ipy+TXHXEyk4sEl/stj26ehNjNx4ITylrmg3VCrDCn0jp9osl73MxKzeK dIF6nsKq3goEG2SgKGB8xVaKVmlFQZPcp9kpD4pLLp7EvtogAIyns2JiDyR5V1Rf2erjip X-Received: by 2002:a05:6a21:3a87:b0:398:89b6:1b41 with SMTP id adf61e73a8af0-3b328ecee16mr26618669637.32.1779946235169; Wed, 27 May 2026 22:30:35 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c852056dadasm13739450a12.26.2026.05.27.22.30.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2026 22:30:34 -0700 (PDT) From: phucduc.bui@gmail.com To: Mark Brown , Greg Kroah-Hartman Cc: "Rafael J . Wysocki" , Danilo Krummrich , driver-core@lists.linux.dev, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 1/2] ASoC: sti: uniperif_reader: Use guard() for spin locks Date: Thu, 28 May 2026 12:30:21 +0700 Message-ID: <20260528053021.46157-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc Clean up the code using guard() for spin locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- Compile-tested only. sound/soc/sti/uniperif_reader.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/sound/soc/sti/uniperif_reader.c b/sound/soc/sti/uniperif_reader.c index 05ea2b794eb9..45d7613f595c 100644 --- a/sound/soc/sti/uniperif_reader.c +++ b/sound/soc/sti/uniperif_reader.c @@ -46,15 +46,16 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id) struct uniperif *reader = dev_id; unsigned int status; - spin_lock(&reader->irq_lock); + guard(spinlock)(&reader->irq_lock); if (!reader->substream) - goto irq_spin_unlock; + return ret; snd_pcm_stream_lock(reader->substream); if (reader->state == UNIPERIF_STATE_STOPPED) { /* Unexpected IRQ: do nothing */ dev_warn(reader->dev, "unexpected IRQ\n"); - goto stream_unlock; + snd_pcm_stream_unlock(reader->substream); + return ret; } /* Get interrupt status & clear them immediately */ @@ -70,10 +71,7 @@ static irqreturn_t uni_reader_irq_handler(int irq, void *dev_id) ret = IRQ_HANDLED; } -stream_unlock: snd_pcm_stream_unlock(reader->substream); -irq_spin_unlock: - spin_unlock(&reader->irq_lock); return ret; } @@ -355,12 +353,10 @@ static int uni_reader_startup(struct snd_pcm_substream *substream, { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *reader = priv->dai_data.uni; - unsigned long flags; int ret; - spin_lock_irqsave(&reader->irq_lock, flags); - reader->substream = substream; - spin_unlock_irqrestore(&reader->irq_lock, flags); + scoped_guard(spinlock_irqsave, &reader->irq_lock) + reader->substream = substream; if (!UNIPERIF_TYPE_IS_TDM(reader)) return 0; @@ -386,15 +382,13 @@ static void uni_reader_shutdown(struct snd_pcm_substream *substream, { struct sti_uniperiph_data *priv = snd_soc_dai_get_drvdata(dai); struct uniperif *reader = priv->dai_data.uni; - unsigned long flags; - spin_lock_irqsave(&reader->irq_lock, flags); + guard(spinlock_irqsave)(&reader->irq_lock); if (reader->state != UNIPERIF_STATE_STOPPED) { /* Stop the reader */ uni_reader_stop(reader); } reader->substream = NULL; - spin_unlock_irqrestore(&reader->irq_lock, flags); } static const struct snd_soc_dai_ops uni_reader_dai_ops = { -- 2.43.0