From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [91.218.175.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E37E3B4EAB for ; Thu, 28 May 2026 09:53:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779962008; cv=none; b=kmw8VOVi1VKjhUJEAUh6wW6Tcnif1qJxRR8cThdA8WZChfjJZO1QyaJ2+EKgxXbqKgZhWlpADbiwC7OYE8wKADFmYFgLhCw9JdE8jvxnsSaz0bid7o1fXuwp4ndEw12qGxL5aQ2LnWM47FkTNqkxGzE2Ds6O4j+hEg4+BLE1cww= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779962008; c=relaxed/simple; bh=p7R2smM3R79rduZHUJp+jpkBMb33NIUw+a924uaK5L0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CNqvy6s+gaQB/3WyKu2seAvYrQtLUYBXJgRv1TfgBd1MQUJWlLT8tWlheEfQ9W+kcm7EhIv7thD3h8eN4x02Fro2XsoduxY6bl17Skqvoiz0zWmSvn82akVKemY1H0xYvZ1m2WIS6ZS5wjSOCCUeU/ewFNPM+XaLyo1zuz79rPg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=sk5xpDBr; arc=none smtp.client-ip=91.218.175.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="sk5xpDBr" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779962004; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v3vBrP0czaKHTwDPD06avz57QmH+1JNC+yH6Fj/n/GA=; b=sk5xpDBr47nH4YUBnVq2KUK2/+UXlt8usoKUf6Y+8gEF8KPMkHtwSRb8O6Drk6AquU3OX3 TIdfIFYTVVdzSyz5lkB4UuYwzI3wqP1cL3M8Qex/creCZdP56x8yevEHAkkXYekhECnFSi PllMc7zDX3aNAYJ45Yy1gFsF/ftvc9k= From: Hao Li To: vbabka@kernel.org, harry@kernel.org, akpm@linux-foundation.org Cc: cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hao Li Subject: [PATCH v2 2/2] mm/slub: introduce helper to decrement partial slab count and clear flag Date: Thu, 28 May 2026 17:52:44 +0800 Message-ID: <20260528095254.43721-3-hao.li@linux.dev> In-Reply-To: <20260528095254.43721-1-hao.li@linux.dev> References: <20260528095254.43721-1-hao.li@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Wrap the partial slab count decrement and slab_clear_node_partial() into a helper function to reduce code duplication. Suggested-by: Harry Yoo Signed-off-by: Hao Li --- mm/slub.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index eb60b3da23ff..71305290c8ca 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -3539,13 +3539,19 @@ static inline void add_partial(struct kmem_cache_node *n, __add_partial(n, slab, mode); } +static inline void clear_node_partial_state(struct kmem_cache_node *n, + struct slab *slab) +{ + slab_clear_node_partial(slab); + n->nr_partial--; +} + static inline void remove_partial(struct kmem_cache_node *n, struct slab *slab) { lockdep_assert_held(&n->list_lock); list_del(&slab->slab_list); - slab_clear_node_partial(slab); - n->nr_partial--; + clear_node_partial_state(n, slab); } /* @@ -3786,8 +3792,7 @@ static bool get_partial_node_bulk(struct kmem_cache *s, if (!first) first = slab; last = slab; - slab_clear_node_partial(slab); - n->nr_partial--; + clear_node_partial_state(n, slab); total_free += slab_free; if (total_free >= pc->max_objects) @@ -8286,8 +8291,7 @@ static int __kmem_cache_do_shrink(struct kmem_cache *s) if (free == slab->objects) { list_move(&slab->slab_list, &discard); - slab_clear_node_partial(slab); - n->nr_partial--; + clear_node_partial_state(n, slab); dec_slabs_node(s, node, slab->objects); } else if (free <= SHRINK_PROMOTE_MAX) list_move(&slab->slab_list, promote + free - 1); -- 2.54.0